Re: [PATCH 00/10] Various load-balance cleanups/optimizations -v2

2013-08-20 Thread Joonsoo Kim
On Mon, Aug 19, 2013 at 06:00:58PM +0200, Peter Zijlstra wrote: > > After poking at them a little more I feel somewhat more confident. > > I found one more bug, but this one was my own fault, we should also clear > sds->busiest_stat.avg_load because update_sd_pick_busiest() reads that before >

Re: [PATCH 00/10] Various load-balance cleanups/optimizations -v2

2013-08-20 Thread Joonsoo Kim
On Mon, Aug 19, 2013 at 06:00:58PM +0200, Peter Zijlstra wrote: After poking at them a little more I feel somewhat more confident. I found one more bug, but this one was my own fault, we should also clear sds-busiest_stat.avg_load because update_sd_pick_busiest() reads that before we set

[PATCH 00/10] Various load-balance cleanups/optimizations -v2

2013-08-19 Thread Peter Zijlstra
After poking at them a little more I feel somewhat more confident. I found one more bug, but this one was my own fault, we should also clear sds->busiest_stat.avg_load because update_sd_pick_busiest() reads that before we set it. Moved the memset optimization and the fix for that into a

[PATCH 00/10] Various load-balance cleanups/optimizations -v2

2013-08-19 Thread Peter Zijlstra
After poking at them a little more I feel somewhat more confident. I found one more bug, but this one was my own fault, we should also clear sds-busiest_stat.avg_load because update_sd_pick_busiest() reads that before we set it. Moved the memset optimization and the fix for that into a separate