Re: [PATCH 00/16] usb: gadget: amd5536udc: fix memory leaks

2015-09-21 Thread Felipe Balbi
On Mon, Sep 21, 2015 at 06:18:04PM +0530, Sudip Mukherjee wrote: > On Sun, Sep 20, 2015 at 11:17:36AM -0500, Felipe Balbi wrote: > > On Sun, Sep 20, 2015 at 01:42:42PM +0530, Sudip Mukherjee wrote: > > > On Sat, Sep 19, 2015 at 09:24:38AM +0530, Sudip Mukherjee wrote: > > > > On Fri, Sep 18, 2015

Re: [PATCH 00/16] usb: gadget: amd5536udc: fix memory leaks

2015-09-21 Thread Sudip Mukherjee
On Sun, Sep 20, 2015 at 11:17:36AM -0500, Felipe Balbi wrote: > On Sun, Sep 20, 2015 at 01:42:42PM +0530, Sudip Mukherjee wrote: > > On Sat, Sep 19, 2015 at 09:24:38AM +0530, Sudip Mukherjee wrote: > > > On Fri, Sep 18, 2015 at 01:39:54PM -0500, Felipe Balbi wrote: > > > > On Mon, Sep 14, 2015 at

Re: [PATCH 00/16] usb: gadget: amd5536udc: fix memory leaks

2015-09-21 Thread Sudip Mukherjee
On Sun, Sep 20, 2015 at 11:17:36AM -0500, Felipe Balbi wrote: > On Sun, Sep 20, 2015 at 01:42:42PM +0530, Sudip Mukherjee wrote: > > On Sat, Sep 19, 2015 at 09:24:38AM +0530, Sudip Mukherjee wrote: > > > On Fri, Sep 18, 2015 at 01:39:54PM -0500, Felipe Balbi wrote: > > > > On Mon, Sep 14, 2015 at

Re: [PATCH 00/16] usb: gadget: amd5536udc: fix memory leaks

2015-09-21 Thread Felipe Balbi
On Mon, Sep 21, 2015 at 06:18:04PM +0530, Sudip Mukherjee wrote: > On Sun, Sep 20, 2015 at 11:17:36AM -0500, Felipe Balbi wrote: > > On Sun, Sep 20, 2015 at 01:42:42PM +0530, Sudip Mukherjee wrote: > > > On Sat, Sep 19, 2015 at 09:24:38AM +0530, Sudip Mukherjee wrote: > > > > On Fri, Sep 18, 2015

Re: [PATCH 00/16] usb: gadget: amd5536udc: fix memory leaks

2015-09-20 Thread Felipe Balbi
On Sun, Sep 20, 2015 at 01:42:42PM +0530, Sudip Mukherjee wrote: > On Sat, Sep 19, 2015 at 09:24:38AM +0530, Sudip Mukherjee wrote: > > On Fri, Sep 18, 2015 at 01:39:54PM -0500, Felipe Balbi wrote: > > > On Mon, Sep 14, 2015 at 08:42:47PM +0530, Sudip Mukherjee wrote: > > > > This amd5536udc was a

Re: [PATCH 00/16] usb: gadget: amd5536udc: fix memory leaks

2015-09-20 Thread Felipe Balbi
Hi, On Sat, Sep 19, 2015 at 09:24:38AM +0530, Sudip Mukherjee wrote: > On Fri, Sep 18, 2015 at 01:39:54PM -0500, Felipe Balbi wrote: > > On Mon, Sep 14, 2015 at 08:42:47PM +0530, Sudip Mukherjee wrote: > > > This amd5536udc was a complete mess. The major problems that i could > > > find are: > >

Re: [PATCH 00/16] usb: gadget: amd5536udc: fix memory leaks

2015-09-20 Thread Sudip Mukherjee
On Sat, Sep 19, 2015 at 09:24:38AM +0530, Sudip Mukherjee wrote: > On Fri, Sep 18, 2015 at 01:39:54PM -0500, Felipe Balbi wrote: > > On Mon, Sep 14, 2015 at 08:42:47PM +0530, Sudip Mukherjee wrote: > > > This amd5536udc was a complete mess. The major problems that i could > > > find are: > > > >

Re: [PATCH 00/16] usb: gadget: amd5536udc: fix memory leaks

2015-09-20 Thread Sudip Mukherjee
On Sat, Sep 19, 2015 at 09:24:38AM +0530, Sudip Mukherjee wrote: > On Fri, Sep 18, 2015 at 01:39:54PM -0500, Felipe Balbi wrote: > > On Mon, Sep 14, 2015 at 08:42:47PM +0530, Sudip Mukherjee wrote: > > > This amd5536udc was a complete mess. The major problems that i could > > > find are: > > > >

Re: [PATCH 00/16] usb: gadget: amd5536udc: fix memory leaks

2015-09-20 Thread Felipe Balbi
Hi, On Sat, Sep 19, 2015 at 09:24:38AM +0530, Sudip Mukherjee wrote: > On Fri, Sep 18, 2015 at 01:39:54PM -0500, Felipe Balbi wrote: > > On Mon, Sep 14, 2015 at 08:42:47PM +0530, Sudip Mukherjee wrote: > > > This amd5536udc was a complete mess. The major problems that i could > > > find are: > >

Re: [PATCH 00/16] usb: gadget: amd5536udc: fix memory leaks

2015-09-20 Thread Felipe Balbi
On Sun, Sep 20, 2015 at 01:42:42PM +0530, Sudip Mukherjee wrote: > On Sat, Sep 19, 2015 at 09:24:38AM +0530, Sudip Mukherjee wrote: > > On Fri, Sep 18, 2015 at 01:39:54PM -0500, Felipe Balbi wrote: > > > On Mon, Sep 14, 2015 at 08:42:47PM +0530, Sudip Mukherjee wrote: > > > > This amd5536udc was a

Re: [PATCH 00/16] usb: gadget: amd5536udc: fix memory leaks

2015-09-18 Thread Sudip Mukherjee
On Fri, Sep 18, 2015 at 01:39:54PM -0500, Felipe Balbi wrote: > On Mon, Sep 14, 2015 at 08:42:47PM +0530, Sudip Mukherjee wrote: > > This amd5536udc was a complete mess. The major problems that i could > > find are: > > > > 1) if udc_pci_probe() fails in any stage then it just calls the > >

Re: [PATCH 00/16] usb: gadget: amd5536udc: fix memory leaks

2015-09-18 Thread Felipe Balbi
On Mon, Sep 14, 2015 at 08:42:47PM +0530, Sudip Mukherjee wrote: > This amd5536udc was a complete mess. The major problems that i could > find are: > > 1) if udc_pci_probe() fails in any stage then it just calls the > udc_pci_remove() to handle error. And udc_pci_remove() works with > struct udc

Re: [PATCH 00/16] usb: gadget: amd5536udc: fix memory leaks

2015-09-18 Thread Felipe Balbi
On Mon, Sep 14, 2015 at 08:42:47PM +0530, Sudip Mukherjee wrote: > This amd5536udc was a complete mess. The major problems that i could > find are: > > 1) if udc_pci_probe() fails in any stage then it just calls the > udc_pci_remove() to handle error. And udc_pci_remove() works with > struct udc

Re: [PATCH 00/16] usb: gadget: amd5536udc: fix memory leaks

2015-09-18 Thread Sudip Mukherjee
On Fri, Sep 18, 2015 at 01:39:54PM -0500, Felipe Balbi wrote: > On Mon, Sep 14, 2015 at 08:42:47PM +0530, Sudip Mukherjee wrote: > > This amd5536udc was a complete mess. The major problems that i could > > find are: > > > > 1) if udc_pci_probe() fails in any stage then it just calls the > >

[PATCH 00/16] usb: gadget: amd5536udc: fix memory leaks

2015-09-14 Thread Sudip Mukherjee
This amd5536udc was a complete mess. The major problems that i could find are: 1) if udc_pci_probe() fails in any stage then it just calls the udc_pci_remove() to handle error. And udc_pci_remove() works with struct udc *dev which we get from pci_get_drvdata(pdev). But we do the

[PATCH 00/16] usb: gadget: amd5536udc: fix memory leaks

2015-09-14 Thread Sudip Mukherjee
This amd5536udc was a complete mess. The major problems that i could find are: 1) if udc_pci_probe() fails in any stage then it just calls the udc_pci_remove() to handle error. And udc_pci_remove() works with struct udc *dev which we get from pci_get_drvdata(pdev). But we do the