Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-10-05 Thread Mark Brown
On Sat, Oct 03, 2020 at 12:43:13PM -0700, Joe Perches wrote: > On Sat, 2020-10-03 at 15:31 -0400, Konstantin Ryabitsev wrote: > > I'm worried that this can get unwieldy for series of 50 patches where 49 > > got applied. Would the following be better: ... > > A subset of these patches was

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-10-03 Thread Joe Perches
On Sat, 2020-10-03 at 15:31 -0400, Konstantin Ryabitsev wrote: > On Sat, Oct 03, 2020 at 09:18:51PM +0200, Julia Lawall wrote: > > > > There seems to be some mismatch between b4's use of the > > > > cover letter to a patch series and what maintainers that > > > > apply a subset of the patches in

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-10-03 Thread Joe Perches
On Sat, 2020-10-03 at 12:27 -0700, Joe Perches wrote: > On Sat, 2020-10-03 at 15:15 -0400, Konstantin Ryabitsev wrote: > > On Sat, Oct 03, 2020 at 11:40:48AM -0700, Joe Perches wrote: > > > (Adding tools and Konstantin Ryabitsev) > > > > > > There seems to be some mismatch between b4's use of the

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-10-03 Thread Konstantin Ryabitsev
On Sat, Oct 03, 2020 at 09:18:51PM +0200, Julia Lawall wrote: > > > There seems to be some mismatch between b4's use of the > > > cover letter to a patch series and what maintainers that > > > apply a subset of the patches in the patch series. > > > > > > The merge description shows the entire

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-10-03 Thread Joe Perches
On Sat, 2020-10-03 at 15:15 -0400, Konstantin Ryabitsev wrote: > On Sat, Oct 03, 2020 at 11:40:48AM -0700, Joe Perches wrote: > > (Adding tools and Konstantin Ryabitsev) > > > > There seems to be some mismatch between b4's use of the > > cover letter to a patch series and what maintainers that >

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-10-03 Thread Julia Lawall
On Sat, 3 Oct 2020, Konstantin Ryabitsev wrote: > On Sat, Oct 03, 2020 at 11:40:48AM -0700, Joe Perches wrote: > > (Adding tools and Konstantin Ryabitsev) > > > > There seems to be some mismatch between b4's use of the > > cover letter to a patch series and what maintainers that > > apply a

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-10-03 Thread Konstantin Ryabitsev
On Sat, Oct 03, 2020 at 11:40:48AM -0700, Joe Perches wrote: > (Adding tools and Konstantin Ryabitsev) > > There seems to be some mismatch between b4's use of the > cover letter to a patch series and what maintainers that > apply a subset of the patches in the patch series. > > The merge

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-10-03 Thread Joe Perches
(Adding tools and Konstantin Ryabitsev) There seems to be some mismatch between b4's use of the cover letter to a patch series and what maintainers that apply a subset of the patches in the patch series. The merge description shows the entire patch series as applied, but the actual merge is only

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-10-02 Thread Shuah Khan
On 9/29/20 7:42 AM, Shuah Khan wrote: On 9/29/20 7:34 AM, Joe Perches wrote: On Tue, 2020-09-29 at 14:47 +0200, Julia Lawall wrote: On Tue, 29 Sep 2020, Dan Carpenter wrote: The times where commas are used deliberately to replace curly braces are just evil.  Either way the code is cleaner

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-10-01 Thread Mark Brown
On Wed, Sep 30, 2020 at 12:33:39PM -0700, Joe Perches wrote: > On Tue, 2020-09-29 at 12:37 +0100, Mark Brown wrote: > > Feel free to submit patches to b4. > Have you tried the existing option to send > thank you's on a specific ranges of patches? I am relying on b4 to identify which patches

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-09-30 Thread Joe Perches
On Tue, 2020-09-29 at 12:37 +0100, Mark Brown wrote: > On Mon, Sep 28, 2020 at 05:45:24PM -0700, Joe Perches wrote: > > On Mon, 2020-09-28 at 20:35 +0100, Mark Brown wrote: > > > [1/1] regmap: debugfs: use semicolons rather than commas to separate > > > statements > > > commit:

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-09-29 Thread Shuah Khan
On 9/29/20 7:34 AM, Joe Perches wrote: On Tue, 2020-09-29 at 14:47 +0200, Julia Lawall wrote: On Tue, 29 Sep 2020, Dan Carpenter wrote: The times where commas are used deliberately to replace curly braces are just evil. Either way the code is cleaner with semi-colons. I also found exaamples

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-09-29 Thread Julia Lawall
On Tue, 29 Sep 2020, Joe Perches wrote: > On Tue, 2020-09-29 at 14:47 +0200, Julia Lawall wrote: > > On Tue, 29 Sep 2020, Dan Carpenter wrote: > > > The times where commas are used deliberately to replace curly braces are > > > just evil. Either way the code is cleaner with semi-colons. > > >

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-09-29 Thread Joe Perches
On Tue, 2020-09-29 at 14:47 +0200, Julia Lawall wrote: > On Tue, 29 Sep 2020, Dan Carpenter wrote: > > The times where commas are used deliberately to replace curly braces are > > just evil. Either way the code is cleaner with semi-colons. > > I also found exaamples like the following to be

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-09-29 Thread Julia Lawall
On Tue, 29 Sep 2020, Dan Carpenter wrote: > On Tue, Sep 29, 2020 at 02:20:00PM +0200, Ard Biesheuvel wrote: > > On Sun, 27 Sep 2020 at 21:56, Julia Lawall wrote: > > > > > > These patches replace commas by semicolons. > > > > > > Why? > > > > In the best case, these commas are just

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-09-29 Thread Julia Lawall
On Tue, 29 Sep 2020, Mark Brown wrote: > On Tue, Sep 29, 2020 at 01:46:19PM +0200, Julia Lawall wrote: > > On Tue, 29 Sep 2020, Mark Brown wrote: > > > > Feel free to submit patches to b4. Ideally things like this wouldn't be > > > being sent as serieses in the first place, there's no

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-09-29 Thread Dan Carpenter
On Tue, Sep 29, 2020 at 02:20:00PM +0200, Ard Biesheuvel wrote: > On Sun, 27 Sep 2020 at 21:56, Julia Lawall wrote: > > > > These patches replace commas by semicolons. > > > Why? > In the best case, these commas are just uninitentional mess, like typing an extra space character or something.

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-09-29 Thread Mark Brown
On Tue, Sep 29, 2020 at 01:46:19PM +0200, Julia Lawall wrote: > On Tue, 29 Sep 2020, Mark Brown wrote: > > Feel free to submit patches to b4. Ideally things like this wouldn't be > > being sent as serieses in the first place, there's no dependencies or > > interactions between the patches. > It

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-09-29 Thread Julia Lawall
On Tue, 29 Sep 2020, Ard Biesheuvel wrote: > On Sun, 27 Sep 2020 at 21:56, Julia Lawall wrote: > > > > These patches replace commas by semicolons. > > > Why? Among the complete 5000 lines of changes there is one probable bug where an if branch ends with a comma and thus pulls the subsequent

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-09-29 Thread Ard Biesheuvel
On Sun, 27 Sep 2020 at 21:56, Julia Lawall wrote: > > These patches replace commas by semicolons. Why? > This was done using the > Coccinelle semantic patch (http://coccinelle.lip6.fr/) shown below. > > This semantic patch ensures that commas inside for loop headers will not be > transformed.

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-09-29 Thread Julia Lawall
On Tue, 29 Sep 2020, Mark Brown wrote: > On Mon, Sep 28, 2020 at 05:45:24PM -0700, Joe Perches wrote: > > On Mon, 2020-09-28 at 20:35 +0100, Mark Brown wrote: > > > > [1/1] regmap: debugfs: use semicolons rather than commas to separate > > > statements > > > commit:

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-09-29 Thread Mark Brown
On Mon, Sep 28, 2020 at 05:45:24PM -0700, Joe Perches wrote: > On Mon, 2020-09-28 at 20:35 +0100, Mark Brown wrote: > > [1/1] regmap: debugfs: use semicolons rather than commas to separate > > statements > > commit: 7f4a122d0b50b40c64d24a5cf7aafe26dd9487ee > Rather than replying to the

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-09-28 Thread Joe Perches
On Mon, 2020-09-28 at 20:35 +0100, Mark Brown wrote: > On Sun, 27 Sep 2020 21:12:10 +0200, Julia Lawall wrote: > > These patches replace commas by semicolons. This was done using the > > Coccinelle semantic patch (http://coccinelle.lip6.fr/) shown below. > > > > This semantic patch ensures that

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-09-27 Thread Joe Perches
On Sun, 2020-09-27 at 21:12 +0200, Julia Lawall wrote: > These patches replace commas by semicolons. This was done using the > Coccinelle semantic patch (http://coccinelle.lip6.fr/) shown below. > > This semantic patch ensures that commas inside for loop headers will not be > transformed. It

[PATCH 00/18] use semicolons rather than commas to separate statements

2020-09-27 Thread Julia Lawall
These patches replace commas by semicolons. This was done using the Coccinelle semantic patch (http://coccinelle.lip6.fr/) shown below. This semantic patch ensures that commas inside for loop headers will not be transformed. It also doesn't touch macro definitions. Coccinelle ensures that