Re: [PATCH 00/19] fs: rework and optimize i_version handling in filesystems

2017-12-15 Thread J. Bruce Fields
On Fri, Dec 15, 2017 at 10:15:29AM -0500, Jeff Layton wrote: > On Thu, 2017-12-14 at 10:14 -0500, J. Bruce Fields wrote: > > On Thu, Dec 14, 2017 at 09:14:47AM -0500, Jeff Layton wrote: > > > There is some clear peformance impact when you are running frequent > > > queries of the i_version. > > >

Re: [PATCH 00/19] fs: rework and optimize i_version handling in filesystems

2017-12-15 Thread J. Bruce Fields
On Fri, Dec 15, 2017 at 10:15:29AM -0500, Jeff Layton wrote: > On Thu, 2017-12-14 at 10:14 -0500, J. Bruce Fields wrote: > > On Thu, Dec 14, 2017 at 09:14:47AM -0500, Jeff Layton wrote: > > > There is some clear peformance impact when you are running frequent > > > queries of the i_version. > > >

Re: [PATCH 00/19] fs: rework and optimize i_version handling in filesystems

2017-12-15 Thread Jeff Layton
On Thu, 2017-12-14 at 10:14 -0500, J. Bruce Fields wrote: > On Thu, Dec 14, 2017 at 09:14:47AM -0500, Jeff Layton wrote: > > On Wed, 2017-12-13 at 19:02 -0500, Jeff Layton wrote: > > > On Thu, 2017-12-14 at 10:03 +1100, Dave Chinner wrote: > > > > On Wed, Dec 13, 2017 at 03:14:28PM -0500, Jeff

Re: [PATCH 00/19] fs: rework and optimize i_version handling in filesystems

2017-12-15 Thread Jeff Layton
On Thu, 2017-12-14 at 10:14 -0500, J. Bruce Fields wrote: > On Thu, Dec 14, 2017 at 09:14:47AM -0500, Jeff Layton wrote: > > On Wed, 2017-12-13 at 19:02 -0500, Jeff Layton wrote: > > > On Thu, 2017-12-14 at 10:03 +1100, Dave Chinner wrote: > > > > On Wed, Dec 13, 2017 at 03:14:28PM -0500, Jeff

Re: [PATCH 00/19] fs: rework and optimize i_version handling in filesystems

2017-12-14 Thread J. Bruce Fields
On Thu, Dec 14, 2017 at 09:14:47AM -0500, Jeff Layton wrote: > On Wed, 2017-12-13 at 19:02 -0500, Jeff Layton wrote: > > On Thu, 2017-12-14 at 10:03 +1100, Dave Chinner wrote: > > > On Wed, Dec 13, 2017 at 03:14:28PM -0500, Jeff Layton wrote: > > > > On Wed, 2017-12-13 at 10:05 -0500, J. Bruce

Re: [PATCH 00/19] fs: rework and optimize i_version handling in filesystems

2017-12-14 Thread J. Bruce Fields
On Thu, Dec 14, 2017 at 09:14:47AM -0500, Jeff Layton wrote: > On Wed, 2017-12-13 at 19:02 -0500, Jeff Layton wrote: > > On Thu, 2017-12-14 at 10:03 +1100, Dave Chinner wrote: > > > On Wed, Dec 13, 2017 at 03:14:28PM -0500, Jeff Layton wrote: > > > > On Wed, 2017-12-13 at 10:05 -0500, J. Bruce

Re: [PATCH 00/19] fs: rework and optimize i_version handling in filesystems

2017-12-14 Thread Jeff Layton
On Wed, 2017-12-13 at 19:02 -0500, Jeff Layton wrote: > On Thu, 2017-12-14 at 10:03 +1100, Dave Chinner wrote: > > On Wed, Dec 13, 2017 at 03:14:28PM -0500, Jeff Layton wrote: > > > On Wed, 2017-12-13 at 10:05 -0500, J. Bruce Fields wrote: > > > > This is great, thanks. > > > > > > > > On Wed,

Re: [PATCH 00/19] fs: rework and optimize i_version handling in filesystems

2017-12-14 Thread Jeff Layton
On Wed, 2017-12-13 at 19:02 -0500, Jeff Layton wrote: > On Thu, 2017-12-14 at 10:03 +1100, Dave Chinner wrote: > > On Wed, Dec 13, 2017 at 03:14:28PM -0500, Jeff Layton wrote: > > > On Wed, 2017-12-13 at 10:05 -0500, J. Bruce Fields wrote: > > > > This is great, thanks. > > > > > > > > On Wed,

Re: [PATCH 00/19] fs: rework and optimize i_version handling in filesystems

2017-12-13 Thread Jeff Layton
On Thu, 2017-12-14 at 10:03 +1100, Dave Chinner wrote: > On Wed, Dec 13, 2017 at 03:14:28PM -0500, Jeff Layton wrote: > > On Wed, 2017-12-13 at 10:05 -0500, J. Bruce Fields wrote: > > > This is great, thanks. > > > > > > On Wed, Dec 13, 2017 at 09:19:58AM -0500, Jeff Layton wrote: > > > > With

Re: [PATCH 00/19] fs: rework and optimize i_version handling in filesystems

2017-12-13 Thread Jeff Layton
On Thu, 2017-12-14 at 10:03 +1100, Dave Chinner wrote: > On Wed, Dec 13, 2017 at 03:14:28PM -0500, Jeff Layton wrote: > > On Wed, 2017-12-13 at 10:05 -0500, J. Bruce Fields wrote: > > > This is great, thanks. > > > > > > On Wed, Dec 13, 2017 at 09:19:58AM -0500, Jeff Layton wrote: > > > > With

Re: [PATCH 00/19] fs: rework and optimize i_version handling in filesystems

2017-12-13 Thread Dave Chinner
On Wed, Dec 13, 2017 at 03:14:28PM -0500, Jeff Layton wrote: > On Wed, 2017-12-13 at 10:05 -0500, J. Bruce Fields wrote: > > This is great, thanks. > > > > On Wed, Dec 13, 2017 at 09:19:58AM -0500, Jeff Layton wrote: > > > With this, we reduce inode metadata updates across all 3 filesystems > > >

Re: [PATCH 00/19] fs: rework and optimize i_version handling in filesystems

2017-12-13 Thread Dave Chinner
On Wed, Dec 13, 2017 at 03:14:28PM -0500, Jeff Layton wrote: > On Wed, 2017-12-13 at 10:05 -0500, J. Bruce Fields wrote: > > This is great, thanks. > > > > On Wed, Dec 13, 2017 at 09:19:58AM -0500, Jeff Layton wrote: > > > With this, we reduce inode metadata updates across all 3 filesystems > > >

Re: [PATCH 00/19] fs: rework and optimize i_version handling in filesystems

2017-12-13 Thread Jeff Layton
On Wed, 2017-12-13 at 15:14 -0500, Jeff Layton wrote: > On Wed, 2017-12-13 at 10:05 -0500, J. Bruce Fields wrote: > > This is great, thanks. > > > > On Wed, Dec 13, 2017 at 09:19:58AM -0500, Jeff Layton wrote: > > > With this, we reduce inode metadata updates across all 3 filesystems > > > down

Re: [PATCH 00/19] fs: rework and optimize i_version handling in filesystems

2017-12-13 Thread Jeff Layton
On Wed, 2017-12-13 at 15:14 -0500, Jeff Layton wrote: > On Wed, 2017-12-13 at 10:05 -0500, J. Bruce Fields wrote: > > This is great, thanks. > > > > On Wed, Dec 13, 2017 at 09:19:58AM -0500, Jeff Layton wrote: > > > With this, we reduce inode metadata updates across all 3 filesystems > > > down

Re: [PATCH 00/19] fs: rework and optimize i_version handling in filesystems

2017-12-13 Thread Jeff Layton
On Wed, 2017-12-13 at 10:05 -0500, J. Bruce Fields wrote: > This is great, thanks. > > On Wed, Dec 13, 2017 at 09:19:58AM -0500, Jeff Layton wrote: > > With this, we reduce inode metadata updates across all 3 filesystems > > down to roughly the frequency of the timestamp granularity, particularly

Re: [PATCH 00/19] fs: rework and optimize i_version handling in filesystems

2017-12-13 Thread Jeff Layton
On Wed, 2017-12-13 at 10:05 -0500, J. Bruce Fields wrote: > This is great, thanks. > > On Wed, Dec 13, 2017 at 09:19:58AM -0500, Jeff Layton wrote: > > With this, we reduce inode metadata updates across all 3 filesystems > > down to roughly the frequency of the timestamp granularity, particularly

Re: [PATCH 00/19] fs: rework and optimize i_version handling in filesystems

2017-12-13 Thread J. Bruce Fields
This is great, thanks. On Wed, Dec 13, 2017 at 09:19:58AM -0500, Jeff Layton wrote: > With this, we reduce inode metadata updates across all 3 filesystems > down to roughly the frequency of the timestamp granularity, particularly > when it's not being queried (the vastly common case). > > The

Re: [PATCH 00/19] fs: rework and optimize i_version handling in filesystems

2017-12-13 Thread J. Bruce Fields
This is great, thanks. On Wed, Dec 13, 2017 at 09:19:58AM -0500, Jeff Layton wrote: > With this, we reduce inode metadata updates across all 3 filesystems > down to roughly the frequency of the timestamp granularity, particularly > when it's not being queried (the vastly common case). > > The

[PATCH 00/19] fs: rework and optimize i_version handling in filesystems

2017-12-13 Thread Jeff Layton
From: Jeff Layton About a year ago, I sent a pile of patches that overhauled how the inode->i_version field is handled in filesystems. This is a follow up to that initial series. tl;dr: I think we can greatly reduce the cost of the inode->i_version counter, by exploiting the

[PATCH 00/19] fs: rework and optimize i_version handling in filesystems

2017-12-13 Thread Jeff Layton
From: Jeff Layton About a year ago, I sent a pile of patches that overhauled how the inode->i_version field is handled in filesystems. This is a follow up to that initial series. tl;dr: I think we can greatly reduce the cost of the inode->i_version counter, by exploiting the fact that we don't