Re: [PATCH 00/22] lp8727_charger: clean up code

2012-09-20 Thread Anton Vorontsov
On Fri, Aug 31, 2012 at 09:22:39AM +, Kim, Milo wrote: > LP8727 driver should be fixed for several reasons. > > (a) Need to clean up _probe() and _remove() > (b) Not secure code when the platform data is NULL > (c) Improved the interrupt handling > (d) Lots of definitions should be unique. >

Re: [PATCH 00/22] lp8727_charger: clean up code

2012-09-20 Thread Anton Vorontsov
On Fri, Aug 31, 2012 at 09:22:39AM +, Kim, Milo wrote: LP8727 driver should be fixed for several reasons. (a) Need to clean up _probe() and _remove() (b) Not secure code when the platform data is NULL (c) Improved the interrupt handling (d) Lots of definitions should be unique. (e)

[PATCH 00/22] lp8727_charger: clean up code

2012-08-31 Thread Kim, Milo
LP8727 driver should be fixed for several reasons. (a) Need to clean up _probe() and _remove() (b) Not secure code when the platform data is NULL (c) Improved the interrupt handling (d) Lots of definitions should be unique. (e) Others... Patch v2. These patches are submitted more separately.

[PATCH 00/22] lp8727_charger: clean up code

2012-08-31 Thread Kim, Milo
LP8727 driver should be fixed for several reasons. (a) Need to clean up _probe() and _remove() (b) Not secure code when the platform data is NULL (c) Improved the interrupt handling (d) Lots of definitions should be unique. (e) Others... Patch v2. These patches are submitted more separately.