Re: [PATCH 00/30] spi: dw: Add full Baikal-T1 SPI Controllers support

2020-09-30 Thread Mark Brown
On Wed, Sep 30, 2020 at 04:11:15PM +0300, Serge Semin wrote: > On Wed, Sep 30, 2020 at 12:04:04PM +0100, Mark Brown wrote: > > Not all of the first 9, IIRC I skipped one I had comments on. > Yes, you skipped one and I've already given you my response on your comment > about it: [PATCH 02/30]

Re: [PATCH 00/30] spi: dw: Add full Baikal-T1 SPI Controllers support

2020-09-30 Thread Serge Semin
On Wed, Sep 30, 2020 at 12:04:04PM +0100, Mark Brown wrote: > On Wed, Sep 30, 2020 at 01:43:03AM +0300, Serge Semin wrote: > > On Tue, Sep 29, 2020 at 03:43:51PM +0100, Mark Brown wrote: > > > > This is a *huge* patch series which is a bit unweildy to review > > > (especially given the other 10+

Re: [PATCH 00/30] spi: dw: Add full Baikal-T1 SPI Controllers support

2020-09-30 Thread Mark Brown
On Wed, Sep 30, 2020 at 01:43:03AM +0300, Serge Semin wrote: > On Tue, Sep 29, 2020 at 03:43:51PM +0100, Mark Brown wrote: > > This is a *huge* patch series which is a bit unweildy to review > > (especially given the other 10+ patch series you sent at the same time), > Yeah, sorry about the

Re: [PATCH 00/30] spi: dw: Add full Baikal-T1 SPI Controllers support

2020-09-29 Thread Serge Semin
Hi Mark On Tue, Sep 29, 2020 at 03:43:51PM +0100, Mark Brown wrote: > On Sun, Sep 20, 2020 at 02:28:44PM +0300, Serge Semin wrote: > > > First two patches are just cleanups to simplify the DW APB SSI device > > initialization a bit. We suggest to discard the IRQ threshold macro as > > unused and

Re: [PATCH 00/30] spi: dw: Add full Baikal-T1 SPI Controllers support

2020-09-29 Thread Mark Brown
On Sun, 20 Sep 2020 14:28:44 +0300, Serge Semin wrote: > Originally I intended to merge a dedicated Baikal-T1 System Boot SPI > Controller driver into the kernel and leave the DW APB SSI driver > untouched. But after a long discussion (see the link at the bottom of the > letter) Mark and Andy

Re: [PATCH 00/30] spi: dw: Add full Baikal-T1 SPI Controllers support

2020-09-29 Thread Mark Brown
On Sun, Sep 20, 2020 at 02:28:44PM +0300, Serge Semin wrote: > First two patches are just cleanups to simplify the DW APB SSI device > initialization a bit. We suggest to discard the IRQ threshold macro as > unused and use a ternary operator to initialize the set_cs callback > instead of

[PATCH 00/30] spi: dw: Add full Baikal-T1 SPI Controllers support

2020-09-20 Thread Serge Semin
Originally I intended to merge a dedicated Baikal-T1 System Boot SPI Controller driver into the kernel and leave the DW APB SSI driver untouched. But after a long discussion (see the link at the bottom of the letter) Mark and Andy persuaded me to integrate what we developed there into the DW APB