Re: [PATCH 00/39 v7] PTI support for x86-32

2018-07-17 Thread Joerg Roedel
Hi Dave, On Mon, Jul 16, 2018 at 10:07:44PM -0400, David H. Gutteridge wrote: > I redid my testing on bare metal and in a VM (as with my previous > testing > efforts: https://lkml.org/lkml/2018/2/19/844, same setups > and coverage, > plus CONFIG_X86_DEBUG_ENTRY_CR3 enabled too) with the >

Re: [PATCH 00/39 v7] PTI support for x86-32

2018-07-17 Thread Joerg Roedel
Hi Dave, On Mon, Jul 16, 2018 at 10:07:44PM -0400, David H. Gutteridge wrote: > I redid my testing on bare metal and in a VM (as with my previous > testing > efforts: https://lkml.org/lkml/2018/2/19/844, same setups > and coverage, > plus CONFIG_X86_DEBUG_ENTRY_CR3 enabled too) with the >

Re: [PATCH 00/39 v7] PTI support for x86-32

2018-07-16 Thread David H. Gutteridge
On Wed, 2018-07-11 at 13:29 +0200, Joerg Roedel wrote: > Hi, > > here is version 7 of my patches to enable PTI on x86-32. > Changes to the previous version are: > > * Rebased to v4.18-rc4 > > * Introduced pti_finalize() which is called after > mark_readonly() and used to

Re: [PATCH 00/39 v7] PTI support for x86-32

2018-07-16 Thread David H. Gutteridge
On Wed, 2018-07-11 at 13:29 +0200, Joerg Roedel wrote: > Hi, > > here is version 7 of my patches to enable PTI on x86-32. > Changes to the previous version are: > > * Rebased to v4.18-rc4 > > * Introduced pti_finalize() which is called after > mark_readonly() and used to

Re: [PATCH 00/39 v7] PTI support for x86-32

2018-07-16 Thread Pavel Machek
Hi! > here is version 7 of my patches to enable PTI on x86-32. > Changes to the previous version are: > > * Rebased to v4.18-rc4 > > * Introduced pti_finalize() which is called after > mark_readonly() and used to update the kernel > mappings in the user page-table

Re: [PATCH 00/39 v7] PTI support for x86-32

2018-07-16 Thread Pavel Machek
Hi! > here is version 7 of my patches to enable PTI on x86-32. > Changes to the previous version are: > > * Rebased to v4.18-rc4 > > * Introduced pti_finalize() which is called after > mark_readonly() and used to update the kernel > mappings in the user page-table

Re: [PATCH 00/39 v7] PTI support for x86-32

2018-07-12 Thread Boris Ostrovsky
On 07/11/2018 03:57 PM, Thomas Backlund wrote: > Den 2018-07-11 kl. 20:28, skrev Jiri Kosina: >> On Wed, 11 Jul 2018, Linus Torvalds wrote: >> >>> It's the testing that worries me most. Pretty much no developers run >>> 32-bit any more, and I'd be most worried about the odd interactions >>> that

Re: [PATCH 00/39 v7] PTI support for x86-32

2018-07-12 Thread Boris Ostrovsky
On 07/11/2018 03:57 PM, Thomas Backlund wrote: > Den 2018-07-11 kl. 20:28, skrev Jiri Kosina: >> On Wed, 11 Jul 2018, Linus Torvalds wrote: >> >>> It's the testing that worries me most. Pretty much no developers run >>> 32-bit any more, and I'd be most worried about the odd interactions >>> that

Re: [PATCH 00/39 v7] PTI support for x86-32

2018-07-11 Thread Pavel Machek
On Wed 2018-07-11 09:28:39, Linus Torvalds wrote: > On Wed, Jul 11, 2018 at 4:30 AM Joerg Roedel wrote: > > > > I did the load-testing again with 'perf top', the ldt_gdt > > self-test and a kernel-compile running in a loop again. > > So none of the patches looked scary to me, but then, neither

Re: [PATCH 00/39 v7] PTI support for x86-32

2018-07-11 Thread Pavel Machek
On Wed 2018-07-11 09:28:39, Linus Torvalds wrote: > On Wed, Jul 11, 2018 at 4:30 AM Joerg Roedel wrote: > > > > I did the load-testing again with 'perf top', the ldt_gdt > > self-test and a kernel-compile running in a loop again. > > So none of the patches looked scary to me, but then, neither

Re: [PATCH 00/39 v7] PTI support for x86-32

2018-07-11 Thread Thomas Backlund
Den 2018-07-11 kl. 20:28, skrev Jiri Kosina: On Wed, 11 Jul 2018, Linus Torvalds wrote: It's the testing that worries me most. Pretty much no developers run 32-bit any more, and I'd be most worried about the odd interactions that might be hw-specific. Some crazy EFI mapping setup or the

Re: [PATCH 00/39 v7] PTI support for x86-32

2018-07-11 Thread Thomas Backlund
Den 2018-07-11 kl. 20:28, skrev Jiri Kosina: On Wed, 11 Jul 2018, Linus Torvalds wrote: It's the testing that worries me most. Pretty much no developers run 32-bit any more, and I'd be most worried about the odd interactions that might be hw-specific. Some crazy EFI mapping setup or the

Re: [PATCH 00/39 v7] PTI support for x86-32

2018-07-11 Thread Jiri Kosina
On Wed, 11 Jul 2018, Linus Torvalds wrote: > It's the testing that worries me most. Pretty much no developers run > 32-bit any more, and I'd be most worried about the odd interactions that > might be hw-specific. Some crazy EFI mapping setup or the similar odd > case that simply requires a

Re: [PATCH 00/39 v7] PTI support for x86-32

2018-07-11 Thread Jiri Kosina
On Wed, 11 Jul 2018, Linus Torvalds wrote: > It's the testing that worries me most. Pretty much no developers run > 32-bit any more, and I'd be most worried about the odd interactions that > might be hw-specific. Some crazy EFI mapping setup or the similar odd > case that simply requires a

Re: [PATCH 00/39 v7] PTI support for x86-32

2018-07-11 Thread Linus Torvalds
On Wed, Jul 11, 2018 at 4:30 AM Joerg Roedel wrote: > > I did the load-testing again with 'perf top', the ldt_gdt > self-test and a kernel-compile running in a loop again. So none of the patches looked scary to me, but then, neither did earlier versions. It's the testing that worries me most.

Re: [PATCH 00/39 v7] PTI support for x86-32

2018-07-11 Thread Linus Torvalds
On Wed, Jul 11, 2018 at 4:30 AM Joerg Roedel wrote: > > I did the load-testing again with 'perf top', the ldt_gdt > self-test and a kernel-compile running in a loop again. So none of the patches looked scary to me, but then, neither did earlier versions. It's the testing that worries me most.

[PATCH 00/39 v7] PTI support for x86-32

2018-07-11 Thread Joerg Roedel
Hi, here is version 7 of my patches to enable PTI on x86-32. Changes to the previous version are: * Rebased to v4.18-rc4 * Introduced pti_finalize() which is called after mark_readonly() and used to update the kernel mappings in the user page-table after

[PATCH 00/39 v7] PTI support for x86-32

2018-07-11 Thread Joerg Roedel
Hi, here is version 7 of my patches to enable PTI on x86-32. Changes to the previous version are: * Rebased to v4.18-rc4 * Introduced pti_finalize() which is called after mark_readonly() and used to update the kernel mappings in the user page-table after