Re: [PATCH 007 of 8] knfsd: nfsd4: vary maximum delegation limit based on RAM size

2007-06-27 Thread Andrew Morton
On Wed, 27 Jun 2007 22:57:39 -0400 "J. Bruce Fields" <[EMAIL PROTECTED]> wrote: > On Wed, Jun 27, 2007 at 07:36:13PM -0700, Andrew Morton wrote: > > How's this? > > Makes sense to me, thanks. I guess fs/nsfd/nfssvc:nfsd_create_serv() > should be similarly modified? It calculates the size of

Re: [PATCH 007 of 8] knfsd: nfsd4: vary maximum delegation limit based on RAM size

2007-06-27 Thread J. Bruce Fields
On Wed, Jun 27, 2007 at 07:36:13PM -0700, Andrew Morton wrote: > How's this? Makes sense to me, thanks. I guess fs/nsfd/nfssvc:nfsd_create_serv() should be similarly modified? It calculates the size of per-nfsd-thread buffers used to hold requests, which will eventually be allocated with an

Re: [PATCH 007 of 8] knfsd: nfsd4: vary maximum delegation limit based on RAM size

2007-06-27 Thread Andrew Morton
On Wed, 27 Jun 2007 22:15:52 -0400 "J. Bruce Fields" <[EMAIL PROTECTED]> wrote: > + /* > + * Allow at most 4 delegations per megabyte of RAM. Quick > + * estimates suggest that in the worst case (where every delegation > + * is for a different inode), a delegation could take

Re: [PATCH 007 of 8] knfsd: nfsd4: vary maximum delegation limit based on RAM size

2007-06-27 Thread J. Bruce Fields
This code would benefit from a little more explanation. Also, I screwed up the previous patch and forgot to delete a line, so the calculation here is off; fix it. Signed-off-by: J. Bruce Fields <[EMAIL PROTECTED]> --- fs/nfsd/nfs4state.c | 16 +++- 1 files changed, 15

Re: [PATCH 007 of 8] knfsd: nfsd4: vary maximum delegation limit based on RAM size

2007-06-27 Thread J. Bruce Fields
This code would benefit from a little more explanation. Also, I screwed up the previous patch and forgot to delete a line, so the calculation here is off; fix it. Signed-off-by: J. Bruce Fields [EMAIL PROTECTED] --- fs/nfsd/nfs4state.c | 16 +++- 1 files changed, 15

Re: [PATCH 007 of 8] knfsd: nfsd4: vary maximum delegation limit based on RAM size

2007-06-27 Thread Andrew Morton
On Wed, 27 Jun 2007 22:15:52 -0400 J. Bruce Fields [EMAIL PROTECTED] wrote: + /* + * Allow at most 4 delegations per megabyte of RAM. Quick + * estimates suggest that in the worst case (where every delegation + * is for a different inode), a delegation could take about

Re: [PATCH 007 of 8] knfsd: nfsd4: vary maximum delegation limit based on RAM size

2007-06-27 Thread J. Bruce Fields
On Wed, Jun 27, 2007 at 07:36:13PM -0700, Andrew Morton wrote: How's this? Makes sense to me, thanks. I guess fs/nsfd/nfssvc:nfsd_create_serv() should be similarly modified? It calculates the size of per-nfsd-thread buffers used to hold requests, which will eventually be allocated with an

Re: [PATCH 007 of 8] knfsd: nfsd4: vary maximum delegation limit based on RAM size

2007-06-27 Thread Andrew Morton
On Wed, 27 Jun 2007 22:57:39 -0400 J. Bruce Fields [EMAIL PROTECTED] wrote: On Wed, Jun 27, 2007 at 07:36:13PM -0700, Andrew Morton wrote: How's this? Makes sense to me, thanks. I guess fs/nsfd/nfssvc:nfsd_create_serv() should be similarly modified? It calculates the size of

Re: [PATCH 007 of 8] knfsd: nfsd4: vary maximum delegation limit based on RAM size

2007-06-25 Thread Andrew Morton
On Thu, 21 Jun 2007 14:31:12 +1000 NeilBrown <[EMAIL PROTECTED]> wrote: > > From: "J. Bruce Fields" <[EMAIL PROTECTED]> > > > Our original NFSv4 delegation policy was to give out a read delegation > on any open when it was possible to. > > Since the lifetime of a delegation isn't limited to

Re: [PATCH 007 of 8] knfsd: nfsd4: vary maximum delegation limit based on RAM size

2007-06-25 Thread Andrew Morton
On Thu, 21 Jun 2007 14:31:12 +1000 NeilBrown [EMAIL PROTECTED] wrote: From: J. Bruce Fields [EMAIL PROTECTED] Our original NFSv4 delegation policy was to give out a read delegation on any open when it was possible to. Since the lifetime of a delegation isn't limited to that of an

Re: [PATCH 007 of 8] knfsd: nfsd4: vary maximum delegation limit based on RAM size

2007-06-21 Thread J. Bruce Fields
I missed a compile warning here, apologies. --b. diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index c79f742..fbbbcab 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c @@ -3204,7 +3204,7 @@ get_nfs4_grace_period(void) } static void -set_max_delegations()

Re: [PATCH 007 of 8] knfsd: nfsd4: vary maximum delegation limit based on RAM size

2007-06-21 Thread J. Bruce Fields
I missed a compile warning here, apologies. --b. diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index c79f742..fbbbcab 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c @@ -3204,7 +3204,7 @@ get_nfs4_grace_period(void) } static void -set_max_delegations()

[PATCH 007 of 8] knfsd: nfsd4: vary maximum delegation limit based on RAM size

2007-06-20 Thread NeilBrown
From: "J. Bruce Fields" <[EMAIL PROTECTED]> Our original NFSv4 delegation policy was to give out a read delegation on any open when it was possible to. Since the lifetime of a delegation isn't limited to that of an open, a client may quite reasonably hang on to a delegation as long as it has

[PATCH 007 of 8] knfsd: nfsd4: vary maximum delegation limit based on RAM size

2007-06-20 Thread NeilBrown
From: J. Bruce Fields [EMAIL PROTECTED] Our original NFSv4 delegation policy was to give out a read delegation on any open when it was possible to. Since the lifetime of a delegation isn't limited to that of an open, a client may quite reasonably hang on to a delegation as long as it has the