Re: [PATCH 01/10] zsmalloc: fix init_zspage free obj linking

2014-09-14 Thread Minchan Kim
On Fri, Sep 12, 2014 at 12:43:22PM -0400, Dan Streetman wrote: > On Fri, Sep 12, 2014 at 12:59 AM, Minchan Kim wrote: > > On Thu, Sep 11, 2014 at 04:53:52PM -0400, Dan Streetman wrote: > >> When zsmalloc creates a new zspage, it initializes each object it contains > >> with a link to the next

Re: [PATCH 01/10] zsmalloc: fix init_zspage free obj linking

2014-09-14 Thread Minchan Kim
On Fri, Sep 12, 2014 at 12:43:22PM -0400, Dan Streetman wrote: On Fri, Sep 12, 2014 at 12:59 AM, Minchan Kim minc...@kernel.org wrote: On Thu, Sep 11, 2014 at 04:53:52PM -0400, Dan Streetman wrote: When zsmalloc creates a new zspage, it initializes each object it contains with a link to the

Re: [PATCH 01/10] zsmalloc: fix init_zspage free obj linking

2014-09-12 Thread Dan Streetman
On Fri, Sep 12, 2014 at 12:59 AM, Minchan Kim wrote: > On Thu, Sep 11, 2014 at 04:53:52PM -0400, Dan Streetman wrote: >> When zsmalloc creates a new zspage, it initializes each object it contains >> with a link to the next object, so that the zspage has a singly-linked list >> of its free

Re: [PATCH 01/10] zsmalloc: fix init_zspage free obj linking

2014-09-12 Thread Dan Streetman
On Fri, Sep 12, 2014 at 12:59 AM, Minchan Kim minc...@kernel.org wrote: On Thu, Sep 11, 2014 at 04:53:52PM -0400, Dan Streetman wrote: When zsmalloc creates a new zspage, it initializes each object it contains with a link to the next object, so that the zspage has a singly-linked list of its

Re: [PATCH 01/10] zsmalloc: fix init_zspage free obj linking

2014-09-11 Thread Minchan Kim
On Thu, Sep 11, 2014 at 04:53:52PM -0400, Dan Streetman wrote: > When zsmalloc creates a new zspage, it initializes each object it contains > with a link to the next object, so that the zspage has a singly-linked list > of its free objects. However, the logic that sets up the links is wrong, >

Re: [PATCH 01/10] zsmalloc: fix init_zspage free obj linking

2014-09-11 Thread Seth Jennings
On Thu, Sep 11, 2014 at 04:53:52PM -0400, Dan Streetman wrote: > When zsmalloc creates a new zspage, it initializes each object it contains > with a link to the next object, so that the zspage has a singly-linked list > of its free objects. However, the logic that sets up the links is wrong, >

[PATCH 01/10] zsmalloc: fix init_zspage free obj linking

2014-09-11 Thread Dan Streetman
When zsmalloc creates a new zspage, it initializes each object it contains with a link to the next object, so that the zspage has a singly-linked list of its free objects. However, the logic that sets up the links is wrong, and in the case of objects that are precisely aligned with the page

Re: [PATCH 01/10] zsmalloc: fix init_zspage free obj linking

2014-09-11 Thread Seth Jennings
On Thu, Sep 11, 2014 at 04:53:52PM -0400, Dan Streetman wrote: When zsmalloc creates a new zspage, it initializes each object it contains with a link to the next object, so that the zspage has a singly-linked list of its free objects. However, the logic that sets up the links is wrong, and in

Re: [PATCH 01/10] zsmalloc: fix init_zspage free obj linking

2014-09-11 Thread Minchan Kim
On Thu, Sep 11, 2014 at 04:53:52PM -0400, Dan Streetman wrote: When zsmalloc creates a new zspage, it initializes each object it contains with a link to the next object, so that the zspage has a singly-linked list of its free objects. However, the logic that sets up the links is wrong, and in

[PATCH 01/10] zsmalloc: fix init_zspage free obj linking

2014-09-11 Thread Dan Streetman
When zsmalloc creates a new zspage, it initializes each object it contains with a link to the next object, so that the zspage has a singly-linked list of its free objects. However, the logic that sets up the links is wrong, and in the case of objects that are precisely aligned with the page