Re: [PATCH 01/10 v3] Input: ep93xx_keypad: Fix platform_get_irq's error checking

2017-11-20 Thread arvindY
Hi Dmitry, On Sunday 19 November 2017 12:00 AM, Dmitry Torokhov wrote: On Sat, Nov 18, 2017 at 04:25:08PM +0530, Arvind Yadav wrote: The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not

Re: [PATCH 01/10 v3] Input: ep93xx_keypad: Fix platform_get_irq's error checking

2017-11-20 Thread arvindY
Hi Dmitry, On Sunday 19 November 2017 12:00 AM, Dmitry Torokhov wrote: On Sat, Nov 18, 2017 at 04:25:08PM +0530, Arvind Yadav wrote: The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not

Re: [PATCH 01/10 v3] Input: ep93xx_keypad: Fix platform_get_irq's error checking

2017-11-18 Thread Dmitry Torokhov
On Sat, Nov 18, 2017 at 04:25:08PM +0530, Arvind Yadav wrote: > The platform_get_irq() function returns negative if an error occurs. > zero or positive number on success. platform_get_irq() error checking > for zero is not correct. > > Signed-off-by: Arvind Yadav > ---

Re: [PATCH 01/10 v3] Input: ep93xx_keypad: Fix platform_get_irq's error checking

2017-11-18 Thread Dmitry Torokhov
On Sat, Nov 18, 2017 at 04:25:08PM +0530, Arvind Yadav wrote: > The platform_get_irq() function returns negative if an error occurs. > zero or positive number on success. platform_get_irq() error checking > for zero is not correct. > > Signed-off-by: Arvind Yadav > --- > changes in v2: >

[PATCH 01/10 v3] Input: ep93xx_keypad: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav
The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- changes in v2: Return keypad->irq insted of -ENXIO.

[PATCH 01/10 v3] Input: ep93xx_keypad: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav
The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- changes in v2: Return keypad->irq insted of -ENXIO. changes in v3 :