Re: [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style

2014-09-02 Thread Dan Carpenter
On Tue, Sep 02, 2014 at 07:22:12AM -0400, An Tuan Ha wrote: > I see, thanks, I will fix it, I was just worried about the subjects > being too long so I just stuck with the same subject; is there a > character limit on how long the subject line should be? Or as long as > it's reasonable, it'll be

Re: [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style

2014-09-02 Thread An Tuan Ha
I see, thanks, I will fix it, I was just worried about the subjects being too long so I just stuck with the same subject; is there a character limit on how long the subject line should be? Or as long as it's reasonable, it'll be fine? On Tue, Sep 02, 2014 at 12:19:40PM +0300, Dan Carpenter wrote:

Re: [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style

2014-09-02 Thread Dan Carpenter
Hm... Now you've broken it into *too* many separate patches. Also the subjects are the same. Also the subjects are too vague. Which coding style issue is addressed? It should be something like: patch 1: comments patch 2: add/remove spaces patch 3: fix quoted text patch 4: braces patch 5: add

Re: [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style

2014-09-02 Thread Dan Carpenter
Hm... Now you've broken it into *too* many separate patches. Also the subjects are the same. Also the subjects are too vague. Which coding style issue is addressed? It should be something like: patch 1: comments patch 2: add/remove spaces patch 3: fix quoted text patch 4: braces patch 5: add

Re: [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style

2014-09-02 Thread An Tuan Ha
I see, thanks, I will fix it, I was just worried about the subjects being too long so I just stuck with the same subject; is there a character limit on how long the subject line should be? Or as long as it's reasonable, it'll be fine? On Tue, Sep 02, 2014 at 12:19:40PM +0300, Dan Carpenter wrote:

Re: [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style

2014-09-02 Thread Dan Carpenter
On Tue, Sep 02, 2014 at 07:22:12AM -0400, An Tuan Ha wrote: I see, thanks, I will fix it, I was just worried about the subjects being too long so I just stuck with the same subject; is there a character limit on how long the subject line should be? Or as long as it's reasonable, it'll be fine?

[PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style

2014-09-01 Thread An Ha
Fix commenting style from C99 comments to C89 comments Signed-off-by: An Ha --- drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c

[PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style

2014-09-01 Thread An Ha
Fix commenting style from C99 comments to C89 comments Signed-off-by: An Ha zero579...@gmail.com --- drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c