Re: [PATCH 01/12] workqueue: add WORKER_RESCUER

2012-09-28 Thread Lai Jiangshan
On 09/27/2012 02:07 AM, Tejun Heo wrote: > On Thu, Sep 27, 2012 at 01:20:32AM +0800, Lai Jiangshan wrote: >> rescuer thread must be a worker which is WORKER_NOT_RUNNING: >> If it is *not* WORKER_NOT_RUNNING, it will increase the nr_running >> and it disables the normal workers wrongly.

Re: [PATCH 01/12] workqueue: add WORKER_RESCUER

2012-09-28 Thread Lai Jiangshan
On 09/27/2012 02:07 AM, Tejun Heo wrote: On Thu, Sep 27, 2012 at 01:20:32AM +0800, Lai Jiangshan wrote: rescuer thread must be a worker which is WORKER_NOT_RUNNING: If it is *not* WORKER_NOT_RUNNING, it will increase the nr_running and it disables the normal workers wrongly. So

Re: [PATCH 01/12] workqueue: add WORKER_RESCUER

2012-09-26 Thread Tejun Heo
On Thu, Sep 27, 2012 at 01:20:32AM +0800, Lai Jiangshan wrote: > rescuer thread must be a worker which is WORKER_NOT_RUNNING: > If it is *not* WORKER_NOT_RUNNING, it will increase the nr_running > and it disables the normal workers wrongly. > > So rescuer thread must be

[PATCH 01/12] workqueue: add WORKER_RESCUER

2012-09-26 Thread Lai Jiangshan
rescuer thread must be a worker which is WORKER_NOT_RUNNING: If it is *not* WORKER_NOT_RUNNING, it will increase the nr_running and it disables the normal workers wrongly. So rescuer thread must be WORKER_NOT_RUNNING. Currently code implement it by always setting WORKER_PREP on

[PATCH 01/12] workqueue: add WORKER_RESCUER

2012-09-26 Thread Lai Jiangshan
rescuer thread must be a worker which is WORKER_NOT_RUNNING: If it is *not* WORKER_NOT_RUNNING, it will increase the nr_running and it disables the normal workers wrongly. So rescuer thread must be WORKER_NOT_RUNNING. Currently code implement it by always setting WORKER_PREP on

Re: [PATCH 01/12] workqueue: add WORKER_RESCUER

2012-09-26 Thread Tejun Heo
On Thu, Sep 27, 2012 at 01:20:32AM +0800, Lai Jiangshan wrote: rescuer thread must be a worker which is WORKER_NOT_RUNNING: If it is *not* WORKER_NOT_RUNNING, it will increase the nr_running and it disables the normal workers wrongly. So rescuer thread must be WORKER_NOT_RUNNING.