Re: [PATCH 01/17] locking/lockdep: Add lock type enum to explicitly specify read or write locks

On Tue, May 14, 2019 at 09:31:48AM +0800, Yuyang Du wrote: > Thanks for review. > > On Mon, 13 May 2019 at 19:45, Peter Zijlstra wrote: > > > > On Mon, May 13, 2019 at 05:11:47PM +0800, Yuyang Du wrote: > > > + * Note that we have an assumption that a lock class cannot ever be both > > > + *

Re: [PATCH 01/17] locking/lockdep: Add lock type enum to explicitly specify read or write locks

Thanks for review. On Mon, 13 May 2019 at 19:45, Peter Zijlstra wrote: > > On Mon, May 13, 2019 at 05:11:47PM +0800, Yuyang Du wrote: > > + * Note that we have an assumption that a lock class cannot ever be both > > + * read and recursive-read. > > We have such locks in the kernel... see: > >

Re: [PATCH 01/17] locking/lockdep: Add lock type enum to explicitly specify read or write locks

On Mon, May 13, 2019 at 05:11:47PM +0800, Yuyang Du wrote: > + * Note that we have an assumption that a lock class cannot ever be both > + * read and recursive-read. We have such locks in the kernel... see: kernel/qrwlock.c:queued_read_lock_slowpath() And yes, that is somewhat unfortunate,

[PATCH 01/17] locking/lockdep: Add lock type enum to explicitly specify read or write locks

Add an enum to formalize lock types, as those type values now matter. No functional change. Signed-off-by: Yuyang Du --- include/linux/lockdep.h | 28 ++-- kernel/locking/lockdep.c | 23 +-- 2 files changed, 35 insertions(+), 16 deletions(-) diff