Re: [PATCH 01/18] sched: select_task_rq_fair clean up

2012-12-23 Thread Alex Shi
On Fri, Dec 21, 2012 at 12:28 PM, Namhyung Kim wrote: > Hi, > > On Tue, 11 Dec 2012 12:00:55 +0530, Preeti U. Murthy wrote: >> On 12/11/2012 10:58 AM, Alex Shi wrote: >>> On 12/11/2012 12:23 PM, Preeti U Murthy wrote: Hi Alex, On 12/10/2012 01:52 PM, Alex Shi wrote: > It is

Re: [PATCH 01/18] sched: select_task_rq_fair clean up

2012-12-23 Thread Alex Shi
On Fri, Dec 21, 2012 at 12:28 PM, Namhyung Kim namhy...@kernel.org wrote: Hi, On Tue, 11 Dec 2012 12:00:55 +0530, Preeti U. Murthy wrote: On 12/11/2012 10:58 AM, Alex Shi wrote: On 12/11/2012 12:23 PM, Preeti U Murthy wrote: Hi Alex, On 12/10/2012 01:52 PM, Alex Shi wrote: It is

Re: [PATCH 01/18] sched: select_task_rq_fair clean up

2012-12-20 Thread Namhyung Kim
Hi, On Tue, 11 Dec 2012 12:00:55 +0530, Preeti U. Murthy wrote: > On 12/11/2012 10:58 AM, Alex Shi wrote: >> On 12/11/2012 12:23 PM, Preeti U Murthy wrote: >>> Hi Alex, >>> >>> On 12/10/2012 01:52 PM, Alex Shi wrote: It is impossible to miss a task allowed cpu in a eligible group. >>> >>>

Re: [PATCH 01/18] sched: select_task_rq_fair clean up

2012-12-20 Thread Namhyung Kim
Hi, On Tue, 11 Dec 2012 12:00:55 +0530, Preeti U. Murthy wrote: On 12/11/2012 10:58 AM, Alex Shi wrote: On 12/11/2012 12:23 PM, Preeti U Murthy wrote: Hi Alex, On 12/10/2012 01:52 PM, Alex Shi wrote: It is impossible to miss a task allowed cpu in a eligible group. The one thing I am

Re: [PATCH 01/18] sched: select_task_rq_fair clean up

2012-12-11 Thread Preeti U Murthy
On 12/11/2012 05:23 PM, Alex Shi wrote: > On 12/11/2012 02:30 PM, Preeti U Murthy wrote: >> On 12/11/2012 10:58 AM, Alex Shi wrote: >>> On 12/11/2012 12:23 PM, Preeti U Murthy wrote: Hi Alex, On 12/10/2012 01:52 PM, Alex Shi wrote: > It is impossible to miss a task allowed cpu

Re: [PATCH 01/18] sched: select_task_rq_fair clean up

2012-12-11 Thread Alex Shi
On 12/11/2012 02:30 PM, Preeti U Murthy wrote: > On 12/11/2012 10:58 AM, Alex Shi wrote: >> On 12/11/2012 12:23 PM, Preeti U Murthy wrote: >>> Hi Alex, >>> >>> On 12/10/2012 01:52 PM, Alex Shi wrote: It is impossible to miss a task allowed cpu in a eligible group. >>> >>> The one thing I am

Re: [PATCH 01/18] sched: select_task_rq_fair clean up

2012-12-11 Thread Alex Shi
On 12/11/2012 02:30 PM, Preeti U Murthy wrote: On 12/11/2012 10:58 AM, Alex Shi wrote: On 12/11/2012 12:23 PM, Preeti U Murthy wrote: Hi Alex, On 12/10/2012 01:52 PM, Alex Shi wrote: It is impossible to miss a task allowed cpu in a eligible group. The one thing I am concerned with here is

Re: [PATCH 01/18] sched: select_task_rq_fair clean up

2012-12-11 Thread Preeti U Murthy
On 12/11/2012 05:23 PM, Alex Shi wrote: On 12/11/2012 02:30 PM, Preeti U Murthy wrote: On 12/11/2012 10:58 AM, Alex Shi wrote: On 12/11/2012 12:23 PM, Preeti U Murthy wrote: Hi Alex, On 12/10/2012 01:52 PM, Alex Shi wrote: It is impossible to miss a task allowed cpu in a eligible group.

Re: [PATCH 01/18] sched: select_task_rq_fair clean up

2012-12-10 Thread Preeti U Murthy
On 12/11/2012 10:58 AM, Alex Shi wrote: > On 12/11/2012 12:23 PM, Preeti U Murthy wrote: >> Hi Alex, >> >> On 12/10/2012 01:52 PM, Alex Shi wrote: >>> It is impossible to miss a task allowed cpu in a eligible group. >> >> The one thing I am concerned with here is if there is a possibility of >>

Re: [PATCH 01/18] sched: select_task_rq_fair clean up

2012-12-10 Thread Alex Shi
On 12/11/2012 12:23 PM, Preeti U Murthy wrote: > Hi Alex, > > On 12/10/2012 01:52 PM, Alex Shi wrote: >> It is impossible to miss a task allowed cpu in a eligible group. > > The one thing I am concerned with here is if there is a possibility of > the task changing its tsk_cpus_allowed() while

Re: [PATCH 01/18] sched: select_task_rq_fair clean up

2012-12-10 Thread Preeti U Murthy
Hi Alex, On 12/10/2012 01:52 PM, Alex Shi wrote: > It is impossible to miss a task allowed cpu in a eligible group. The one thing I am concerned with here is if there is a possibility of the task changing its tsk_cpus_allowed() while this code is running. i.e find_idlest_group() finds an idle

[PATCH 01/18] sched: select_task_rq_fair clean up

2012-12-10 Thread Alex Shi
It is impossible to miss a task allowed cpu in a eligible group. And since find_idlest_group only return a different group which excludes old cpu, it's also imporissible to find a new cpu same as old cpu. Signed-off-by: Alex Shi --- kernel/sched/fair.c |5 - 1 files changed, 0

[PATCH 01/18] sched: select_task_rq_fair clean up

2012-12-10 Thread Alex Shi
It is impossible to miss a task allowed cpu in a eligible group. And since find_idlest_group only return a different group which excludes old cpu, it's also imporissible to find a new cpu same as old cpu. Signed-off-by: Alex Shi alex@intel.com --- kernel/sched/fair.c |5 - 1 files

Re: [PATCH 01/18] sched: select_task_rq_fair clean up

2012-12-10 Thread Preeti U Murthy
Hi Alex, On 12/10/2012 01:52 PM, Alex Shi wrote: It is impossible to miss a task allowed cpu in a eligible group. The one thing I am concerned with here is if there is a possibility of the task changing its tsk_cpus_allowed() while this code is running. i.e find_idlest_group() finds an idle

Re: [PATCH 01/18] sched: select_task_rq_fair clean up

2012-12-10 Thread Alex Shi
On 12/11/2012 12:23 PM, Preeti U Murthy wrote: Hi Alex, On 12/10/2012 01:52 PM, Alex Shi wrote: It is impossible to miss a task allowed cpu in a eligible group. The one thing I am concerned with here is if there is a possibility of the task changing its tsk_cpus_allowed() while this code

Re: [PATCH 01/18] sched: select_task_rq_fair clean up

2012-12-10 Thread Preeti U Murthy
On 12/11/2012 10:58 AM, Alex Shi wrote: On 12/11/2012 12:23 PM, Preeti U Murthy wrote: Hi Alex, On 12/10/2012 01:52 PM, Alex Shi wrote: It is impossible to miss a task allowed cpu in a eligible group. The one thing I am concerned with here is if there is a possibility of the task changing