Re: [PATCH 01/19] dax: remove block device dependencies

2019-08-29 Thread Christoph Hellwig
On Wed, Aug 28, 2019 at 05:04:11PM -0700, Dan Williams wrote: > Agree. In retrospect it was my laziness in the dax-device > implementation to expect the block-device to be available. > > It looks like fs_dax_get_by_bdev() is an intercept point where a > dax_device could be dynamically created to

Re: [PATCH 01/19] dax: remove block device dependencies

2019-08-28 Thread Dan Williams
On Wed, Aug 28, 2019 at 3:53 PM Dave Chinner wrote: > > On Wed, Aug 28, 2019 at 01:58:43PM -0400, Vivek Goyal wrote: > > On Tue, Aug 27, 2019 at 11:58:09PM -0700, Christoph Hellwig wrote: > > > On Tue, Aug 27, 2019 at 12:38:28PM -0400, Vivek Goyal wrote: > > > > > For bdev_dax_pgoff > > > > > I'd

Re: [PATCH 01/19] dax: remove block device dependencies

2019-08-28 Thread Dave Chinner
On Wed, Aug 28, 2019 at 01:58:43PM -0400, Vivek Goyal wrote: > On Tue, Aug 27, 2019 at 11:58:09PM -0700, Christoph Hellwig wrote: > > On Tue, Aug 27, 2019 at 12:38:28PM -0400, Vivek Goyal wrote: > > > > For bdev_dax_pgoff > > > > I'd much rather have the partition offset if there is on in the

Re: [PATCH 01/19] dax: remove block device dependencies

2019-08-28 Thread Vivek Goyal
On Tue, Aug 27, 2019 at 11:58:09PM -0700, Christoph Hellwig wrote: > On Tue, Aug 27, 2019 at 12:38:28PM -0400, Vivek Goyal wrote: > > > For bdev_dax_pgoff > > > I'd much rather have the partition offset if there is on in the daxdev > > > somehow so that we can get rid of the block device entirely.

Re: [PATCH 01/19] dax: remove block device dependencies

2019-08-28 Thread Christoph Hellwig
On Tue, Aug 27, 2019 at 12:38:28PM -0400, Vivek Goyal wrote: > > For bdev_dax_pgoff > > I'd much rather have the partition offset if there is on in the daxdev > > somehow so that we can get rid of the block device entirely. > > IIUC, there is one block_device per partition while there is only one

Re: [PATCH 01/19] dax: remove block device dependencies

2019-08-27 Thread Vivek Goyal
On Mon, Aug 26, 2019 at 04:51:52AM -0700, Christoph Hellwig wrote: > On Wed, Aug 21, 2019 at 01:57:02PM -0400, Vivek Goyal wrote: > > From: Stefan Hajnoczi > > > > Although struct dax_device itself is not tied to a block device, some > > DAX code assumes there is a block device. Make block

Re: [PATCH 01/19] dax: remove block device dependencies

2019-08-26 Thread Christoph Hellwig
On Wed, Aug 21, 2019 at 01:57:02PM -0400, Vivek Goyal wrote: > From: Stefan Hajnoczi > > Although struct dax_device itself is not tied to a block device, some > DAX code assumes there is a block device. Make block devices optional > by allowing bdev to be NULL in commonly used DAX APIs. > >

[PATCH 01/19] dax: remove block device dependencies

2019-08-21 Thread Vivek Goyal
From: Stefan Hajnoczi Although struct dax_device itself is not tied to a block device, some DAX code assumes there is a block device. Make block devices optional by allowing bdev to be NULL in commonly used DAX APIs. When there is no block device: * Skip the partition offset calculation in