Re: [PATCH 01/29] fscrypt: Add in-place encryption mode

2016-11-26 Thread Eric Biggers
On Fri, Nov 25, 2016 at 01:09:05PM +0100, David Gstir wrote: > > > Additionally, after this change the name of the flag FS_WRITE_PATH_FL is > > misleading, since it now really indicates the presence of a bounce buffer > > rather > > than the "write path". > > I can see no use case for

Re: [PATCH 01/29] fscrypt: Add in-place encryption mode

2016-11-26 Thread Eric Biggers
On Fri, Nov 25, 2016 at 01:09:05PM +0100, David Gstir wrote: > > > Additionally, after this change the name of the flag FS_WRITE_PATH_FL is > > misleading, since it now really indicates the presence of a bounce buffer > > rather > > than the "write path". > > I can see no use case for

Re: [PATCH 01/29] fscrypt: Add in-place encryption mode

2016-11-25 Thread David Gstir
Eric, > On 15.11.2016, at 19:14, Eric Biggers wrote: > > Hi, > > On Sun, Nov 13, 2016 at 10:20:44PM +0100, Richard Weinberger wrote: >> From: David Gstir >> >> ext4 and f2fs require a bounce page when encrypting pages. However, not >> all filesystems

Re: [PATCH 01/29] fscrypt: Add in-place encryption mode

2016-11-25 Thread David Gstir
Eric, > On 15.11.2016, at 19:14, Eric Biggers wrote: > > Hi, > > On Sun, Nov 13, 2016 at 10:20:44PM +0100, Richard Weinberger wrote: >> From: David Gstir >> >> ext4 and f2fs require a bounce page when encrypting pages. However, not >> all filesystems will need that (eg. UBIFS). This is

Re: [PATCH 01/29] fscrypt: Add in-place encryption mode

2016-11-15 Thread Eric Biggers
Hi, On Sun, Nov 13, 2016 at 10:20:44PM +0100, Richard Weinberger wrote: > From: David Gstir > > ext4 and f2fs require a bounce page when encrypting pages. However, not > all filesystems will need that (eg. UBIFS). This is handled via a > flag on fscrypt_operations where a

Re: [PATCH 01/29] fscrypt: Add in-place encryption mode

2016-11-15 Thread Eric Biggers
Hi, On Sun, Nov 13, 2016 at 10:20:44PM +0100, Richard Weinberger wrote: > From: David Gstir > > ext4 and f2fs require a bounce page when encrypting pages. However, not > all filesystems will need that (eg. UBIFS). This is handled via a > flag on fscrypt_operations where a fs implementation can

[PATCH 01/29] fscrypt: Add in-place encryption mode

2016-11-13 Thread Richard Weinberger
From: David Gstir ext4 and f2fs require a bounce page when encrypting pages. However, not all filesystems will need that (eg. UBIFS). This is handled via a flag on fscrypt_operations where a fs implementation can select in-place encryption over using a bounce page (which is

[PATCH 01/29] fscrypt: Add in-place encryption mode

2016-11-13 Thread Richard Weinberger
From: David Gstir ext4 and f2fs require a bounce page when encrypting pages. However, not all filesystems will need that (eg. UBIFS). This is handled via a flag on fscrypt_operations where a fs implementation can select in-place encryption over using a bounce page (which is the default).