Roland Dreier wrote:
> > > +static inline void *ERR_CAST(const void *ptr)
> > > +{
> > > +return (void *) ptr;
> > > +}
> >
> > Just to nit, surely you don't need the cast inside the function. The
> > casting happens at the call site between the argument and returned pointer.
>
>
On Thu, 25 Oct 2007 16:09:09 -0700
Zach Brown <[EMAIL PROTECTED]> wrote:
>
> > + * ERR_CAST - Explicitly cast an error-valued pointer to another pointer
> > type
> > + * @ptr: The pointer to cast.
> > + *
> > + * Explicitly cast an error-valued pointer to another pointer type in such
> > a
> >
> > +static inline void *ERR_CAST(const void *ptr)
> > +{
> > + return (void *) ptr;
> > +}
>
> Just to nit, surely you don't need the cast inside the function. The
> casting happens at the call site between the argument and returned pointer.
The way it's written you kinda do, since it
> + * ERR_CAST - Explicitly cast an error-valued pointer to another pointer type
> + * @ptr: The pointer to cast.
> + *
> + * Explicitly cast an error-valued pointer to another pointer type in such a
> + * way as to make it clear that's what's going on.
> + */
> +static inline void
Add an ERR_CAST() macro to complement ERR_PTR and co. for the purposes of
casting an error entyped as one pointer type to an error of another pointer
type whilst making it explicit as to what is going on.
This provides a replacement for the ERR_PTR(PTR_ERR(p)) construct.
Signed-off-by: David
Add an ERR_CAST() macro to complement ERR_PTR and co. for the purposes of
casting an error entyped as one pointer type to an error of another pointer
type whilst making it explicit as to what is going on.
This provides a replacement for the ERR_PTR(PTR_ERR(p)) construct.
Signed-off-by: David
+ * ERR_CAST - Explicitly cast an error-valued pointer to another pointer type
+ * @ptr: The pointer to cast.
+ *
+ * Explicitly cast an error-valued pointer to another pointer type in such a
+ * way as to make it clear that's what's going on.
+ */
+static inline void *ERR_CAST(const void
+static inline void *ERR_CAST(const void *ptr)
+{
+ return (void *) ptr;
+}
Just to nit, surely you don't need the cast inside the function. The
casting happens at the call site between the argument and returned pointer.
The way it's written you kinda do, since it takes a
On Thu, 25 Oct 2007 16:09:09 -0700
Zach Brown [EMAIL PROTECTED] wrote:
+ * ERR_CAST - Explicitly cast an error-valued pointer to another pointer
type
+ * @ptr: The pointer to cast.
+ *
+ * Explicitly cast an error-valued pointer to another pointer type in such
a
+ * way as to
Roland Dreier wrote:
+static inline void *ERR_CAST(const void *ptr)
+{
+return (void *) ptr;
+}
Just to nit, surely you don't need the cast inside the function. The
casting happens at the call site between the argument and returned pointer.
The way it's
10 matches
Mail list logo
