RE: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-13 Thread KY Srinivasan
; jasow...@redhat.com > Subject: Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in > interrupt context > > On Fri, Oct 09, Olaf Hering wrote: > > > On Thu, Oct 08, KY Srinivasan wrote: > > > > > > yes, but after doing fcopy_respond_to_host().

Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-13 Thread Olaf Hering
On Fri, Oct 09, Olaf Hering wrote: > On Thu, Oct 08, KY Srinivasan wrote: > > > > yes, but after doing fcopy_respond_to_host(). I'd suggest we leave the > > > check in place, better safe than sorry. > > > > Agreed; Olaf, if it is ok with you, I can fix it up and send. > > I will retest with

Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-13 Thread Olaf Hering
On Fri, Oct 09, Olaf Hering wrote: > On Thu, Oct 08, KY Srinivasan wrote: > > > > yes, but after doing fcopy_respond_to_host(). I'd suggest we leave the > > > check in place, better safe than sorry. > > > > Agreed; Olaf, if it is ok with you, I can fix it up and send. > > I will retest with

RE: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-13 Thread KY Srinivasan
; de...@linuxdriverproject.org; > a...@canonical.com; jasow...@redhat.com > Subject: Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in > interrupt context > > On Fri, Oct 09, Olaf Hering wrote: > > > On Thu, Oct 08, KY Srinivasan wrote: > > > > >

RE: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-12 Thread KY Srinivasan
; jasow...@redhat.com > Subject: Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in > interrupt context > > On Fri, Oct 09, Vitaly Kuznetsov wrote: > > > Olaf Hering writes: > > > > > On Thu, Oct 08, KY Srinivasan wrote: > > > > >

RE: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-12 Thread KY Srinivasan
; de...@linuxdriverproject.org; a...@canonical.com; > jasow...@redhat.com > Subject: Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in > interrupt context > > On Fri, Oct 09, Vitaly Kuznetsov wrote: > > > Olaf Hering <o...@aepfle.de> writes: >

Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-09 Thread Olaf Hering
On Fri, Oct 09, Vitaly Kuznetsov wrote: > Olaf Hering writes: > > > On Thu, Oct 08, KY Srinivasan wrote: > > > >> > yes, but after doing fcopy_respond_to_host(). I'd suggest we leave the > >> > check in place, better safe than sorry. > >> > >> Agreed; Olaf, if it is ok with you, I can fix it

Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-09 Thread Vitaly Kuznetsov
Olaf Hering writes: > On Thu, Oct 08, KY Srinivasan wrote: > >> > yes, but after doing fcopy_respond_to_host(). I'd suggest we leave the >> > check in place, better safe than sorry. >> >> Agreed; Olaf, if it is ok with you, I can fix it up and send. > > I will retest with this part reverted. I

Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-09 Thread Olaf Hering
On Thu, Oct 08, KY Srinivasan wrote: > > yes, but after doing fcopy_respond_to_host(). I'd suggest we leave the > > check in place, better safe than sorry. > > Agreed; Olaf, if it is ok with you, I can fix it up and send. I will retest with this part reverted. I think without two code paths

Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-09 Thread Vitaly Kuznetsov
Olaf Hering writes: > On Thu, Oct 08, KY Srinivasan wrote: > >> > yes, but after doing fcopy_respond_to_host(). I'd suggest we leave the >> > check in place, better safe than sorry. >> >> Agreed; Olaf, if it is ok with you, I can fix it up and send. > > I will retest with this

Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-09 Thread Olaf Hering
On Thu, Oct 08, KY Srinivasan wrote: > > yes, but after doing fcopy_respond_to_host(). I'd suggest we leave the > > check in place, better safe than sorry. > > Agreed; Olaf, if it is ok with you, I can fix it up and send. I will retest with this part reverted. I think without two code paths

Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-09 Thread Olaf Hering
On Fri, Oct 09, Vitaly Kuznetsov wrote: > Olaf Hering writes: > > > On Thu, Oct 08, KY Srinivasan wrote: > > > >> > yes, but after doing fcopy_respond_to_host(). I'd suggest we leave the > >> > check in place, better safe than sorry. > >> > >> Agreed; Olaf, if it is ok with

RE: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-08 Thread KY Srinivasan
nical.com; > jasow...@redhat.com > Subject: Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in > interrupt context > > Olaf Hering writes: > > > On Thu, Oct 08, Vitaly Kuznetsov wrote: > > > >> > @@ -295,9 +288,6 @@ static int fcopy_on_msg(voi

Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-08 Thread Vitaly Kuznetsov
Olaf Hering writes: > On Thu, Oct 08, Vitaly Kuznetsov wrote: > >> > @@ -295,9 +288,6 @@ static int fcopy_on_msg(void *msg, int len) >> >if (fcopy_transaction.state == HVUTIL_DEVICE_INIT) >> >return fcopy_handle_handshake(*val); >> > >> > - if (fcopy_transaction.state !=

Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-08 Thread Olaf Hering
On Thu, Oct 08, Vitaly Kuznetsov wrote: > > @@ -295,9 +288,6 @@ static int fcopy_on_msg(void *msg, int len) > > if (fcopy_transaction.state == HVUTIL_DEVICE_INIT) > > return fcopy_handle_handshake(*val); > > > > - if (fcopy_transaction.state != HVUTIL_USERSPACE_REQ) > > -

Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-08 Thread Vitaly Kuznetsov
"K. Y. Srinivasan" writes: > From: Olaf Hering > > All channel interrupts are bound to specific VCPUs in the guest > at the point channel is created. While currently, we invoke the > polling function on the correct CPU (the CPU to which the channel > is bound to) in some cases we may run the

Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-08 Thread Vitaly Kuznetsov
"K. Y. Srinivasan" writes: > From: Olaf Hering > > All channel interrupts are bound to specific VCPUs in the guest > at the point channel is created. While currently, we invoke the > polling function on the correct CPU (the CPU to which the channel > is bound

Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-08 Thread Olaf Hering
On Thu, Oct 08, Vitaly Kuznetsov wrote: > > @@ -295,9 +288,6 @@ static int fcopy_on_msg(void *msg, int len) > > if (fcopy_transaction.state == HVUTIL_DEVICE_INIT) > > return fcopy_handle_handshake(*val); > > > > - if (fcopy_transaction.state != HVUTIL_USERSPACE_REQ) > > -

Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-08 Thread Vitaly Kuznetsov
Olaf Hering writes: > On Thu, Oct 08, Vitaly Kuznetsov wrote: > >> > @@ -295,9 +288,6 @@ static int fcopy_on_msg(void *msg, int len) >> >if (fcopy_transaction.state == HVUTIL_DEVICE_INIT) >> >return fcopy_handle_handshake(*val); >> > >> > - if

RE: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-08 Thread KY Srinivasan
; de...@linuxdriverproject.org; a...@canonical.com; > jasow...@redhat.com > Subject: Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in > interrupt context > > Olaf Hering <o...@aepfle.de> writes: > > > On Thu, Oct 08, Vitaly Kuznetsov wrote: > >

[PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-07 Thread K. Y. Srinivasan
From: Olaf Hering All channel interrupts are bound to specific VCPUs in the guest at the point channel is created. While currently, we invoke the polling function on the correct CPU (the CPU to which the channel is bound to) in some cases we may run the polling function in a non-interrupt

[PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-07 Thread K. Y. Srinivasan
From: Olaf Hering All channel interrupts are bound to specific VCPUs in the guest at the point channel is created. While currently, we invoke the polling function on the correct CPU (the CPU to which the channel is bound to) in some cases we may run the polling function in a