Re: [PATCH 02/11] efi: Remove EFI_PAGE_SHIFT and EFI_PAGE_SIZE

2013-09-21 Thread Borislav Petkov
On Sat, Sep 21, 2013 at 06:01:21PM +0200, Leif Lindholm wrote: > Correct. On arm64, EFI_PAGE_SIZE will be 4K, and PAGE_SIZE can be 4K > or 64K, with at least Fedora opting for 64K. Hm, ok, it looks like we want to keep EFI_PAGE_SIZE. Oh well. Thanks. -- Regards/Gruss, Boris. Sent from a

Re: [PATCH 02/11] efi: Remove EFI_PAGE_SHIFT and EFI_PAGE_SIZE

2013-09-21 Thread Leif Lindholm
On Sat, Sep 21, 2013 at 05:50:39PM +0200, Borislav Petkov wrote: > > Ok, maybe the generic header include/linux/efi.h might be a problem but > > the rest are changes to arch/x86/ which should have no effect whatsoever > > on any other arch. > > > > Or are you planning to move some of it into

Re: [PATCH 02/11] efi: Remove EFI_PAGE_SHIFT and EFI_PAGE_SIZE

2013-09-21 Thread Leif Lindholm
On Sat, Sep 21, 2013 at 05:41:43PM +0200, Borislav Petkov wrote: > On Sat, Sep 21, 2013 at 05:21:39PM +0200, Leif Lindholm wrote: > > > It will probably not be a problem on the stub side, and it's not used > > in many places but it would break efi_lookup_mapped_address(), > > efi_range_is_wc()

Re: [PATCH 02/11] efi: Remove EFI_PAGE_SHIFT and EFI_PAGE_SIZE

2013-09-21 Thread Borislav Petkov
On Sat, Sep 21, 2013 at 05:41:43PM +0200, Borislav Petkov wrote: > On Sat, Sep 21, 2013 at 05:21:39PM +0200, Leif Lindholm wrote: > > > It will probably not be a problem on the stub side, and it's not used > > in many places but it would break efi_lookup_mapped_address(), > > efi_range_is_wc()

Re: [PATCH 02/11] efi: Remove EFI_PAGE_SHIFT and EFI_PAGE_SIZE

2013-09-21 Thread Borislav Petkov
On Sat, Sep 21, 2013 at 05:21:39PM +0200, Leif Lindholm wrote: > It will probably not be a problem on the stub side, and it's not used > in many places but it would break efi_lookup_mapped_address(), > efi_range_is_wc() and memrange_efi_to_native() for use by arm64. > At least the first of these

Re: [PATCH 02/11] efi: Remove EFI_PAGE_SHIFT and EFI_PAGE_SIZE

2013-09-21 Thread Leif Lindholm
On Fri, Sep 20, 2013 at 11:42:49AM +0100, Matt Fleming wrote: > On Thu, 19 Sep, at 04:54:45PM, Borislav Petkov wrote: > > From: Borislav Petkov > > > > ... and use the good old standard defines which we all know. Also, > > simplify math to shift by PAGE_SHIFT instead of multiplying by > >

Re: [PATCH 02/11] efi: Remove EFI_PAGE_SHIFT and EFI_PAGE_SIZE

2013-09-21 Thread Leif Lindholm
On Fri, Sep 20, 2013 at 11:42:49AM +0100, Matt Fleming wrote: On Thu, 19 Sep, at 04:54:45PM, Borislav Petkov wrote: From: Borislav Petkov b...@suse.de ... and use the good old standard defines which we all know. Also, simplify math to shift by PAGE_SHIFT instead of multiplying by

Re: [PATCH 02/11] efi: Remove EFI_PAGE_SHIFT and EFI_PAGE_SIZE

2013-09-21 Thread Borislav Petkov
On Sat, Sep 21, 2013 at 05:21:39PM +0200, Leif Lindholm wrote: It will probably not be a problem on the stub side, and it's not used in many places but it would break efi_lookup_mapped_address(), efi_range_is_wc() and memrange_efi_to_native() for use by arm64. At least the first of these

Re: [PATCH 02/11] efi: Remove EFI_PAGE_SHIFT and EFI_PAGE_SIZE

2013-09-21 Thread Borislav Petkov
On Sat, Sep 21, 2013 at 05:41:43PM +0200, Borislav Petkov wrote: On Sat, Sep 21, 2013 at 05:21:39PM +0200, Leif Lindholm wrote: It will probably not be a problem on the stub side, and it's not used in many places but it would break efi_lookup_mapped_address(), efi_range_is_wc() and

Re: [PATCH 02/11] efi: Remove EFI_PAGE_SHIFT and EFI_PAGE_SIZE

2013-09-21 Thread Leif Lindholm
On Sat, Sep 21, 2013 at 05:41:43PM +0200, Borislav Petkov wrote: On Sat, Sep 21, 2013 at 05:21:39PM +0200, Leif Lindholm wrote: It will probably not be a problem on the stub side, and it's not used in many places but it would break efi_lookup_mapped_address(), efi_range_is_wc() and

Re: [PATCH 02/11] efi: Remove EFI_PAGE_SHIFT and EFI_PAGE_SIZE

2013-09-21 Thread Leif Lindholm
On Sat, Sep 21, 2013 at 05:50:39PM +0200, Borislav Petkov wrote: Ok, maybe the generic header include/linux/efi.h might be a problem but the rest are changes to arch/x86/ which should have no effect whatsoever on any other arch. Or are you planning to move some of it into generic code?

Re: [PATCH 02/11] efi: Remove EFI_PAGE_SHIFT and EFI_PAGE_SIZE

2013-09-21 Thread Borislav Petkov
On Sat, Sep 21, 2013 at 06:01:21PM +0200, Leif Lindholm wrote: Correct. On arm64, EFI_PAGE_SIZE will be 4K, and PAGE_SIZE can be 4K or 64K, with at least Fedora opting for 64K. Hm, ok, it looks like we want to keep EFI_PAGE_SIZE. Oh well. Thanks. -- Regards/Gruss, Boris. Sent from a

Re: [PATCH 02/11] efi: Remove EFI_PAGE_SHIFT and EFI_PAGE_SIZE

2013-09-20 Thread Matt Fleming
On Thu, 19 Sep, at 04:54:45PM, Borislav Petkov wrote: > From: Borislav Petkov > > ... and use the good old standard defines which we all know. Also, > simplify math to shift by PAGE_SHIFT instead of multiplying by > PAGE_SIZE. > > Signed-off-by: Borislav Petkov > --- >

Re: [PATCH 02/11] efi: Remove EFI_PAGE_SHIFT and EFI_PAGE_SIZE

2013-09-20 Thread Matt Fleming
On Thu, 19 Sep, at 04:54:45PM, Borislav Petkov wrote: From: Borislav Petkov b...@suse.de ... and use the good old standard defines which we all know. Also, simplify math to shift by PAGE_SHIFT instead of multiplying by PAGE_SIZE. Signed-off-by: Borislav Petkov b...@suse.de ---

[PATCH 02/11] efi: Remove EFI_PAGE_SHIFT and EFI_PAGE_SIZE

2013-09-19 Thread Borislav Petkov
From: Borislav Petkov ... and use the good old standard defines which we all know. Also, simplify math to shift by PAGE_SHIFT instead of multiplying by PAGE_SIZE. Signed-off-by: Borislav Petkov --- arch/x86/boot/compressed/eboot.c | 12 ++-- arch/x86/boot/compressed/eboot.h | 1 -

[PATCH 02/11] efi: Remove EFI_PAGE_SHIFT and EFI_PAGE_SIZE

2013-09-19 Thread Borislav Petkov
From: Borislav Petkov b...@suse.de ... and use the good old standard defines which we all know. Also, simplify math to shift by PAGE_SHIFT instead of multiplying by PAGE_SIZE. Signed-off-by: Borislav Petkov b...@suse.de --- arch/x86/boot/compressed/eboot.c | 12 ++--