Consider this fixed. I have extracted the common function and the new
shmem_insert_page_page_cache function looks like this:
spin_lock_irq(>tree_lock);
error = __add_to_page_cache_locked(page, mapping, index);
if (!error)
__mod_zone_page_state(page_zone(page),
Yes, I guess I can if I just put whatever inside the spin lock into a
common function. Thanks!
Best wishes,
--
Ning Qu (曲宁) | Software Engineer | qun...@google.com | +1-408-418-6066
On Wed, Oct 16, 2013 at 5:26 AM, Kirill A. Shutemov
wrote:
> Ning Qu wrote:
>> Yes, I can try. The code is
Ning Qu wrote:
> Yes, I can try. The code is pretty much similar with some minor difference.
>
> One thing I can do is to move the spin lock part (together with the
> corresponding err handling into a common function.
>
> The only problem I can see right now is we need the following
> additional
Ning Qu wrote:
Yes, I can try. The code is pretty much similar with some minor difference.
One thing I can do is to move the spin lock part (together with the
corresponding err handling into a common function.
The only problem I can see right now is we need the following
additional line
Yes, I guess I can if I just put whatever inside the spin lock into a
common function. Thanks!
Best wishes,
--
Ning Qu (曲宁) | Software Engineer | qun...@google.com | +1-408-418-6066
On Wed, Oct 16, 2013 at 5:26 AM, Kirill A. Shutemov
kirill.shute...@linux.intel.com wrote:
Ning Qu wrote:
Yes,
Consider this fixed. I have extracted the common function and the new
shmem_insert_page_page_cache function looks like this:
spin_lock_irq(mapping-tree_lock);
error = __add_to_page_cache_locked(page, mapping, index);
if (!error)
Yes, I can try. The code is pretty much similar with some minor difference.
One thing I can do is to move the spin lock part (together with the
corresponding err handling into a common function.
The only problem I can see right now is we need the following
additional line for shm:
Ning Qu wrote:
> For replacing a page inside page cache, we assume the huge page
> has been splitted before getting here.
>
> For adding a new page to page cache, huge page support has been added.
>
> Also refactor the shm_add_to_page_cache function.
>
> Signed-off-by: Ning Qu
> ---
>
Ning Qu wrote:
For replacing a page inside page cache, we assume the huge page
has been splitted before getting here.
For adding a new page to page cache, huge page support has been added.
Also refactor the shm_add_to_page_cache function.
Signed-off-by: Ning Qu qun...@gmail.com
---
Yes, I can try. The code is pretty much similar with some minor difference.
One thing I can do is to move the spin lock part (together with the
corresponding err handling into a common function.
The only problem I can see right now is we need the following
additional line for shm:
For replacing a page inside page cache, we assume the huge page
has been splitted before getting here.
For adding a new page to page cache, huge page support has been added.
Also refactor the shm_add_to_page_cache function.
Signed-off-by: Ning Qu
---
mm/shmem.c | 97
For replacing a page inside page cache, we assume the huge page
has been splitted before getting here.
For adding a new page to page cache, huge page support has been added.
Also refactor the shm_add_to_page_cache function.
Signed-off-by: Ning Qu qun...@gmail.com
---
mm/shmem.c | 97
12 matches
Mail list logo
