Re: [PATCH 02/13] mm: use page_off_lru()

2020-09-21 Thread Michal Hocko
On Fri 18-09-20 12:53:58, Yu Zhao wrote: > On Fri, Sep 18, 2020 at 01:09:14PM +0200, Michal Hocko wrote: > > On Fri 18-09-20 04:27:13, Yu Zhao wrote: > > > On Fri, Sep 18, 2020 at 09:37:00AM +0200, Michal Hocko wrote: > > > > On Thu 17-09-20 21:00:40, Yu Zhao wrote: > > > > > This patch replaces

Re: [PATCH 02/13] mm: use page_off_lru()

2020-09-18 Thread Yu Zhao
On Fri, Sep 18, 2020 at 01:09:14PM +0200, Michal Hocko wrote: > On Fri 18-09-20 04:27:13, Yu Zhao wrote: > > On Fri, Sep 18, 2020 at 09:37:00AM +0200, Michal Hocko wrote: > > > On Thu 17-09-20 21:00:40, Yu Zhao wrote: > > > > This patch replaces the only open-coded __ClearPageActive() with > > > >

Re: [PATCH 02/13] mm: use page_off_lru()

2020-09-18 Thread Michal Hocko
On Fri 18-09-20 04:27:13, Yu Zhao wrote: > On Fri, Sep 18, 2020 at 09:37:00AM +0200, Michal Hocko wrote: [...] > And I have asked this before: why does 'the compound page situation' > even matter here? Perhaps if you could give a concrete example related > to the code change and help me understand

Re: [PATCH 02/13] mm: use page_off_lru()

2020-09-18 Thread Michal Hocko
On Fri 18-09-20 04:27:13, Yu Zhao wrote: > On Fri, Sep 18, 2020 at 09:37:00AM +0200, Michal Hocko wrote: > > On Thu 17-09-20 21:00:40, Yu Zhao wrote: > > > This patch replaces the only open-coded __ClearPageActive() with > > > page_off_lru(). There is no open-coded __ClearPageUnevictable()s. > > >

Re: [PATCH 02/13] mm: use page_off_lru()

2020-09-18 Thread Yu Zhao
On Fri, Sep 18, 2020 at 09:37:00AM +0200, Michal Hocko wrote: > On Thu 17-09-20 21:00:40, Yu Zhao wrote: > > This patch replaces the only open-coded __ClearPageActive() with > > page_off_lru(). There is no open-coded __ClearPageUnevictable()s. > > > > Before this patch, we have: > >

Re: [PATCH 02/13] mm: use page_off_lru()

2020-09-18 Thread Michal Hocko
On Thu 17-09-20 21:00:40, Yu Zhao wrote: > This patch replaces the only open-coded __ClearPageActive() with > page_off_lru(). There is no open-coded __ClearPageUnevictable()s. > > Before this patch, we have: > __ClearPageActive() > add_page_to_lru_list() > > After this patch, we

[PATCH 02/13] mm: use page_off_lru()

2020-09-17 Thread Yu Zhao
This patch replaces the only open-coded __ClearPageActive() with page_off_lru(). There is no open-coded __ClearPageUnevictable()s. Before this patch, we have: __ClearPageActive() add_page_to_lru_list() After this patch, we have: page_off_lru() if