Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Nov 10, 2017 at 10:42:06AM +, Srinivas Kandagatla wrote: > > > On 10/11/17 04:59, Vinod Koul wrote: > >On Thu, Nov 09, 2017 at 09:14:07PM +, Srinivas Kandagatla wrote: > >> > >> > >>On 19/10/17 04:03, Vinod Koul wrote: > >>>This adds the base SoundWire bus type, bus and driver

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Nov 10, 2017 at 10:42:06AM +, Srinivas Kandagatla wrote: > > > On 10/11/17 04:59, Vinod Koul wrote: > >On Thu, Nov 09, 2017 at 09:14:07PM +, Srinivas Kandagatla wrote: > >> > >> > >>On 19/10/17 04:03, Vinod Koul wrote: > >>>This adds the base SoundWire bus type, bus and driver

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On 10/11/17 08:55, Vinod Koul wrote: + +/** + * sdw_get_device_id: find the matching SoundWire device id + * function name should end with () - according to kernel doc. ah thanks for pointing will add I ran the kernel-doc script, seems to not complain about this. Looking at it closely

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On 10/11/17 08:55, Vinod Koul wrote: + +/** + * sdw_get_device_id: find the matching SoundWire device id + * function name should end with () - according to kernel doc. ah thanks for pointing will add I ran the kernel-doc script, seems to not complain about this. Looking at it closely

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On 10/11/17 04:59, Vinod Koul wrote: On Thu, Nov 09, 2017 at 09:14:07PM +, Srinivas Kandagatla wrote: On 19/10/17 04:03, Vinod Koul wrote: This adds the base SoundWire bus type, bus and driver registration. along with changes to module device table for new SoundWire device type.

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On 10/11/17 04:59, Vinod Koul wrote: On Thu, Nov 09, 2017 at 09:14:07PM +, Srinivas Kandagatla wrote: On 19/10/17 04:03, Vinod Koul wrote: This adds the base SoundWire bus type, bus and driver registration. along with changes to module device table for new SoundWire device type.

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Nov 10, 2017 at 10:29:51AM +0530, Vinod Koul wrote: > On Thu, Nov 09, 2017 at 09:14:07PM +, Srinivas Kandagatla wrote: > > > > > > On 19/10/17 04:03, Vinod Koul wrote: > > >This adds the base SoundWire bus type, bus and driver registration. > > >along with changes to module device

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Nov 10, 2017 at 10:29:51AM +0530, Vinod Koul wrote: > On Thu, Nov 09, 2017 at 09:14:07PM +, Srinivas Kandagatla wrote: > > > > > > On 19/10/17 04:03, Vinod Koul wrote: > > >This adds the base SoundWire bus type, bus and driver registration. > > >along with changes to module device

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Thu, Nov 09, 2017 at 09:14:07PM +, Srinivas Kandagatla wrote: > > > On 19/10/17 04:03, Vinod Koul wrote: > >This adds the base SoundWire bus type, bus and driver registration. > >along with changes to module device table for new SoundWire > >device type. > > > >Signed-off-by: Sanyog Kale

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Thu, Nov 09, 2017 at 09:14:07PM +, Srinivas Kandagatla wrote: > > > On 19/10/17 04:03, Vinod Koul wrote: > >This adds the base SoundWire bus type, bus and driver registration. > >along with changes to module device table for new SoundWire > >device type. > > > >Signed-off-by: Sanyog Kale

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On 19/10/17 04:03, Vinod Koul wrote: This adds the base SoundWire bus type, bus and driver registration. along with changes to module device table for new SoundWire device type. Signed-off-by: Sanyog Kale Signed-off-by: Vinod Koul --- +++

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On 19/10/17 04:03, Vinod Koul wrote: This adds the base SoundWire bus type, bus and driver registration. along with changes to module device table for new SoundWire device type. Signed-off-by: Sanyog Kale Signed-off-by: Vinod Koul --- +++ b/drivers/soundwire/Kconfig @@ -0,0 +1,22 @@ +#

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Oct 27, 2017 at 10:57:39AM +0200, Greg Kroah-Hartman wrote: > On Thu, Oct 26, 2017 at 02:03:42PM +0530, Vinod Koul wrote: > > On Fri, Oct 20, 2017 at 09:31:34PM +0530, Vinod Koul wrote: > > > On Fri, Oct 20, 2017 at 12:45:28PM +0200, Greg Kroah-Hartman wrote: > > > > On Thu, Oct 19, 2017

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Oct 27, 2017 at 10:57:39AM +0200, Greg Kroah-Hartman wrote: > On Thu, Oct 26, 2017 at 02:03:42PM +0530, Vinod Koul wrote: > > On Fri, Oct 20, 2017 at 09:31:34PM +0530, Vinod Koul wrote: > > > On Fri, Oct 20, 2017 at 12:45:28PM +0200, Greg Kroah-Hartman wrote: > > > > On Thu, Oct 19, 2017

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Thu, Oct 26, 2017 at 02:03:42PM +0530, Vinod Koul wrote: > On Fri, Oct 20, 2017 at 09:31:34PM +0530, Vinod Koul wrote: > > On Fri, Oct 20, 2017 at 12:45:28PM +0200, Greg Kroah-Hartman wrote: > > > On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > > > > > +struct bus_type

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Thu, Oct 26, 2017 at 02:03:42PM +0530, Vinod Koul wrote: > On Fri, Oct 20, 2017 at 09:31:34PM +0530, Vinod Koul wrote: > > On Fri, Oct 20, 2017 at 12:45:28PM +0200, Greg Kroah-Hartman wrote: > > > On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > > > > > +struct bus_type

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Oct 20, 2017 at 09:31:34PM +0530, Vinod Koul wrote: > On Fri, Oct 20, 2017 at 12:45:28PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > > > +struct bus_type sdw_bus_type = { > > > + .name = "soundwire", > > > + .match = sdw_bus_match, >

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Oct 20, 2017 at 09:31:34PM +0530, Vinod Koul wrote: > On Fri, Oct 20, 2017 at 12:45:28PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > > > +struct bus_type sdw_bus_type = { > > > + .name = "soundwire", > > > + .match = sdw_bus_match, >

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

> > I quick grep on Dual license users looks like we already have this > > in kernel > > code. See drivers/ntb/hw/intel/ntb_hw_intel.c > > Just because someone did something wrong in the past, doesn't mean > they > should keep doing more wrong things in the future :) What makes you think it's

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

> > I quick grep on Dual license users looks like we already have this > > in kernel > > code. See drivers/ntb/hw/intel/ntb_hw_intel.c > > Just because someone did something wrong in the past, doesn't mean > they > should keep doing more wrong things in the future :) What makes you think it's

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

> > > And why dual license something that will only ever work on Linux? > > > > We have non Linux users (mostly RTOS folks) which we would like to > > support > > with as much as common code. > > Note, you need to be VERY CAREFUL about doing this.  You need to have > all sorts of infrastructure

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

> > > And why dual license something that will only ever work on Linux? > > > > We have non Linux users (mostly RTOS folks) which we would like to > > support > > with as much as common code. > > Note, you need to be VERY CAREFUL about doing this.  You need to have > all sorts of infrastructure

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Sat, Oct 21, 2017 at 10:03:48AM +0100, Mark Brown wrote: > On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > > > + ret = dev_pm_domain_attach(dev, false); > > + if (ret) { > > + dev_err(dev, "Failed to attach PM domain: %d\n", ret); > > + return ret; > > +

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Sat, Oct 21, 2017 at 10:03:48AM +0100, Mark Brown wrote: > On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > > > + ret = dev_pm_domain_attach(dev, false); > > + if (ret) { > > + dev_err(dev, "Failed to attach PM domain: %d\n", ret); > > + return ret; > > +

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > + ret = dev_pm_domain_attach(dev, false); > + if (ret) { > + dev_err(dev, "Failed to attach PM domain: %d\n", ret); > + return ret; > + } > + > + ret = drv->probe(slave, id); > + if (ret) { >

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > + ret = dev_pm_domain_attach(dev, false); > + if (ret) { > + dev_err(dev, "Failed to attach PM domain: %d\n", ret); > + return ret; > + } > + > + ret = drv->probe(slave, id); > + if (ret) { >

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Oct 20, 2017 at 06:27:23PM +0200, Greg Kroah-Hartman wrote: > On Fri, Oct 20, 2017 at 09:50:42PM +0530, Vinod Koul wrote: > > On Fri, Oct 20, 2017 at 06:03:24PM +0200, Philippe Ombredanne wrote: > > > On Fri, Oct 20, 2017 at 12:45 PM, Greg Kroah-Hartman > > >

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Oct 20, 2017 at 06:27:23PM +0200, Greg Kroah-Hartman wrote: > On Fri, Oct 20, 2017 at 09:50:42PM +0530, Vinod Koul wrote: > > On Fri, Oct 20, 2017 at 06:03:24PM +0200, Philippe Ombredanne wrote: > > > On Fri, Oct 20, 2017 at 12:45 PM, Greg Kroah-Hartman > > > wrote: > > > > On Thu, Oct

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Oct 20, 2017 at 06:21:23PM +0200, Greg Kroah-Hartman wrote: > On Fri, Oct 20, 2017 at 09:31:34PM +0530, Vinod Koul wrote: > > On Fri, Oct 20, 2017 at 12:45:28PM +0200, Greg Kroah-Hartman wrote: > > > On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > > > > +/* > > > > + * This

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Oct 20, 2017 at 06:21:23PM +0200, Greg Kroah-Hartman wrote: > On Fri, Oct 20, 2017 at 09:31:34PM +0530, Vinod Koul wrote: > > On Fri, Oct 20, 2017 at 12:45:28PM +0200, Greg Kroah-Hartman wrote: > > > On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > > > > +/* > > > > + * This

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Oct 20, 2017 at 09:50:42PM +0530, Vinod Koul wrote: > On Fri, Oct 20, 2017 at 06:03:24PM +0200, Philippe Ombredanne wrote: > > On Fri, Oct 20, 2017 at 12:45 PM, Greg Kroah-Hartman > > wrote: > > > On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > >

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Oct 20, 2017 at 09:50:42PM +0530, Vinod Koul wrote: > On Fri, Oct 20, 2017 at 06:03:24PM +0200, Philippe Ombredanne wrote: > > On Fri, Oct 20, 2017 at 12:45 PM, Greg Kroah-Hartman > > wrote: > > > On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > > >> diff --git

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Oct 20, 2017 at 09:31:34PM +0530, Vinod Koul wrote: > On Fri, Oct 20, 2017 at 12:45:28PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > > > +/* > > > + * This file is provided under a dual BSD/GPLv2 license. When using or > > > + *

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Oct 20, 2017 at 09:31:34PM +0530, Vinod Koul wrote: > On Fri, Oct 20, 2017 at 12:45:28PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > > > +/* > > > + * This file is provided under a dual BSD/GPLv2 license. When using or > > > + *

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Oct 20, 2017 at 06:03:24PM +0200, Philippe Ombredanne wrote: > On Fri, Oct 20, 2017 at 12:45 PM, Greg Kroah-Hartman > wrote: > > On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > >> diff --git a/drivers/soundwire/bus_type.c

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Oct 20, 2017 at 06:03:24PM +0200, Philippe Ombredanne wrote: > On Fri, Oct 20, 2017 at 12:45 PM, Greg Kroah-Hartman > wrote: > > On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > >> diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c > >> new file mode

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Oct 20, 2017 at 05:50:57PM +0200, Takashi Iwai wrote: > On Fri, 20 Oct 2017 17:46:49 +0200, > Vinod Koul wrote: > > > > > > --- a/include/linux/mod_devicetable.h > > > > > > +++ b/include/linux/mod_devicetable.h > > > > > > @@ -228,6 +228,13 @@ struct hda_device_id { > > > > > >

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Oct 20, 2017 at 05:50:57PM +0200, Takashi Iwai wrote: > On Fri, 20 Oct 2017 17:46:49 +0200, > Vinod Koul wrote: > > > > > > --- a/include/linux/mod_devicetable.h > > > > > > +++ b/include/linux/mod_devicetable.h > > > > > > @@ -228,6 +228,13 @@ struct hda_device_id { > > > > > >

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Oct 20, 2017 at 12:45 PM, Greg Kroah-Hartman wrote: > On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: >> diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c >> new file mode 100644 >> index ..a14d1de80afa >> ---

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Oct 20, 2017 at 12:45 PM, Greg Kroah-Hartman wrote: > On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: >> diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c >> new file mode 100644 >> index ..a14d1de80afa >> --- /dev/null >> +++

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Oct 20, 2017 at 12:45:28PM +0200, Greg Kroah-Hartman wrote: > On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > > +/* > > + * This file is provided under a dual BSD/GPLv2 license. When using or > > + * redistributing this file, you may do so under either license. > > + * > >

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Oct 20, 2017 at 12:45:28PM +0200, Greg Kroah-Hartman wrote: > On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > > +/* > > + * This file is provided under a dual BSD/GPLv2 license. When using or > > + * redistributing this file, you may do so under either license. > > + * > >

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, 20 Oct 2017 17:46:49 +0200, Vinod Koul wrote: > > On Fri, Oct 20, 2017 at 08:59:42AM +0200, Takashi Iwai wrote: > > On Fri, 20 Oct 2017 07:11:01 +0200, > > Vinod Koul wrote: > > > > > > On Thu, Oct 19, 2017 at 09:40:06AM +0200, Takashi Iwai wrote: > > > > On Thu, 19 Oct 2017 05:03:18

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, 20 Oct 2017 17:46:49 +0200, Vinod Koul wrote: > > On Fri, Oct 20, 2017 at 08:59:42AM +0200, Takashi Iwai wrote: > > On Fri, 20 Oct 2017 07:11:01 +0200, > > Vinod Koul wrote: > > > > > > On Thu, Oct 19, 2017 at 09:40:06AM +0200, Takashi Iwai wrote: > > > > On Thu, 19 Oct 2017 05:03:18

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Oct 20, 2017 at 12:41:20PM +0200, Greg Kroah-Hartman wrote: > On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > > diff --git a/drivers/soundwire/bus.h b/drivers/soundwire/bus.h > > new file mode 100644 > > index ..2683c6798b95 > > --- /dev/null > > +++

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Oct 20, 2017 at 12:41:20PM +0200, Greg Kroah-Hartman wrote: > On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > > diff --git a/drivers/soundwire/bus.h b/drivers/soundwire/bus.h > > new file mode 100644 > > index ..2683c6798b95 > > --- /dev/null > > +++

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Oct 20, 2017 at 08:59:42AM +0200, Takashi Iwai wrote: > On Fri, 20 Oct 2017 07:11:01 +0200, > Vinod Koul wrote: > > > > On Thu, Oct 19, 2017 at 09:40:06AM +0200, Takashi Iwai wrote: > > > On Thu, 19 Oct 2017 05:03:18 +0200, > > > Vinod Koul wrote: > > > > + > > > > +config SOUNDWIRE_BUS >

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, Oct 20, 2017 at 08:59:42AM +0200, Takashi Iwai wrote: > On Fri, 20 Oct 2017 07:11:01 +0200, > Vinod Koul wrote: > > > > On Thu, Oct 19, 2017 at 09:40:06AM +0200, Takashi Iwai wrote: > > > On Thu, 19 Oct 2017 05:03:18 +0200, > > > Vinod Koul wrote: > > > > + > > > > +config SOUNDWIRE_BUS >

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c > new file mode 100644 > index ..a14d1de80afa > --- /dev/null > +++ b/drivers/soundwire/bus_type.c > @@ -0,0 +1,229 @@ > +/* > + * This file is

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c > new file mode 100644 > index ..a14d1de80afa > --- /dev/null > +++ b/drivers/soundwire/bus_type.c > @@ -0,0 +1,229 @@ > +/* > + * This file is

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > diff --git a/drivers/soundwire/bus.h b/drivers/soundwire/bus.h > new file mode 100644 > index ..2683c6798b95 > --- /dev/null > +++ b/drivers/soundwire/bus.h > @@ -0,0 +1,62 @@ > +/* > + * This file is provided under a dual

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > diff --git a/drivers/soundwire/bus.h b/drivers/soundwire/bus.h > new file mode 100644 > index ..2683c6798b95 > --- /dev/null > +++ b/drivers/soundwire/bus.h > @@ -0,0 +1,62 @@ > +/* > + * This file is provided under a dual

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, 20 Oct 2017 07:11:01 +0200, Vinod Koul wrote: > > On Thu, Oct 19, 2017 at 09:40:06AM +0200, Takashi Iwai wrote: > > On Thu, 19 Oct 2017 05:03:18 +0200, > > Vinod Koul wrote: > > > + > > > +config SOUNDWIRE_BUS > > > + tristate > > > + default SOUNDWIRE > > > + > > > > Does it make sense

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Fri, 20 Oct 2017 07:11:01 +0200, Vinod Koul wrote: > > On Thu, Oct 19, 2017 at 09:40:06AM +0200, Takashi Iwai wrote: > > On Thu, 19 Oct 2017 05:03:18 +0200, > > Vinod Koul wrote: > > > + > > > +config SOUNDWIRE_BUS > > > + tristate > > > + default SOUNDWIRE > > > + > > > > Does it make sense

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Thu, Oct 19, 2017 at 09:40:06AM +0200, Takashi Iwai wrote: > On Thu, 19 Oct 2017 05:03:18 +0200, > Vinod Koul wrote: > > + > > +config SOUNDWIRE_BUS > > + tristate > > + default SOUNDWIRE > > + > > Does it make sense to be tristate? > Since CONFIG_SOUNDWIRE is a bool, the above would be

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Thu, Oct 19, 2017 at 09:40:06AM +0200, Takashi Iwai wrote: > On Thu, 19 Oct 2017 05:03:18 +0200, > Vinod Koul wrote: > > + > > +config SOUNDWIRE_BUS > > + tristate > > + default SOUNDWIRE > > + > > Does it make sense to be tristate? > Since CONFIG_SOUNDWIRE is a bool, the above would be

Re: [alsa-devel] [PATCH 02/14] soundwire: Add SoundWire bus type

On Thu, 19 Oct 2017 09:40:06 +0200, Takashi Iwai wrote: > > On Thu, 19 Oct 2017 05:03:18 +0200, > Vinod Koul wrote: > > > > --- /dev/null > > +++ b/drivers/soundwire/Kconfig > > @@ -0,0 +1,22 @@ > > +# > > +# SoundWire subsystem configuration > > +# > > + > > +menuconfig SOUNDWIRE > > + bool

Re: [alsa-devel] [PATCH 02/14] soundwire: Add SoundWire bus type

On Thu, 19 Oct 2017 09:40:06 +0200, Takashi Iwai wrote: > > On Thu, 19 Oct 2017 05:03:18 +0200, > Vinod Koul wrote: > > > > --- /dev/null > > +++ b/drivers/soundwire/Kconfig > > @@ -0,0 +1,22 @@ > > +# > > +# SoundWire subsystem configuration > > +# > > + > > +menuconfig SOUNDWIRE > > + bool

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Thu, 19 Oct 2017 05:03:18 +0200, Vinod Koul wrote: > > --- /dev/null > +++ b/drivers/soundwire/Kconfig > @@ -0,0 +1,22 @@ > +# > +# SoundWire subsystem configuration > +# > + > +menuconfig SOUNDWIRE > + bool "SoundWire support" > + ---help--- > + SoundWire is a 2-Pin interface

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

On Thu, 19 Oct 2017 05:03:18 +0200, Vinod Koul wrote: > > --- /dev/null > +++ b/drivers/soundwire/Kconfig > @@ -0,0 +1,22 @@ > +# > +# SoundWire subsystem configuration > +# > + > +menuconfig SOUNDWIRE > + bool "SoundWire support" > + ---help--- > + SoundWire is a 2-Pin interface

[PATCH 02/14] soundwire: Add SoundWire bus type

This adds the base SoundWire bus type, bus and driver registration. along with changes to module device table for new SoundWire device type. Signed-off-by: Sanyog Kale Signed-off-by: Vinod Koul --- drivers/Kconfig | 2 +

[PATCH 02/14] soundwire: Add SoundWire bus type

This adds the base SoundWire bus type, bus and driver registration. along with changes to module device table for new SoundWire device type. Signed-off-by: Sanyog Kale Signed-off-by: Vinod Koul --- drivers/Kconfig | 2 + drivers/Makefile | 1 +