Re: [PATCH 02/24] Input: gpio_keys - Simplify with dev_err_probe()

2020-08-26 Thread Krzysztof Kozlowski
On Wed, Aug 26, 2020 at 10:39:12PM +0300, Andy Shevchenko wrote: > On Wed, Aug 26, 2020 at 10:23 PM Krzysztof Kozlowski wrote: > > On Wed, Aug 26, 2020 at 10:13:34PM +0300, Andy Shevchenko wrote: > > > On Wed, Aug 26, 2020 at 08:16:44PM +0200, Krzysztof Kozlowski wrote: > > > > Common pattern of

Re: [PATCH 02/24] Input: gpio_keys - Simplify with dev_err_probe()

2020-08-26 Thread Andy Shevchenko
On Wed, Aug 26, 2020 at 10:23 PM Krzysztof Kozlowski wrote: > On Wed, Aug 26, 2020 at 10:13:34PM +0300, Andy Shevchenko wrote: > > On Wed, Aug 26, 2020 at 08:16:44PM +0200, Krzysztof Kozlowski wrote: > > > Common pattern of handling deferred probe can be simplified with > > > dev_err_probe().

Re: [PATCH 02/24] Input: gpio_keys - Simplify with dev_err_probe()

2020-08-26 Thread Krzysztof Kozlowski
On Wed, Aug 26, 2020 at 10:13:34PM +0300, Andy Shevchenko wrote: > On Wed, Aug 26, 2020 at 08:16:44PM +0200, Krzysztof Kozlowski wrote: > > Common pattern of handling deferred probe can be simplified with > > dev_err_probe(). Less code and also it prints the error value. > > > ---

Re: [PATCH 02/24] Input: gpio_keys - Simplify with dev_err_probe()

2020-08-26 Thread Andy Shevchenko
On Wed, Aug 26, 2020 at 08:16:44PM +0200, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. > --- a/drivers/input/keyboard/gpio_keys.c > +++ b/drivers/input/keyboard/gpio_keys.c > @@

[PATCH 02/24] Input: gpio_keys - Simplify with dev_err_probe()

2020-08-26 Thread Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by: Krzysztof Kozlowski --- drivers/input/keyboard/gpio_keys.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git