Re: [PATCH 02/24] thunderbolt: Do not try to read UID if DROM offset is read as 0

2017-05-22 Thread Andreas Noever
On Mon, May 22, 2017 at 10:38 PM, Mika Westerberg wrote: > On Mon, May 22, 2017 at 08:41:22PM +0200, Andreas Noever wrote: >> Yes there is a check for the root switch, but also one that checks the >> return code of tb_drom_read_uid_only :) >> >> err =

Re: [PATCH 02/24] thunderbolt: Do not try to read UID if DROM offset is read as 0

2017-05-22 Thread Andreas Noever
On Mon, May 22, 2017 at 10:38 PM, Mika Westerberg wrote: > On Mon, May 22, 2017 at 08:41:22PM +0200, Andreas Noever wrote: >> Yes there is a check for the root switch, but also one that checks the >> return code of tb_drom_read_uid_only :) >> >> err = tb_drom_read_uid_only(sw, ); >> if (err) { >>

Re: [PATCH 02/24] thunderbolt: Do not try to read UID if DROM offset is read as 0

2017-05-22 Thread Mika Westerberg
On Mon, May 22, 2017 at 08:41:22PM +0200, Andreas Noever wrote: > Yes there is a check for the root switch, but also one that checks the > return code of tb_drom_read_uid_only :) > > err = tb_drom_read_uid_only(sw, ); > if (err) { > tb_sw_warn(sw, "uid read failed\n"); > return err; > } >

Re: [PATCH 02/24] thunderbolt: Do not try to read UID if DROM offset is read as 0

2017-05-22 Thread Mika Westerberg
On Mon, May 22, 2017 at 08:41:22PM +0200, Andreas Noever wrote: > Yes there is a check for the root switch, but also one that checks the > return code of tb_drom_read_uid_only :) > > err = tb_drom_read_uid_only(sw, ); > if (err) { > tb_sw_warn(sw, "uid read failed\n"); > return err; > } >

Re: [PATCH 02/24] thunderbolt: Do not try to read UID if DROM offset is read as 0

2017-05-22 Thread Andreas Noever
On Mon, May 22, 2017 at 10:40 AM, Mika Westerberg wrote: > On Sun, May 21, 2017 at 03:46:20PM +0200, Andreas Noever wrote: >> On Thu, May 18, 2017 at 4:38 PM, Mika Westerberg >> wrote: >> > At least Falcon Ridge when in host mode

Re: [PATCH 02/24] thunderbolt: Do not try to read UID if DROM offset is read as 0

2017-05-22 Thread Andreas Noever
On Mon, May 22, 2017 at 10:40 AM, Mika Westerberg wrote: > On Sun, May 21, 2017 at 03:46:20PM +0200, Andreas Noever wrote: >> On Thu, May 18, 2017 at 4:38 PM, Mika Westerberg >> wrote: >> > At least Falcon Ridge when in host mode does not have any kind of DROM >> > available and reading DROM

Re: [PATCH 02/24] thunderbolt: Do not try to read UID if DROM offset is read as 0

2017-05-22 Thread Mika Westerberg
On Sun, May 21, 2017 at 03:46:20PM +0200, Andreas Noever wrote: > On Thu, May 18, 2017 at 4:38 PM, Mika Westerberg > wrote: > > At least Falcon Ridge when in host mode does not have any kind of DROM > > available and reading DROM offset returns 0 for these. Do not

Re: [PATCH 02/24] thunderbolt: Do not try to read UID if DROM offset is read as 0

2017-05-22 Thread Mika Westerberg
On Sun, May 21, 2017 at 03:46:20PM +0200, Andreas Noever wrote: > On Thu, May 18, 2017 at 4:38 PM, Mika Westerberg > wrote: > > At least Falcon Ridge when in host mode does not have any kind of DROM > > available and reading DROM offset returns 0 for these. Do not try to > > read DROM any further

Re: [PATCH 02/24] thunderbolt: Do not try to read UID if DROM offset is read as 0

2017-05-21 Thread Andreas Noever
On Thu, May 18, 2017 at 4:38 PM, Mika Westerberg wrote: > At least Falcon Ridge when in host mode does not have any kind of DROM > available and reading DROM offset returns 0 for these. Do not try to > read DROM any further in that case. > > Signed-off-by: Mika

Re: [PATCH 02/24] thunderbolt: Do not try to read UID if DROM offset is read as 0

2017-05-21 Thread Andreas Noever
On Thu, May 18, 2017 at 4:38 PM, Mika Westerberg wrote: > At least Falcon Ridge when in host mode does not have any kind of DROM > available and reading DROM offset returns 0 for these. Do not try to > read DROM any further in that case. > > Signed-off-by: Mika Westerberg > Reviewed-by: Yehezkel

[PATCH 02/24] thunderbolt: Do not try to read UID if DROM offset is read as 0

2017-05-18 Thread Mika Westerberg
At least Falcon Ridge when in host mode does not have any kind of DROM available and reading DROM offset returns 0 for these. Do not try to read DROM any further in that case. Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat

[PATCH 02/24] thunderbolt: Do not try to read UID if DROM offset is read as 0

2017-05-18 Thread Mika Westerberg
At least Falcon Ridge when in host mode does not have any kind of DROM available and reading DROM offset returns 0 for these. Do not try to read DROM any further in that case. Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by: Michael Jamet ---