Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Russell King - ARM Linux
On Fri, Jul 27, 2012 at 03:39:31PM +0100, Ian Campbell wrote: > On Fri, 2012-07-27 at 15:21 +0100, Russell King - ARM Linux wrote: > > On Fri, Jul 27, 2012 at 02:02:18PM +0100, Stefano Stabellini wrote: > > > > > > +/** >

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Ian Campbell
On Fri, 2012-07-27 at 15:21 +0100, Russell King - ARM Linux wrote: > On Fri, Jul 27, 2012 at 02:02:18PM +0100, Stefano Stabellini wrote: > > > > > +/** > > > > > + * hypercall.h > > > > > + * > > > > > + * Linux-specific

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2012, Russell King - ARM Linux wrote: > On Fri, Jul 27, 2012 at 02:02:18PM +0100, Stefano Stabellini wrote: > > > > > +/** > > > > > + * hypercall.h > > > > > + * > > > > > + * Linux-specific hypervisor

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Russell King - ARM Linux
On Fri, Jul 27, 2012 at 02:02:18PM +0100, Stefano Stabellini wrote: > > > > +/** > > > > + * hypercall.h > > > > + * > > > > + * Linux-specific hypervisor handling. > > > > + * > > > > + * Stefano Stabellini , Citrix, 2012

Re: [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2012, Christopher Covington wrote: > On 07/27/2012 05:19 AM, Ian Campbell wrote: > > On Thu, 2012-07-26 at 20:19 +0100, Christopher Covington wrote: > >> Hi Stefano, > >> > >> On 07/26/2012 11:33 AM, Stefano Stabellini wrote: > >>> Use r12 to pass the hypercall number to the

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2012, Ian Campbell wrote: > > > > Should this comment be by 'privcmd_call'? > > > > > > When we add a 5 argument hypercall I suppose we'll see the required > > > push/pop of r4 added to this macro too. > > > > For performance and simplicity I would add a second macro that push/pop

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Ian Campbell
On Fri, 2012-07-27 at 14:02 +0100, Stefano Stabellini wrote: > On Fri, 27 Jul 2012, Ian Campbell wrote: > > On Thu, 2012-07-26 at 17:33 +0100, Konrad Rzeszutek Wilk wrote: > > > On Thu, Jul 26, 2012 at 04:33:44PM +0100, Stefano Stabellini wrote: > > > > Use r12 to pass the hypercall number to the

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2012, Ian Campbell wrote: > On Thu, 2012-07-26 at 17:33 +0100, Konrad Rzeszutek Wilk wrote: > > On Thu, Jul 26, 2012 at 04:33:44PM +0100, Stefano Stabellini wrote: > > > Use r12 to pass the hypercall number to the hypervisor. > > > > > > We need a register to pass the hypercall

Re: [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Christopher Covington
On 07/27/2012 05:19 AM, Ian Campbell wrote: > On Thu, 2012-07-26 at 20:19 +0100, Christopher Covington wrote: >> Hi Stefano, >> >> On 07/26/2012 11:33 AM, Stefano Stabellini wrote: >>> Use r12 to pass the hypercall number to the hypervisor. >>> >>> We need a register to pass the hypercall number

Re: [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Ian Campbell
On Thu, 2012-07-26 at 20:19 +0100, Christopher Covington wrote: > Hi Stefano, > > On 07/26/2012 11:33 AM, Stefano Stabellini wrote: > > Use r12 to pass the hypercall number to the hypervisor. > > > > We need a register to pass the hypercall number because we might not > > know it at compile time

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Ian Campbell
On Thu, 2012-07-26 at 17:33 +0100, Konrad Rzeszutek Wilk wrote: > On Thu, Jul 26, 2012 at 04:33:44PM +0100, Stefano Stabellini wrote: > > Use r12 to pass the hypercall number to the hypervisor. > > > > We need a register to pass the hypercall number because we might not > > know it at compile

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Ian Campbell
On Thu, 2012-07-26 at 17:56 +0100, David Vrabel wrote: > On 26/07/12 16:33, Stefano Stabellini wrote: > > > > + * The hvc ISS is required to be 0xEA1, that is the Xen specific ARM > > + * hypercall tag. > > Is this number, 0xea1, assigned to Xen by some external body? The value and semantics of

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Ian Campbell
On Thu, 2012-07-26 at 17:56 +0100, David Vrabel wrote: On 26/07/12 16:33, Stefano Stabellini wrote: + * The hvc ISS is required to be 0xEA1, that is the Xen specific ARM + * hypercall tag. Is this number, 0xea1, assigned to Xen by some external body? The value and semantics of the hvc

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Ian Campbell
On Thu, 2012-07-26 at 17:33 +0100, Konrad Rzeszutek Wilk wrote: On Thu, Jul 26, 2012 at 04:33:44PM +0100, Stefano Stabellini wrote: Use r12 to pass the hypercall number to the hypervisor. We need a register to pass the hypercall number because we might not know it at compile time and HVC

Re: [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Ian Campbell
On Thu, 2012-07-26 at 20:19 +0100, Christopher Covington wrote: Hi Stefano, On 07/26/2012 11:33 AM, Stefano Stabellini wrote: Use r12 to pass the hypercall number to the hypervisor. We need a register to pass the hypercall number because we might not know it at compile time and HVC

Re: [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Christopher Covington
On 07/27/2012 05:19 AM, Ian Campbell wrote: On Thu, 2012-07-26 at 20:19 +0100, Christopher Covington wrote: Hi Stefano, On 07/26/2012 11:33 AM, Stefano Stabellini wrote: Use r12 to pass the hypercall number to the hypervisor. We need a register to pass the hypercall number because we might

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2012, Ian Campbell wrote: On Thu, 2012-07-26 at 17:33 +0100, Konrad Rzeszutek Wilk wrote: On Thu, Jul 26, 2012 at 04:33:44PM +0100, Stefano Stabellini wrote: Use r12 to pass the hypercall number to the hypervisor. We need a register to pass the hypercall number because

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Ian Campbell
On Fri, 2012-07-27 at 14:02 +0100, Stefano Stabellini wrote: On Fri, 27 Jul 2012, Ian Campbell wrote: On Thu, 2012-07-26 at 17:33 +0100, Konrad Rzeszutek Wilk wrote: On Thu, Jul 26, 2012 at 04:33:44PM +0100, Stefano Stabellini wrote: Use r12 to pass the hypercall number to the

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2012, Ian Campbell wrote: Should this comment be by 'privcmd_call'? When we add a 5 argument hypercall I suppose we'll see the required push/pop of r4 added to this macro too. For performance and simplicity I would add a second macro that push/pop r4, only

Re: [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2012, Christopher Covington wrote: On 07/27/2012 05:19 AM, Ian Campbell wrote: On Thu, 2012-07-26 at 20:19 +0100, Christopher Covington wrote: Hi Stefano, On 07/26/2012 11:33 AM, Stefano Stabellini wrote: Use r12 to pass the hypercall number to the hypervisor. We need

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Russell King - ARM Linux
On Fri, Jul 27, 2012 at 02:02:18PM +0100, Stefano Stabellini wrote: +/** + * hypercall.h + * + * Linux-specific hypervisor handling. + * + * Stefano Stabellini stefano.stabell...@eu.citrix.com,

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2012, Russell King - ARM Linux wrote: On Fri, Jul 27, 2012 at 02:02:18PM +0100, Stefano Stabellini wrote: +/** + * hypercall.h + * + * Linux-specific hypervisor handling. + * +

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Ian Campbell
On Fri, 2012-07-27 at 15:21 +0100, Russell King - ARM Linux wrote: On Fri, Jul 27, 2012 at 02:02:18PM +0100, Stefano Stabellini wrote: +/** + * hypercall.h + * + * Linux-specific hypervisor handling.

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Russell King - ARM Linux
On Fri, Jul 27, 2012 at 03:39:31PM +0100, Ian Campbell wrote: On Fri, 2012-07-27 at 15:21 +0100, Russell King - ARM Linux wrote: On Fri, Jul 27, 2012 at 02:02:18PM +0100, Stefano Stabellini wrote: +/** + *

Re: [PATCH 02/24] xen/arm: hypercalls

2012-07-26 Thread Christopher Covington
Hi Stefano, On 07/26/2012 11:33 AM, Stefano Stabellini wrote: > Use r12 to pass the hypercall number to the hypervisor. > > We need a register to pass the hypercall number because we might not > know it at compile time and HVC only takes an immediate argument. You're not going to JIT assemble

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-26 Thread Stefano Stabellini
On Thu, 26 Jul 2012, David Vrabel wrote: > On 26/07/12 16:33, Stefano Stabellini wrote: > > > > + * The hvc ISS is required to be 0xEA1, that is the Xen specific ARM > > + * hypercall tag. > > Is this number, 0xea1, assigned to Xen by some external body? I am not aware of any "external body"

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-26 Thread David Vrabel
On 26/07/12 16:33, Stefano Stabellini wrote: > > + * The hvc ISS is required to be 0xEA1, that is the Xen specific ARM > + * hypercall tag. Is this number, 0xea1, assigned to Xen by some external body? David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-26 Thread Konrad Rzeszutek Wilk
On Thu, Jul 26, 2012 at 04:33:44PM +0100, Stefano Stabellini wrote: > Use r12 to pass the hypercall number to the hypervisor. > > We need a register to pass the hypercall number because we might not > know it at compile time and HVC only takes an immediate argument. > > Among the available

[PATCH 02/24] xen/arm: hypercalls

2012-07-26 Thread Stefano Stabellini
Use r12 to pass the hypercall number to the hypervisor. We need a register to pass the hypercall number because we might not know it at compile time and HVC only takes an immediate argument. Among the available registers r12 seems to be the best choice because it is defined as "intra-procedure

[PATCH 02/24] xen/arm: hypercalls

2012-07-26 Thread Stefano Stabellini
Use r12 to pass the hypercall number to the hypervisor. We need a register to pass the hypercall number because we might not know it at compile time and HVC only takes an immediate argument. Among the available registers r12 seems to be the best choice because it is defined as intra-procedure

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-26 Thread Konrad Rzeszutek Wilk
On Thu, Jul 26, 2012 at 04:33:44PM +0100, Stefano Stabellini wrote: Use r12 to pass the hypercall number to the hypervisor. We need a register to pass the hypercall number because we might not know it at compile time and HVC only takes an immediate argument. Among the available registers

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-26 Thread David Vrabel
On 26/07/12 16:33, Stefano Stabellini wrote: + * The hvc ISS is required to be 0xEA1, that is the Xen specific ARM + * hypercall tag. Is this number, 0xea1, assigned to Xen by some external body? David -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-26 Thread Stefano Stabellini
On Thu, 26 Jul 2012, David Vrabel wrote: On 26/07/12 16:33, Stefano Stabellini wrote: + * The hvc ISS is required to be 0xEA1, that is the Xen specific ARM + * hypercall tag. Is this number, 0xea1, assigned to Xen by some external body? I am not aware of any external body that could

Re: [PATCH 02/24] xen/arm: hypercalls

2012-07-26 Thread Christopher Covington
Hi Stefano, On 07/26/2012 11:33 AM, Stefano Stabellini wrote: Use r12 to pass the hypercall number to the hypervisor. We need a register to pass the hypercall number because we might not know it at compile time and HVC only takes an immediate argument. You're not going to JIT assemble the