Re: [PATCH 02/30] spi: dw: Use ternary op to init set_cs callback

2020-09-30 Thread Serge Semin
On Wed, Sep 30, 2020 at 04:01:17PM +0100, Mark Brown wrote: > On Wed, Sep 30, 2020 at 05:57:59PM +0300, Serge Semin wrote: > > On Wed, Sep 30, 2020 at 12:55:55AM +0300, Serge Semin wrote: > > > > + if (dws->set_cs) > > > + master->set_cs = dws->set_cs; > > > + else > > > +

Re: [PATCH 02/30] spi: dw: Use ternary op to init set_cs callback

2020-09-30 Thread Mark Brown
On Wed, Sep 30, 2020 at 05:57:59PM +0300, Serge Semin wrote: > On Wed, Sep 30, 2020 at 12:55:55AM +0300, Serge Semin wrote: > > + if (dws->set_cs) > > + master->set_cs = dws->set_cs; > > + else > > + master->set_cs = dw_spi_set_cs; > Judging by having your comment on this

Re: [PATCH 02/30] spi: dw: Use ternary op to init set_cs callback

2020-09-30 Thread Serge Semin
Mark, A concrete question is below the main text.) On Wed, Sep 30, 2020 at 12:55:55AM +0300, Serge Semin wrote: > On Tue, Sep 29, 2020 at 02:11:53PM +0100, Mark Brown wrote: > > On Sun, Sep 20, 2020 at 02:28:46PM +0300, Serge Semin wrote: > > > Simplify the dw_spi_add_host() method a bit by

Re: [PATCH 02/30] spi: dw: Use ternary op to init set_cs callback

2020-09-29 Thread Serge Semin
On Tue, Sep 29, 2020 at 02:11:53PM +0100, Mark Brown wrote: > On Sun, Sep 20, 2020 at 02:28:46PM +0300, Serge Semin wrote: > > Simplify the dw_spi_add_host() method a bit by replacing the set_cs > > callback overwrite procedure with direct setting the callback if a custom > > version of one is

Re: [PATCH 02/30] spi: dw: Use ternary op to init set_cs callback

2020-09-29 Thread Mark Brown
On Sun, Sep 20, 2020 at 02:28:46PM +0300, Serge Semin wrote: > Simplify the dw_spi_add_host() method a bit by replacing the set_cs > callback overwrite procedure with direct setting the callback if a custom > version of one is specified. > - master->set_cs = dw_spi_set_cs; > +

[PATCH 02/30] spi: dw: Use ternary op to init set_cs callback

2020-09-20 Thread Serge Semin
Simplify the dw_spi_add_host() method a bit by replacing the set_cs callback overwrite procedure with direct setting the callback if a custom version of one is specified. Signed-off-by: Serge Semin --- drivers/spi/spi-dw-core.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff