Re: [PATCH 02/37] staging:r8188eu: remove device assignment after netdev_alloc_skb call

2016-10-25 Thread Greg Kroah-Hartman
On Thu, Oct 20, 2016 at 07:16:20PM +0700, Ivan Safonov wrote: > Andy, > thank you for reviewing patches and tips. Please redo this series based on these responses and resend. thanks, greg k-h

Re: [PATCH 02/37] staging:r8188eu: remove device assignment after netdev_alloc_skb call

2016-10-25 Thread Greg Kroah-Hartman
On Thu, Oct 20, 2016 at 07:16:20PM +0700, Ivan Safonov wrote: > Andy, > thank you for reviewing patches and tips. Please redo this series based on these responses and resend. thanks, greg k-h

Re: [PATCH 02/37] staging:r8188eu: remove device assignment after netdev_alloc_skb call

2016-10-20 Thread Ivan Safonov
Andy, thank you for reviewing patches and tips. On 10/19/2016 11:59 PM, Andy Shevchenko wrote: On Wed, 2016-10-19 at 19:53 +0300, Andy Shevchenko wrote: On Wed, 2016-10-19 at 22:07 +0700, Ivan Safonov wrote: netdev_alloc_skb function already set dev member of pkt_copy. It might be one

Re: [PATCH 02/37] staging:r8188eu: remove device assignment after netdev_alloc_skb call

2016-10-20 Thread Ivan Safonov
Andy, thank you for reviewing patches and tips. On 10/19/2016 11:59 PM, Andy Shevchenko wrote: On Wed, 2016-10-19 at 19:53 +0300, Andy Shevchenko wrote: On Wed, 2016-10-19 at 22:07 +0700, Ivan Safonov wrote: netdev_alloc_skb function already set dev member of pkt_copy. It might be one

Re: [PATCH 02/37] staging:r8188eu: remove device assignment after netdev_alloc_skb call

2016-10-20 Thread Dan Carpenter
On Wed, Oct 19, 2016 at 10:07:30PM +0700, Ivan Safonov wrote: > netdev_alloc_skb function > already set dev member of pkt_copy. > I'm coming back to this one after sending a response to patch 3. Here again, this patch was complicated for me to review because I mostly read the body of the email

Re: [PATCH 02/37] staging:r8188eu: remove device assignment after netdev_alloc_skb call

2016-10-20 Thread Dan Carpenter
On Wed, Oct 19, 2016 at 10:07:30PM +0700, Ivan Safonov wrote: > netdev_alloc_skb function > already set dev member of pkt_copy. > I'm coming back to this one after sending a response to patch 3. Here again, this patch was complicated for me to review because I mostly read the body of the email

Re: [PATCH 02/37] staging:r8188eu: remove device assignment after netdev_alloc_skb call

2016-10-19 Thread Andy Shevchenko
On Wed, 2016-10-19 at 19:53 +0300, Andy Shevchenko wrote: > On Wed, 2016-10-19 at 22:07 +0700, Ivan Safonov wrote: > > > > netdev_alloc_skb function > > already set dev member of pkt_copy. > > It might be one line. > > Some special references: > functions: function() > structs: struct my_struct

Re: [PATCH 02/37] staging:r8188eu: remove device assignment after netdev_alloc_skb call

2016-10-19 Thread Andy Shevchenko
On Wed, 2016-10-19 at 19:53 +0300, Andy Shevchenko wrote: > On Wed, 2016-10-19 at 22:07 +0700, Ivan Safonov wrote: > > > > netdev_alloc_skb function > > already set dev member of pkt_copy. > > It might be one line. > > Some special references: > functions: function() > structs: struct my_struct

Re: [PATCH 02/37] staging:r8188eu: remove device assignment after netdev_alloc_skb call

2016-10-19 Thread Andy Shevchenko
On Wed, 2016-10-19 at 22:07 +0700, Ivan Safonov wrote: > netdev_alloc_skb function > already set dev member of pkt_copy. It might be one line. Some special references: functions: function() structs: struct my_struct P.S. Entire series lacks of cover letter. > > Signed-off-by: Ivan Safonov

Re: [PATCH 02/37] staging:r8188eu: remove device assignment after netdev_alloc_skb call

2016-10-19 Thread Andy Shevchenko
On Wed, 2016-10-19 at 22:07 +0700, Ivan Safonov wrote: > netdev_alloc_skb function > already set dev member of pkt_copy. It might be one line. Some special references: functions: function() structs: struct my_struct P.S. Entire series lacks of cover letter. > > Signed-off-by: Ivan Safonov >

[PATCH 02/37] staging:r8188eu: remove device assignment after netdev_alloc_skb call

2016-10-19 Thread Ivan Safonov
netdev_alloc_skb function already set dev member of pkt_copy. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c

[PATCH 02/37] staging:r8188eu: remove device assignment after netdev_alloc_skb call

2016-10-19 Thread Ivan Safonov
netdev_alloc_skb function already set dev member of pkt_copy. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c