Re: [PATCH 03/10] ALSA: add AXD Audio Processing IP alsa driver

2015-09-03 Thread Mark Brown
On Fri, Aug 28, 2015 at 10:22:57AM +0100, Qais Yousef wrote: > On 08/27/2015 04:32 PM, Mark Brown wrote: > >On Thu, Aug 27, 2015 at 01:15:51PM +0100, Qais Yousef wrote: > +#define AXD_BASE_VADDR 0xD000 > >>>This sounds like something that is going to be platform dependant, >

Re: [PATCH 03/10] ALSA: add AXD Audio Processing IP alsa driver

2015-09-03 Thread Mark Brown
On Fri, Aug 28, 2015 at 10:22:57AM +0100, Qais Yousef wrote: > On 08/27/2015 04:32 PM, Mark Brown wrote: > >On Thu, Aug 27, 2015 at 01:15:51PM +0100, Qais Yousef wrote: > +#define AXD_BASE_VADDR 0xD000 > >>>This sounds like something that is going to be platform dependant, >

Re: [PATCH 03/10] ALSA: add AXD Audio Processing IP alsa driver

2015-08-28 Thread Qais Yousef
On 08/27/2015 04:32 PM, Mark Brown wrote: On Thu, Aug 27, 2015 at 01:15:51PM +0100, Qais Yousef wrote: On 08/26/2015 07:37 PM, Mark Brown wrote: On Mon, Aug 24, 2015 at 01:39:12PM +0100, Qais Yousef wrote: +#define AXD_INPUT_DESCRIPTORS 10 +struct axd_input { + struct axd_buffer_desc

Re: [PATCH 03/10] ALSA: add AXD Audio Processing IP alsa driver

2015-08-28 Thread Qais Yousef
On 08/27/2015 04:32 PM, Mark Brown wrote: On Thu, Aug 27, 2015 at 01:15:51PM +0100, Qais Yousef wrote: On 08/26/2015 07:37 PM, Mark Brown wrote: On Mon, Aug 24, 2015 at 01:39:12PM +0100, Qais Yousef wrote: +#define AXD_INPUT_DESCRIPTORS 10 +struct axd_input { + struct axd_buffer_desc

Re: [PATCH 03/10] ALSA: add AXD Audio Processing IP alsa driver

2015-08-27 Thread Mark Brown
On Thu, Aug 27, 2015 at 01:15:51PM +0100, Qais Yousef wrote: > On 08/26/2015 07:37 PM, Mark Brown wrote: > >On Mon, Aug 24, 2015 at 01:39:12PM +0100, Qais Yousef wrote: > >>+#define AXD_INPUT_DESCRIPTORS 10 > >>+struct axd_input { > >>+ struct axd_buffer_desc descriptors[AXD_INPUT_DESCRIPTORS];

Re: [PATCH 03/10] ALSA: add AXD Audio Processing IP alsa driver

2015-08-27 Thread Qais Yousef
On 08/26/2015 07:37 PM, Mark Brown wrote: On Mon, Aug 24, 2015 at 01:39:12PM +0100, Qais Yousef wrote: +#define THREAD_COUNT 4 This is a very generic name that looks likely to collide with something else, please namespace. OK. +#define AXD_INPUT_DESCRIPTORS 10 +struct axd_input { +

Re: [PATCH 03/10] ALSA: add AXD Audio Processing IP alsa driver

2015-08-27 Thread Mark Brown
On Thu, Aug 27, 2015 at 01:15:51PM +0100, Qais Yousef wrote: On 08/26/2015 07:37 PM, Mark Brown wrote: On Mon, Aug 24, 2015 at 01:39:12PM +0100, Qais Yousef wrote: +#define AXD_INPUT_DESCRIPTORS 10 +struct axd_input { + struct axd_buffer_desc descriptors[AXD_INPUT_DESCRIPTORS]; +}; Where

Re: [PATCH 03/10] ALSA: add AXD Audio Processing IP alsa driver

2015-08-27 Thread Qais Yousef
On 08/26/2015 07:37 PM, Mark Brown wrote: On Mon, Aug 24, 2015 at 01:39:12PM +0100, Qais Yousef wrote: +#define THREAD_COUNT 4 This is a very generic name that looks likely to collide with something else, please namespace. OK. +#define AXD_INPUT_DESCRIPTORS 10 +struct axd_input { +

Re: [PATCH 03/10] ALSA: add AXD Audio Processing IP alsa driver

2015-08-26 Thread Mark Brown
On Mon, Aug 24, 2015 at 01:39:12PM +0100, Qais Yousef wrote: > +#define THREAD_COUNT 4 This is a very generic name that looks likely to collide with something else, please namespace. > +#define AXD_INPUT_DESCRIPTORS 10 > +struct axd_input { > + struct axd_buffer_desc

Re: [PATCH 03/10] ALSA: add AXD Audio Processing IP alsa driver

2015-08-26 Thread Mark Brown
On Mon, Aug 24, 2015 at 01:39:12PM +0100, Qais Yousef wrote: +#define THREAD_COUNT 4 This is a very generic name that looks likely to collide with something else, please namespace. +#define AXD_INPUT_DESCRIPTORS 10 +struct axd_input { + struct axd_buffer_desc

[PATCH 03/10] ALSA: add AXD Audio Processing IP alsa driver

2015-08-24 Thread Qais Yousef
AXD is Audio Processing IP by Imagination Technologies that can decode multiple file formats and play them back. We use alsa compress offload API to represent our audio driver. This patch adds defs and initialisation files. Signed-off-by: Qais Yousef Cc: Liam Girdwood Cc: Mark Brown Cc:

[PATCH 03/10] ALSA: add AXD Audio Processing IP alsa driver

2015-08-24 Thread Qais Yousef
AXD is Audio Processing IP by Imagination Technologies that can decode multiple file formats and play them back. We use alsa compress offload API to represent our audio driver. This patch adds defs and initialisation files. Signed-off-by: Qais Yousef qais.you...@imgtec.com Cc: Liam Girdwood