Re: [PATCH 03/10] msm: iommu: Convert to clk_prepare/unprepare

2012-09-25 Thread Stephen Boyd
On 09/24/12 15:32, Saravana Kannan wrote: >> @@ -275,8 +275,11 @@ static int msm_iommu_remove(struct >> platform_device *pdev) >> >> drv = platform_get_drvdata(pdev); >> if (drv) { >> -if (drv->clk) >> +if (drv->clk) { >> +clk_unprepare(drv->clk); >>

Re: [PATCH 03/10] msm: iommu: Convert to clk_prepare/unprepare

2012-09-25 Thread Stephen Boyd
On 09/24/12 15:32, Saravana Kannan wrote: @@ -275,8 +275,11 @@ static int msm_iommu_remove(struct platform_device *pdev) drv = platform_get_drvdata(pdev); if (drv) { -if (drv-clk) +if (drv-clk) { +clk_unprepare(drv-clk);

Re: [PATCH 03/10] msm: iommu: Convert to clk_prepare/unprepare

2012-09-24 Thread Saravana Kannan
On 09/20/2012 07:26 PM, Stephen Boyd wrote: Add calls to clk_prepare and unprepare so that MSM can migrate to the common clock framework. We never unprepare the clocks until driver remove because the clocks are enabled and disabled in irq context. Finer grained power management is possible in

Re: [PATCH 03/10] msm: iommu: Convert to clk_prepare/unprepare

2012-09-24 Thread Saravana Kannan
On 09/20/2012 07:26 PM, Stephen Boyd wrote: Add calls to clk_prepare and unprepare so that MSM can migrate to the common clock framework. We never unprepare the clocks until driver remove because the clocks are enabled and disabled in irq context. Finer grained power management is possible in

[PATCH 03/10] msm: iommu: Convert to clk_prepare/unprepare

2012-09-20 Thread Stephen Boyd
Add calls to clk_prepare and unprepare so that MSM can migrate to the common clock framework. We never unprepare the clocks until driver remove because the clocks are enabled and disabled in irq context. Finer grained power management is possible in the future via runtime power management

[PATCH 03/10] msm: iommu: Convert to clk_prepare/unprepare

2012-09-20 Thread Stephen Boyd
Add calls to clk_prepare and unprepare so that MSM can migrate to the common clock framework. We never unprepare the clocks until driver remove because the clocks are enabled and disabled in irq context. Finer grained power management is possible in the future via runtime power management