Re: [PATCH 03/12] __wr_after_init: generic functionality

2018-12-21 Thread Igor Stoppa
On 21/12/2018 21:43, Matthew Wilcox wrote: On Fri, Dec 21, 2018 at 09:07:54PM +0200, Igor Stoppa wrote: On 21/12/2018 20:41, Matthew Wilcox wrote: On Fri, Dec 21, 2018 at 08:14:14PM +0200, Igor Stoppa wrote: +static inline int memtst(void *p, int c, __kernel_size_t len) I don't

Re: [PATCH 03/12] __wr_after_init: generic functionality

2018-12-21 Thread Matthew Wilcox
On Fri, Dec 21, 2018 at 09:07:54PM +0200, Igor Stoppa wrote: > On 21/12/2018 20:41, Matthew Wilcox wrote: > > On Fri, Dec 21, 2018 at 08:14:14PM +0200, Igor Stoppa wrote: > > > +static inline int memtst(void *p, int c, __kernel_size_t len) > > > > I don't understand why you're verifying that

Re: [PATCH 03/12] __wr_after_init: generic functionality

2018-12-21 Thread Igor Stoppa
On 21/12/2018 20:41, Matthew Wilcox wrote: On Fri, Dec 21, 2018 at 08:14:14PM +0200, Igor Stoppa wrote: +static inline int memtst(void *p, int c, __kernel_size_t len) I don't understand why you're verifying that writes actually happen in production code. Sure, write lib/test_wrmem.c or

Re: [PATCH 03/12] __wr_after_init: generic functionality

2018-12-21 Thread Matthew Wilcox
On Fri, Dec 21, 2018 at 08:14:14PM +0200, Igor Stoppa wrote: > +static inline int memtst(void *p, int c, __kernel_size_t len) I don't understand why you're verifying that writes actually happen in production code. Sure, write lib/test_wrmem.c or something, but verifying every single rare write

[PATCH 03/12] __wr_after_init: generic functionality

2018-12-21 Thread Igor Stoppa
The patch provides: - the generic part of the write rare functionality for static data, based on code from Matthew Wilcox - the dummy functionality, in case an arch doesn't support write rare or the functionality is disabled The basic functions are: - wr_memset(): write rare counterpart of