Re: [PATCH 03/14] perf hists: Convert hist entry functions to use struct he_stat

2013-11-04 Thread Namhyung Kim
Hi Arnaldo, On Mon, 4 Nov 2013 20:45:51 -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Oct 31, 2013 at 03:56:05PM +0900, Namhyung Kim escreveu: > >> -static void hist_entry__add_cpumode_period(struct hist_entry *he, >> +static void hist_entry__add_cpumode_period(struct he_stat *he_stat, >>

Re: [PATCH 03/14] perf hists: Convert hist entry functions to use struct he_stat

2013-11-04 Thread Arnaldo Carvalho de Melo
Em Thu, Oct 31, 2013 at 03:56:05PM +0900, Namhyung Kim escreveu: > -static void hist_entry__add_cpumode_period(struct hist_entry *he, > +static void hist_entry__add_cpumode_period(struct he_stat *he_stat, > unsigned int cpumode, u64 period) So it is not

Re: [PATCH 03/14] perf hists: Convert hist entry functions to use struct he_stat

2013-11-04 Thread Arnaldo Carvalho de Melo
Em Thu, Oct 31, 2013 at 03:56:05PM +0900, Namhyung Kim escreveu: -static void hist_entry__add_cpumode_period(struct hist_entry *he, +static void hist_entry__add_cpumode_period(struct he_stat *he_stat, unsigned int cpumode, u64 period) So it is not

Re: [PATCH 03/14] perf hists: Convert hist entry functions to use struct he_stat

2013-11-04 Thread Namhyung Kim
Hi Arnaldo, On Mon, 4 Nov 2013 20:45:51 -0300, Arnaldo Carvalho de Melo wrote: Em Thu, Oct 31, 2013 at 03:56:05PM +0900, Namhyung Kim escreveu: -static void hist_entry__add_cpumode_period(struct hist_entry *he, +static void hist_entry__add_cpumode_period(struct he_stat *he_stat,

[PATCH 03/14] perf hists: Convert hist entry functions to use struct he_stat

2013-10-31 Thread Namhyung Kim
From: Namhyung Kim hist_entry__add_cpumode_period() and hist_entry__decay() are dealing with hist_entry's stat fields only. So make them use the struct directly. Cc: Arun Sharma Cc: Frederic Weisbecker Signed-off-by: Namhyung Kim --- tools/perf/util/hist.c | 20 ++-- 1 file

[PATCH 03/14] perf hists: Convert hist entry functions to use struct he_stat

2013-10-31 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com hist_entry__add_cpumode_period() and hist_entry__decay() are dealing with hist_entry's stat fields only. So make them use the struct directly. Cc: Arun Sharma asha...@fb.com Cc: Frederic Weisbecker fweis...@gmail.com Signed-off-by: Namhyung Kim