Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

Hi, On 21-03-17 06:16, Chanwoo Choi wrote: Hi, On 2017년 03월 21일 04:57, Hans de Goede wrote: Hi, On 20-03-17 02:33, Chanwoo Choi wrote: Hi, On 2017년 03월 17일 18:55, Hans de Goede wrote: Add a driver for charger detection / control on the Intel Cherrytrail Whiskey Cove PMIC. Signed-off-by:

Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

Hi, On 21-03-17 06:16, Chanwoo Choi wrote: Hi, On 2017년 03월 21일 04:57, Hans de Goede wrote: Hi, On 20-03-17 02:33, Chanwoo Choi wrote: Hi, On 2017년 03월 17일 18:55, Hans de Goede wrote: Add a driver for charger detection / control on the Intel Cherrytrail Whiskey Cove PMIC. Signed-off-by:

Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

Hi, I think it again. The "cht_wcove_pwrsrc' is ok, if the register use the 'pwrsrc' word and using the 'wcove' instead of 'wc'. It is not big matter. I agree to use the 'cht_wcove_pwrsrc'. Best Regards, Chanwoo Choi On 2017년 03월 21일 14:21, Chanwoo Choi wrote: > On 2017년 03월 21일 12:54,

Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

Hi, I think it again. The "cht_wcove_pwrsrc' is ok, if the register use the 'pwrsrc' word and using the 'wcove' instead of 'wc'. It is not big matter. I agree to use the 'cht_wcove_pwrsrc'. Best Regards, Chanwoo Choi On 2017년 03월 21일 14:21, Chanwoo Choi wrote: > On 2017년 03월 21일 12:54,

Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

On 2017년 03월 21일 12:54, Chanwoo Choi wrote: > On 2017년 03월 20일 22:00, Andy Shevchenko wrote: >> On Mon, 2017-03-20 at 10:33 +0900, Chanwoo Choi wrote: >>> On 2017년 03월 17일 18:55, Hans de Goede wrote: >> +static const struct platform_device_id cht_wc_extcon_table[] = { + { .name =

Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

On 2017년 03월 21일 12:54, Chanwoo Choi wrote: > On 2017년 03월 20일 22:00, Andy Shevchenko wrote: >> On Mon, 2017-03-20 at 10:33 +0900, Chanwoo Choi wrote: >>> On 2017년 03월 17일 18:55, Hans de Goede wrote: >> +static const struct platform_device_id cht_wc_extcon_table[] = { + { .name =

Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

Hi, On 2017년 03월 21일 04:57, Hans de Goede wrote: > Hi, > > On 20-03-17 02:33, Chanwoo Choi wrote: >> Hi, >> >> On 2017년 03월 17일 18:55, Hans de Goede wrote: >>> Add a driver for charger detection / control on the Intel Cherrytrail >>> Whiskey Cove PMIC. >>> >>> Signed-off-by: Hans de Goede

Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

Hi, On 2017년 03월 21일 04:57, Hans de Goede wrote: > Hi, > > On 20-03-17 02:33, Chanwoo Choi wrote: >> Hi, >> >> On 2017년 03월 17일 18:55, Hans de Goede wrote: >>> Add a driver for charger detection / control on the Intel Cherrytrail >>> Whiskey Cove PMIC. >>> >>> Signed-off-by: Hans de Goede >>>

Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

On 2017년 03월 20일 22:00, Andy Shevchenko wrote: > On Mon, 2017-03-20 at 10:33 +0900, Chanwoo Choi wrote: >> On 2017년 03월 17일 18:55, Hans de Goede wrote: > >>> +static const struct platform_device_id cht_wc_extcon_table[] = { >>> + { .name = "cht_wcove_pwrsrc" }, >> >> You use the 'cht_wc' word

Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

On 2017년 03월 20일 22:00, Andy Shevchenko wrote: > On Mon, 2017-03-20 at 10:33 +0900, Chanwoo Choi wrote: >> On 2017년 03월 17일 18:55, Hans de Goede wrote: > >>> +static const struct platform_device_id cht_wc_extcon_table[] = { >>> + { .name = "cht_wcove_pwrsrc" }, >> >> You use the 'cht_wc' word

Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

Hi, On 20-03-17 02:33, Chanwoo Choi wrote: Hi, On 2017년 03월 17일 18:55, Hans de Goede wrote: Add a driver for charger detection / control on the Intel Cherrytrail Whiskey Cove PMIC. Signed-off-by: Hans de Goede --- drivers/extcon/Kconfig | 7 +

Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

Hi, On 20-03-17 02:33, Chanwoo Choi wrote: Hi, On 2017년 03월 17일 18:55, Hans de Goede wrote: Add a driver for charger detection / control on the Intel Cherrytrail Whiskey Cove PMIC. Signed-off-by: Hans de Goede --- drivers/extcon/Kconfig | 7 + drivers/extcon/Makefile| 1

Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

Hi, On 17-03-17 18:18, Andy Shevchenko wrote: On Fri, 2017-03-17 at 10:55 +0100, Hans de Goede wrote: Add a driver for charger detection / control on the Intel Cherrytrail Whiskey Cove PMIC. +Cc: Felipe for some question(s) below. drivers/extcon/extcon-cht-wc.c | 356 I would use same

Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

Hi, On 17-03-17 18:18, Andy Shevchenko wrote: On Fri, 2017-03-17 at 10:55 +0100, Hans de Goede wrote: Add a driver for charger detection / control on the Intel Cherrytrail Whiskey Cove PMIC. +Cc: Felipe for some question(s) below. drivers/extcon/extcon-cht-wc.c | 356 I would use same

Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

On Mon, 2017-03-20 at 10:33 +0900, Chanwoo Choi wrote: > On 2017년 03월 17일 18:55, Hans de Goede wrote: > > +static const struct platform_device_id cht_wc_extcon_table[] = { > > + { .name = "cht_wcove_pwrsrc" }, > > You use the 'cht_wc' word instead of 'cht_wcove_pwrsrc'. > So, To maintain the

Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

On Mon, 2017-03-20 at 10:33 +0900, Chanwoo Choi wrote: > On 2017년 03월 17일 18:55, Hans de Goede wrote: > > +static const struct platform_device_id cht_wc_extcon_table[] = { > > + { .name = "cht_wcove_pwrsrc" }, > > You use the 'cht_wc' word instead of 'cht_wcove_pwrsrc'. > So, To maintain the

Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

Hi, On 2017년 03월 17일 18:55, Hans de Goede wrote: > Add a driver for charger detection / control on the Intel Cherrytrail > Whiskey Cove PMIC. > > Signed-off-by: Hans de Goede > --- > drivers/extcon/Kconfig | 7 + > drivers/extcon/Makefile| 1 + >

Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

Hi, On 2017년 03월 17일 18:55, Hans de Goede wrote: > Add a driver for charger detection / control on the Intel Cherrytrail > Whiskey Cove PMIC. > > Signed-off-by: Hans de Goede > --- > drivers/extcon/Kconfig | 7 + > drivers/extcon/Makefile| 1 + >

Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

On Fri, 2017-03-17 at 10:55 +0100, Hans de Goede wrote: > Add a driver for charger detection / control on the Intel Cherrytrail > Whiskey Cove PMIC. +Cc: Felipe for some question(s) below. >  drivers/extcon/extcon-cht-wc.c | 356 I would use same pattern across drivers, i.e. "chtwc" (same for

Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

On Fri, 2017-03-17 at 10:55 +0100, Hans de Goede wrote: > Add a driver for charger detection / control on the Intel Cherrytrail > Whiskey Cove PMIC. +Cc: Felipe for some question(s) below. >  drivers/extcon/extcon-cht-wc.c | 356 I would use same pattern across drivers, i.e. "chtwc" (same for

[PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

Add a driver for charger detection / control on the Intel Cherrytrail Whiskey Cove PMIC. Signed-off-by: Hans de Goede --- drivers/extcon/Kconfig | 7 + drivers/extcon/Makefile| 1 + drivers/extcon/extcon-cht-wc.c | 356

[PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

Add a driver for charger detection / control on the Intel Cherrytrail Whiskey Cove PMIC. Signed-off-by: Hans de Goede --- drivers/extcon/Kconfig | 7 + drivers/extcon/Makefile| 1 + drivers/extcon/extcon-cht-wc.c | 356 + 3 files