Re: [PATCH 03/17] fpga: dfl: fme: support 512bit data width PR

2019-03-27 Thread Wu Hao
On Wed, Mar 27, 2019 at 01:19:29AM -0500, Scott Wood wrote: > On Wed, 2019-03-27 at 13:10 +0800, Wu Hao wrote: > > On Mon, Mar 25, 2019 at 05:58:36PM -0500, Scott Wood wrote: > > > On Mon, 2019-03-25 at 17:53 -0500, Scott Wood wrote: > > > > On Mon, 2019-03-25 at 11:07 +0800, Wu Hao wrote: > > > >

Re: [PATCH 03/17] fpga: dfl: fme: support 512bit data width PR

2019-03-27 Thread Scott Wood
On Wed, 2019-03-27 at 13:10 +0800, Wu Hao wrote: > On Mon, Mar 25, 2019 at 05:58:36PM -0500, Scott Wood wrote: > > On Mon, 2019-03-25 at 17:53 -0500, Scott Wood wrote: > > > On Mon, 2019-03-25 at 11:07 +0800, Wu Hao wrote: > > > > In early partial reconfiguration private feature, it only > > > >

Re: [PATCH 03/17] fpga: dfl: fme: support 512bit data width PR

2019-03-27 Thread Wu Hao
On Wed, Mar 27, 2019 at 01:10:31AM -0500, Scott Wood wrote: > On Wed, 2019-03-27 at 12:37 +0800, Wu Hao wrote: > > On Tue, Mar 26, 2019 at 04:22:34PM -0500, Scott Wood wrote: > > > On Tue, 2019-03-26 at 14:33 -0500, Alan Tull wrote: > > > > On Mon, Mar 25, 2019 at 5:58 PM Scott Wood wrote: > > >

Re: [PATCH 03/17] fpga: dfl: fme: support 512bit data width PR

2019-03-27 Thread Scott Wood
On Wed, 2019-03-27 at 12:37 +0800, Wu Hao wrote: > On Tue, Mar 26, 2019 at 04:22:34PM -0500, Scott Wood wrote: > > On Tue, 2019-03-26 at 14:33 -0500, Alan Tull wrote: > > > On Mon, Mar 25, 2019 at 5:58 PM Scott Wood wrote: > > > > > > > > Hi Scott, > > > > > > > On Mon, 2019-03-25 at 17:53

Re: [PATCH 03/17] fpga: dfl: fme: support 512bit data width PR

2019-03-27 Thread Wu Hao
On Mon, Mar 25, 2019 at 05:53:50PM -0500, Scott Wood wrote: > On Mon, 2019-03-25 at 11:07 +0800, Wu Hao wrote: > > @@ -200,21 +228,32 @@ static int fme_mgr_write(struct fpga_manager *mgr, > > pr_credit = FIELD_GET(FME_PR_STS_PR_CREDIT, > > pr_status); > > } > > >

Re: [PATCH 03/17] fpga: dfl: fme: support 512bit data width PR

2019-03-26 Thread Wu Hao
On Mon, Mar 25, 2019 at 05:58:36PM -0500, Scott Wood wrote: > On Mon, 2019-03-25 at 17:53 -0500, Scott Wood wrote: > > On Mon, 2019-03-25 at 11:07 +0800, Wu Hao wrote: > > > In early partial reconfiguration private feature, it only > > > supports 32bit data width when writing data to hardware for

Re: [PATCH 03/17] fpga: dfl: fme: support 512bit data width PR

2019-03-26 Thread Wu Hao
On Tue, Mar 26, 2019 at 04:22:34PM -0500, Scott Wood wrote: > On Tue, 2019-03-26 at 14:33 -0500, Alan Tull wrote: > > On Mon, Mar 25, 2019 at 5:58 PM Scott Wood wrote: > > > > Hi Scott, > > > > > On Mon, 2019-03-25 at 17:53 -0500, Scott Wood wrote: > > > > On Mon, 2019-03-25 at 11:07 +0800, Wu

Re: [PATCH 03/17] fpga: dfl: fme: support 512bit data width PR

2019-03-26 Thread Scott Wood
On Tue, 2019-03-26 at 14:33 -0500, Alan Tull wrote: > On Mon, Mar 25, 2019 at 5:58 PM Scott Wood wrote: > > Hi Scott, > > > On Mon, 2019-03-25 at 17:53 -0500, Scott Wood wrote: > > > On Mon, 2019-03-25 at 11:07 +0800, Wu Hao wrote: > > > > +#if defined(CONFIG_X86) && defined(CONFIG_AS_AVX512) >

Re: [PATCH 03/17] fpga: dfl: fme: support 512bit data width PR

2019-03-26 Thread Alan Tull
On Mon, Mar 25, 2019 at 5:58 PM Scott Wood wrote: Hi Scott, > > On Mon, 2019-03-25 at 17:53 -0500, Scott Wood wrote: > > On Mon, 2019-03-25 at 11:07 +0800, Wu Hao wrote: > > > In early partial reconfiguration private feature, it only > > > supports 32bit data width when writing data to hardware

Re: [PATCH 03/17] fpga: dfl: fme: support 512bit data width PR

2019-03-25 Thread Scott Wood
On Mon, 2019-03-25 at 17:53 -0500, Scott Wood wrote: > On Mon, 2019-03-25 at 11:07 +0800, Wu Hao wrote: > > In early partial reconfiguration private feature, it only > > supports 32bit data width when writing data to hardware for > > PR. 512bit data width PR support is an important optimization >

Re: [PATCH 03/17] fpga: dfl: fme: support 512bit data width PR

2019-03-25 Thread Scott Wood
On Mon, 2019-03-25 at 11:07 +0800, Wu Hao wrote: > In early partial reconfiguration private feature, it only > supports 32bit data width when writing data to hardware for > PR. 512bit data width PR support is an important optimization > for some specific solutions (e.g. XEON with FPGA integrated),

Re: [PATCH 03/17] fpga: dfl: fme: support 512bit data width PR

2019-03-25 Thread Alan Tull
On Sun, Mar 24, 2019 at 10:23 PM Wu Hao wrote: Hi Hao, This looks fine. > > In early partial reconfiguration private feature, it only > supports 32bit data width when writing data to hardware for > PR. 512bit data width PR support is an important optimization > for some specific solutions

[PATCH 03/17] fpga: dfl: fme: support 512bit data width PR

2019-03-24 Thread Wu Hao
In early partial reconfiguration private feature, it only supports 32bit data width when writing data to hardware for PR. 512bit data width PR support is an important optimization for some specific solutions (e.g. XEON with FPGA integrated), it allows driver to use AVX512 instruction to improve