Re: [PATCH 03/18] f2fs crypto: declare some definitions for f2fs encryption feature

2015-05-18 Thread Jaegeuk Kim
On Fri, May 15, 2015 at 09:47:05PM -0700, Tom Marshall wrote: > On Fri, May 15, 2015 at 06:14:24PM -0700, Jaegeuk Kim wrote: > > On Thu, May 14, 2015 at 09:50:44AM -0700, Tom Marshall wrote: > > > Please keep in mind that I'm also working on transparent > > > compression. I'm watching this thread

Re: [PATCH 03/18] f2fs crypto: declare some definitions for f2fs encryption feature

2015-05-18 Thread Jaegeuk Kim
On Fri, May 15, 2015 at 09:47:05PM -0700, Tom Marshall wrote: On Fri, May 15, 2015 at 06:14:24PM -0700, Jaegeuk Kim wrote: On Thu, May 14, 2015 at 09:50:44AM -0700, Tom Marshall wrote: Please keep in mind that I'm also working on transparent compression. I'm watching this thread closely

Re: [PATCH 03/18] f2fs crypto: declare some definitions for f2fs encryption feature

2015-05-16 Thread Tom Marshall
On Sat, May 16, 2015 at 09:24:03AM -0400, Theodore Ts'o wrote: > [...] What's going to be more difficult in the long run is > when we want to support per-block data integrity, using (for example) > AES/GCM, which will require 32 bytes of per-block "authentication tag" > (think Message

Re: [PATCH 03/18] f2fs crypto: declare some definitions for f2fs encryption feature

2015-05-16 Thread Theodore Ts'o
On Thu, May 14, 2015 at 10:37:21AM +1000, Dave Chinner wrote: > > > > AFAIK, Ted wants to push the codes as a crypto library into fs/ finally, so > > I believe most part of crypto codes are common. > > Can I suggest fs/crypto/ if there are going to be multiple files? Yes, I think we definitely

Re: [PATCH 03/18] f2fs crypto: declare some definitions for f2fs encryption feature

2015-05-16 Thread Theodore Ts'o
On Thu, May 14, 2015 at 10:37:21AM +1000, Dave Chinner wrote: AFAIK, Ted wants to push the codes as a crypto library into fs/ finally, so I believe most part of crypto codes are common. Can I suggest fs/crypto/ if there are going to be multiple files? Yes, I think we definitely want to

Re: [PATCH 03/18] f2fs crypto: declare some definitions for f2fs encryption feature

2015-05-16 Thread Tom Marshall
On Sat, May 16, 2015 at 09:24:03AM -0400, Theodore Ts'o wrote: [...] What's going to be more difficult in the long run is when we want to support per-block data integrity, using (for example) AES/GCM, which will require 32 bytes of per-block authentication tag (think Message Authentication

Re: [PATCH 03/18] f2fs crypto: declare some definitions for f2fs encryption feature

2015-05-15 Thread Tom Marshall
On Fri, May 15, 2015 at 06:14:24PM -0700, Jaegeuk Kim wrote: > On Thu, May 14, 2015 at 09:50:44AM -0700, Tom Marshall wrote: > > Please keep in mind that I'm also working on transparent > > compression. I'm watching this thread closely so that I can > > implement a compression library alongside

Re: [PATCH 03/18] f2fs crypto: declare some definitions for f2fs encryption feature

2015-05-15 Thread Jaegeuk Kim
On Thu, May 14, 2015 at 09:50:44AM -0700, Tom Marshall wrote: > Please keep in mind that I'm also working on transparent > compression. I'm watching this thread closely so that I can > implement a compression library alongside the crypto library. If > there is any interest or benefit, I would be

Re: [PATCH 03/18] f2fs crypto: declare some definitions for f2fs encryption feature

2015-05-15 Thread Jaegeuk Kim
On Thu, May 14, 2015 at 09:50:44AM -0700, Tom Marshall wrote: Please keep in mind that I'm also working on transparent compression. I'm watching this thread closely so that I can implement a compression library alongside the crypto library. If there is any interest or benefit, I would be

Re: [PATCH 03/18] f2fs crypto: declare some definitions for f2fs encryption feature

2015-05-15 Thread Tom Marshall
On Fri, May 15, 2015 at 06:14:24PM -0700, Jaegeuk Kim wrote: On Thu, May 14, 2015 at 09:50:44AM -0700, Tom Marshall wrote: Please keep in mind that I'm also working on transparent compression. I'm watching this thread closely so that I can implement a compression library alongside the

Re: [PATCH 03/18] f2fs crypto: declare some definitions for f2fs encryption feature

2015-05-14 Thread Tom Marshall
Please keep in mind that I'm also working on transparent compression. I'm watching this thread closely so that I can implement a compression library alongside the crypto library. If there is any interest or benefit, I would be glad to work together so that the two can be done cooperatively

Re: [PATCH 03/18] f2fs crypto: declare some definitions for f2fs encryption feature

2015-05-14 Thread Tom Marshall
Please keep in mind that I'm also working on transparent compression. I'm watching this thread closely so that I can implement a compression library alongside the crypto library. If there is any interest or benefit, I would be glad to work together so that the two can be done cooperatively

Re: [PATCH 03/18] f2fs crypto: declare some definitions for f2fs encryption feature

2015-05-13 Thread Jaegeuk Kim
On Thu, May 14, 2015 at 10:37:21AM +1000, Dave Chinner wrote: > On Tue, May 12, 2015 at 11:48:02PM -0700, Jaegeuk Kim wrote: > > On Wed, May 13, 2015 at 12:02:08PM +1000, Dave Chinner wrote: > > > On Fri, May 08, 2015 at 09:20:38PM -0700, Jaegeuk Kim wrote: > > > > This definitions will be used by

Re: [PATCH 03/18] f2fs crypto: declare some definitions for f2fs encryption feature

2015-05-13 Thread Dave Chinner
On Tue, May 12, 2015 at 11:48:02PM -0700, Jaegeuk Kim wrote: > On Wed, May 13, 2015 at 12:02:08PM +1000, Dave Chinner wrote: > > On Fri, May 08, 2015 at 09:20:38PM -0700, Jaegeuk Kim wrote: > > > This definitions will be used by inode and superblock for encyption. > > > > How much of this crypto

Re: [PATCH 03/18] f2fs crypto: declare some definitions for f2fs encryption feature

2015-05-13 Thread Jaegeuk Kim
On Wed, May 13, 2015 at 12:02:08PM +1000, Dave Chinner wrote: > On Fri, May 08, 2015 at 09:20:38PM -0700, Jaegeuk Kim wrote: > > This definitions will be used by inode and superblock for encyption. > > How much of this crypto stuff is common with or only slightly > modified from the ext4 code?

Re: [PATCH 03/18] f2fs crypto: declare some definitions for f2fs encryption feature

2015-05-13 Thread Jaegeuk Kim
On Thu, May 14, 2015 at 10:37:21AM +1000, Dave Chinner wrote: On Tue, May 12, 2015 at 11:48:02PM -0700, Jaegeuk Kim wrote: On Wed, May 13, 2015 at 12:02:08PM +1000, Dave Chinner wrote: On Fri, May 08, 2015 at 09:20:38PM -0700, Jaegeuk Kim wrote: This definitions will be used by inode and

Re: [PATCH 03/18] f2fs crypto: declare some definitions for f2fs encryption feature

2015-05-13 Thread Dave Chinner
On Tue, May 12, 2015 at 11:48:02PM -0700, Jaegeuk Kim wrote: On Wed, May 13, 2015 at 12:02:08PM +1000, Dave Chinner wrote: On Fri, May 08, 2015 at 09:20:38PM -0700, Jaegeuk Kim wrote: This definitions will be used by inode and superblock for encyption. How much of this crypto stuff is

Re: [PATCH 03/18] f2fs crypto: declare some definitions for f2fs encryption feature

2015-05-13 Thread Jaegeuk Kim
On Wed, May 13, 2015 at 12:02:08PM +1000, Dave Chinner wrote: On Fri, May 08, 2015 at 09:20:38PM -0700, Jaegeuk Kim wrote: This definitions will be used by inode and superblock for encyption. How much of this crypto stuff is common with or only slightly modified from the ext4 code? Is the

Re: [PATCH 03/18] f2fs crypto: declare some definitions for f2fs encryption feature

2015-05-12 Thread Dave Chinner
On Fri, May 08, 2015 at 09:20:38PM -0700, Jaegeuk Kim wrote: > This definitions will be used by inode and superblock for encyption. How much of this crypto stuff is common with or only slightly modified from the ext4 code? Is the behaviour and features the same? Is the user API and management

Re: [PATCH 03/18] f2fs crypto: declare some definitions for f2fs encryption feature

2015-05-12 Thread Dave Chinner
On Fri, May 08, 2015 at 09:20:38PM -0700, Jaegeuk Kim wrote: This definitions will be used by inode and superblock for encyption. How much of this crypto stuff is common with or only slightly modified from the ext4 code? Is the behaviour and features the same? Is the user API and management

[PATCH 03/18] f2fs crypto: declare some definitions for f2fs encryption feature

2015-05-08 Thread Jaegeuk Kim
This definitions will be used by inode and superblock for encyption. Signed-off-by: Jaegeuk Kim --- fs/f2fs/f2fs.h | 54 ++ fs/f2fs/f2fs_crypto.h | 149 include/linux/f2fs_fs.h | 4 +- 3 files changed, 206

[PATCH 03/18] f2fs crypto: declare some definitions for f2fs encryption feature

2015-05-08 Thread Jaegeuk Kim
This definitions will be used by inode and superblock for encyption. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/f2fs.h | 54 ++ fs/f2fs/f2fs_crypto.h | 149 include/linux/f2fs_fs.h | 4 +- 3 files