Re: "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk())

On Mon, 19 Sep 2016, Joe Perches wrote: > On Tue, 2016-09-20 at 07:53 +0200, Julia Lawall wrote: > > On Mon, 19 Sep 2016, Joe Perches wrote: > > > On Tue, 2016-09-20 at 01:11 +0100, Al Viro wrote: > > > > IMO what we need is to go through all rules in CodingStyle and if for > > > > some rule

Re: "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk())

On Mon, 19 Sep 2016, Joe Perches wrote: > On Tue, 2016-09-20 at 07:53 +0200, Julia Lawall wrote: > > On Mon, 19 Sep 2016, Joe Perches wrote: > > > On Tue, 2016-09-20 at 01:11 +0100, Al Viro wrote: > > > > IMO what we need is to go through all rules in CodingStyle and if for > > > > some rule

Re: "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk())

On Tue, 2016-09-20 at 07:53 +0200, Julia Lawall wrote: > On Mon, 19 Sep 2016, Joe Perches wrote: > > On Tue, 2016-09-20 at 01:11 +0100, Al Viro wrote: > > > IMO what we need is to go through all rules in CodingStyle and if for > > > some rule there is no overwhelming majority in the core kernel,

Re: "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk())

On Tue, 2016-09-20 at 07:53 +0200, Julia Lawall wrote: > On Mon, 19 Sep 2016, Joe Perches wrote: > > On Tue, 2016-09-20 at 01:11 +0100, Al Viro wrote: > > > IMO what we need is to go through all rules in CodingStyle and if for > > > some rule there is no overwhelming majority in the core kernel,

Re: "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk())

On Mon, 19 Sep 2016, Joe Perches wrote: > On Tue, 2016-09-20 at 01:11 +0100, Al Viro wrote: > > IMO what we need is to go through all rules in CodingStyle and if for > > some rule there is no overwhelming majority in the core kernel, well, > > the list has grown way too large and could use

Re: "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk())

On Mon, 19 Sep 2016, Joe Perches wrote: > On Tue, 2016-09-20 at 01:11 +0100, Al Viro wrote: > > IMO what we need is to go through all rules in CodingStyle and if for > > some rule there is no overwhelming majority in the core kernel, well, > > the list has grown way too large and could use

Re: "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk())

On Tue, 2016-09-20 at 01:11 +0100, Al Viro wrote: > IMO what we need is to go through all rules in CodingStyle and if for > some rule there is no overwhelming majority in the core kernel, well, > the list has grown way too large and could use massive trimming. I'm in complete agreement. I also

Re: "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk())

On Tue, 2016-09-20 at 01:11 +0100, Al Viro wrote: > IMO what we need is to go through all rules in CodingStyle and if for > some rule there is no overwhelming majority in the core kernel, well, > the list has grown way too large and could use massive trimming. I'm in complete agreement. I also

Re: "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk())

On Mon, Sep 19, 2016 at 01:53:37PM +0200, Ilya Dryomov wrote: > > I did consider the reason to be good enough to warrant a "change", > > actually. Or more exactly from "one space is allowed" to "one space is > > recommended." Which is quite different from changing all the code > > actively. I can

Re: "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk())

On Mon, Sep 19, 2016 at 01:53:37PM +0200, Ilya Dryomov wrote: > > I did consider the reason to be good enough to warrant a "change", > > actually. Or more exactly from "one space is allowed" to "one space is > > recommended." Which is quite different from changing all the code > > actively. I can

"CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk())

On Mon, Sep 19, 2016 at 11:37 AM, Jean Delvare wrote: > Hi Ilya, > > Sorry for the late answer. > > On Tue, 13 Sep 2016 20:31:57 +0200, Ilya Dryomov wrote: >> Sorry, navigating lkml.org archive is a pain, and I was expecting to >> see patch. Your points >> >> "The acceptance of

"CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk())

On Mon, Sep 19, 2016 at 11:37 AM, Jean Delvare wrote: > Hi Ilya, > > Sorry for the late answer. > > On Tue, 13 Sep 2016 20:31:57 +0200, Ilya Dryomov wrote: >> Sorry, navigating lkml.org archive is a pain, and I was expecting to >> see patch. Your points >> >> "The acceptance of an optional

Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()

Hi Ilya, Sorry for the late answer. On Tue, 13 Sep 2016 20:31:57 +0200, Ilya Dryomov wrote: > Sorry, navigating lkml.org archive is a pain, and I was expecting to > see patch. Your points > > "The acceptance of an optional single space before labels dates back to > at least June 2007, as

Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()

Hi Ilya, Sorry for the late answer. On Tue, 13 Sep 2016 20:31:57 +0200, Ilya Dryomov wrote: > Sorry, navigating lkml.org archive is a pain, and I was expecting to > see patch. Your points > > "The acceptance of an optional single space before labels dates back to > at least June 2007, as

Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()

On Tue, Sep 13, 2016 at 6:50 PM, Jean Delvare wrote: > On Tue, 13 Sep 2016 17:30:33 +0200, Ilya Dryomov wrote: >> On Tue, Sep 13, 2016 at 4:36 PM, Jean Delvare wrote: >> > On Tue, 13 Sep 2016 11:16:13 +0200, Ilya Dryomov wrote: >> >> Jon, could you please yank

Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()

On Tue, Sep 13, 2016 at 6:50 PM, Jean Delvare wrote: > On Tue, 13 Sep 2016 17:30:33 +0200, Ilya Dryomov wrote: >> On Tue, Sep 13, 2016 at 4:36 PM, Jean Delvare wrote: >> > On Tue, 13 Sep 2016 11:16:13 +0200, Ilya Dryomov wrote: >> >> Jon, could you please yank 865a1caa4b6b ("CodingStyle: Clarify

Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()

On Tue, 13 Sep 2016 17:30:33 +0200, Ilya Dryomov wrote: > On Tue, Sep 13, 2016 at 4:36 PM, Jean Delvare wrote: > > On Tue, 13 Sep 2016 11:16:13 +0200, Ilya Dryomov wrote: > >> Jon, could you please yank 865a1caa4b6b ("CodingStyle: Clarify and > >> complete chapter 7") from your

Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()

On Tue, 13 Sep 2016 17:30:33 +0200, Ilya Dryomov wrote: > On Tue, Sep 13, 2016 at 4:36 PM, Jean Delvare wrote: > > On Tue, 13 Sep 2016 11:16:13 +0200, Ilya Dryomov wrote: > >> Jon, could you please yank 865a1caa4b6b ("CodingStyle: Clarify and > >> complete chapter 7") from your linux-next branch

Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()

On Tue, Sep 13, 2016 at 4:36 PM, Jean Delvare wrote: > Hi Ilya, > > Thanks for adding me. > > On Tue, 13 Sep 2016 11:16:13 +0200, Ilya Dryomov wrote: >> On Tue, Sep 13, 2016 at 10:12 AM, SF Markus Elfring >> wrote: >> >>> @@ -1064,7 +1064,7 @@

Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()

On Tue, Sep 13, 2016 at 4:36 PM, Jean Delvare wrote: > Hi Ilya, > > Thanks for adding me. > > On Tue, 13 Sep 2016 11:16:13 +0200, Ilya Dryomov wrote: >> On Tue, Sep 13, 2016 at 10:12 AM, SF Markus Elfring >> wrote: >> >>> @@ -1064,7 +1064,7 @@ static int rbd_header_from_disk(struct rbd_device

Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()

Hi Ilya, Thanks for adding me. On Tue, 13 Sep 2016 11:16:13 +0200, Ilya Dryomov wrote: > On Tue, Sep 13, 2016 at 10:12 AM, SF Markus Elfring > wrote: > >>> @@ -1064,7 +1064,7 @@ static int rbd_header_from_disk(struct rbd_device > >>> *rbd_dev, > >>>

Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()

Hi Ilya, Thanks for adding me. On Tue, 13 Sep 2016 11:16:13 +0200, Ilya Dryomov wrote: > On Tue, Sep 13, 2016 at 10:12 AM, SF Markus Elfring > wrote: > >>> @@ -1064,7 +1064,7 @@ static int rbd_header_from_disk(struct rbd_device > >>> *rbd_dev, > >>> header->snap_sizes = snap_sizes; >

Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()

On Tue, Sep 13, 2016 at 10:12 AM, SF Markus Elfring wrote: >>> @@ -1064,7 +1064,7 @@ static int rbd_header_from_disk(struct rbd_device >>> *rbd_dev, >>> header->snap_sizes = snap_sizes; >>> >>> return 0; >>> -out_2big: >>> + out_2big: >>>

Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()

On Tue, Sep 13, 2016 at 10:12 AM, SF Markus Elfring wrote: >>> @@ -1064,7 +1064,7 @@ static int rbd_header_from_disk(struct rbd_device >>> *rbd_dev, >>> header->snap_sizes = snap_sizes; >>> >>> return 0; >>> -out_2big: >>> + out_2big: >>> ret = -EIO; >>>

Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()

>> @@ -1064,7 +1064,7 @@ static int rbd_header_from_disk(struct rbd_device >> *rbd_dev, >> header->snap_sizes = snap_sizes; >> >> return 0; >> -out_2big: >> + out_2big: >> ret = -EIO; >> kfree(snap_sizes); >> free_names: … > Can you point where this current

Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()

>> @@ -1064,7 +1064,7 @@ static int rbd_header_from_disk(struct rbd_device >> *rbd_dev, >> header->snap_sizes = snap_sizes; >> >> return 0; >> -out_2big: >> + out_2big: >> ret = -EIO; >> kfree(snap_sizes); >> free_names: … > Can you point where this current

Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()

On Mon, Sep 12, 2016 at 8:44 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 11 Sep 2016 13:37:34 +0200 > > Add a space character before a single jump label in this function > according to the current Linux coding

Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()

On Mon, Sep 12, 2016 at 8:44 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 11 Sep 2016 13:37:34 +0200 > > Add a space character before a single jump label in this function > according to the current Linux coding style convention. > > Signed-off-by: Markus Elfring > --- >

[PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()

From: Markus Elfring Date: Sun, 11 Sep 2016 13:37:34 +0200 Add a space character before a single jump label in this function according to the current Linux coding style convention. Signed-off-by: Markus Elfring ---

[PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()

From: Markus Elfring Date: Sun, 11 Sep 2016 13:37:34 +0200 Add a space character before a single jump label in this function according to the current Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/block/rbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)