Re: [PATCH 04/10] perf, tools: Handle header line in mapfile

2015-06-01 Thread Jiri Olsa
On Fri, May 29, 2015 at 10:49:27PM -0700, Andi Kleen wrote: > On Fri, May 29, 2015 at 11:13:15AM +0200, Jiri Olsa wrote: > > On Thu, May 28, 2015 at 10:45:06PM -0700, Sukadev Bhattiprolu wrote: > > > Jiri Olsa [jo...@redhat.com] wrote: > > > | > if (line[0] == '#' || line[0] == '\n')

Re: [PATCH 04/10] perf, tools: Handle header line in mapfile

2015-06-01 Thread Jiri Olsa
On Fri, May 29, 2015 at 10:49:27PM -0700, Andi Kleen wrote: On Fri, May 29, 2015 at 11:13:15AM +0200, Jiri Olsa wrote: On Thu, May 28, 2015 at 10:45:06PM -0700, Sukadev Bhattiprolu wrote: Jiri Olsa [jo...@redhat.com] wrote: |if (line[0] == '#' || line[0] == '\n') |

Re: [PATCH 04/10] perf, tools: Handle header line in mapfile

2015-05-29 Thread Andi Kleen
On Fri, May 29, 2015 at 11:13:15AM +0200, Jiri Olsa wrote: > On Thu, May 28, 2015 at 10:45:06PM -0700, Sukadev Bhattiprolu wrote: > > Jiri Olsa [jo...@redhat.com] wrote: > > | > if (line[0] == '#' || line[0] == '\n') > > | > continue; > > | > +

Re: [PATCH 04/10] perf, tools: Handle header line in mapfile

2015-05-29 Thread Jiri Olsa
On Thu, May 28, 2015 at 10:45:06PM -0700, Sukadev Bhattiprolu wrote: > Jiri Olsa [jo...@redhat.com] wrote: > | > if (line[0] == '#' || line[0] == '\n') > | > continue; > | > + if (!strncmp(line, "Family", 6)) > | > + continue; > | > | I think we

Re: [PATCH 04/10] perf, tools: Handle header line in mapfile

2015-05-29 Thread Jiri Olsa
On Thu, May 28, 2015 at 10:45:06PM -0700, Sukadev Bhattiprolu wrote: Jiri Olsa [jo...@redhat.com] wrote: |if (line[0] == '#' || line[0] == '\n') |continue; | + if (!strncmp(line, Family, 6)) | + continue; | | I think we should fix

Re: [PATCH 04/10] perf, tools: Handle header line in mapfile

2015-05-29 Thread Andi Kleen
On Fri, May 29, 2015 at 11:13:15AM +0200, Jiri Olsa wrote: On Thu, May 28, 2015 at 10:45:06PM -0700, Sukadev Bhattiprolu wrote: Jiri Olsa [jo...@redhat.com] wrote: | if (line[0] == '#' || line[0] == '\n') | continue; | + if

Re: [PATCH 04/10] perf, tools: Handle header line in mapfile

2015-05-28 Thread Sukadev Bhattiprolu
Jiri Olsa [jo...@redhat.com] wrote: | > if (line[0] == '#' || line[0] == '\n') | > continue; | > + if (!strncmp(line, "Family", 6)) | > + continue; | | I think we should fix mapfiles to put the 'Family' starting | line as a comment.. the

Re: [PATCH 04/10] perf, tools: Handle header line in mapfile

2015-05-28 Thread Jiri Olsa
On Wed, May 27, 2015 at 02:23:23PM -0700, Sukadev Bhattiprolu wrote: > From: Andi Kleen > > Support a header line in the mapfile.csv, to match the existing > mapfiles > > Signed-off-by: Andi Kleen > --- > tools/perf/pmu-events/jevents.c |2 ++ > 1 file changed, 2 insertions(+) > > diff

Re: [PATCH 04/10] perf, tools: Handle header line in mapfile

2015-05-28 Thread Sukadev Bhattiprolu
Jiri Olsa [jo...@redhat.com] wrote: | if (line[0] == '#' || line[0] == '\n') | continue; | + if (!strncmp(line, Family, 6)) | + continue; | | I think we should fix mapfiles to put the 'Family' starting | line as a comment.. the way

Re: [PATCH 04/10] perf, tools: Handle header line in mapfile

2015-05-28 Thread Jiri Olsa
On Wed, May 27, 2015 at 02:23:23PM -0700, Sukadev Bhattiprolu wrote: From: Andi Kleen a...@linux.intel.com Support a header line in the mapfile.csv, to match the existing mapfiles Signed-off-by: Andi Kleen a...@linux.intel.com --- tools/perf/pmu-events/jevents.c |2 ++ 1 file

[PATCH 04/10] perf, tools: Handle header line in mapfile

2015-05-27 Thread Sukadev Bhattiprolu
From: Andi Kleen Support a header line in the mapfile.csv, to match the existing mapfiles Signed-off-by: Andi Kleen --- tools/perf/pmu-events/jevents.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c index

[PATCH 04/10] perf, tools: Handle header line in mapfile

2015-05-27 Thread Sukadev Bhattiprolu
From: Andi Kleen a...@linux.intel.com Support a header line in the mapfile.csv, to match the existing mapfiles Signed-off-by: Andi Kleen a...@linux.intel.com --- tools/perf/pmu-events/jevents.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/pmu-events/jevents.c