Re: [PATCH 04/10] pwm: core: use bitops

On Fri, Nov 6, 2015 at 4:49 PM, Olliver Schinagl wrote: > Hey Thierry, > > but why have the bit macro at all then :) For my opinion, it's good to use in new code, or when you have this change as a continuation of bigger series. Though, others might have a different one :-) > > But that choice I

Re: [PATCH 04/10] pwm: core: use bitops

Hey Thierry, but why have the bit macro at all then :) But that choice I guess I leave to you, as it's your section, I know some submaintainers prefer it and want it to be used, so I guess it's something in general kernel wide that should be desided on, BIT() macro preferred or not.

Re: [PATCH 04/10] pwm: core: use bitops

On Mon, Oct 26, 2015 at 10:32:35PM +0100, Olliver Schinagl wrote: > From: Olliver Schinagl > > The pwm header defines bits manually while there is a nice bitops.h with > a BIT() macro. Use the BIT() macro to set bits in pwm.h > > Signed-off-by: Olliver Schinagl > --- > include/linux/pwm.h | 7

Re: [PATCH 04/10] pwm: core: use bitops

On Mon, Oct 26, 2015 at 10:32:35PM +0100, Olliver Schinagl wrote: > From: Olliver Schinagl > > The pwm header defines bits manually while there is a nice bitops.h with > a BIT() macro. Use the BIT() macro to set bits in pwm.h > > Signed-off-by: Olliver Schinagl

Re: [PATCH 04/10] pwm: core: use bitops

Hey Thierry, but why have the bit macro at all then :) But that choice I guess I leave to you, as it's your section, I know some submaintainers prefer it and want it to be used, so I guess it's something in general kernel wide that should be desided on, BIT() macro preferred or not.

Re: [PATCH 04/10] pwm: core: use bitops

On Fri, Nov 6, 2015 at 4:49 PM, Olliver Schinagl wrote: > Hey Thierry, > > but why have the bit macro at all then :) For my opinion, it's good to use in new code, or when you have this change as a continuation of bigger series. Though, others might have a different one

[PATCH 04/10] pwm: core: use bitops

From: Olliver Schinagl The pwm header defines bits manually while there is a nice bitops.h with a BIT() macro. Use the BIT() macro to set bits in pwm.h Signed-off-by: Olliver Schinagl --- include/linux/pwm.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH 04/10] pwm: core: use bitops

From: Olliver Schinagl The pwm header defines bits manually while there is a nice bitops.h with a BIT() macro. Use the BIT() macro to set bits in pwm.h Signed-off-by: Olliver Schinagl --- include/linux/pwm.h | 7 --- 1 file changed, 4 insertions(+),