Re: [PATCH 04/11] UAPI: bcache: Fix use of embedded flexible array

2018-10-09 Thread Jan Engelhardt
On Tuesday 2018-10-09 17:41, David Howells wrote: >Jan Engelhardt wrote: > >> """it [the array size expression] shall be a converted constant expression of >> type std::size_t and its value shall be greater than zero.""" >> —http://eel.is/c++draft/dcl.array > >Interesting. You're not actually

Re: [PATCH 04/11] UAPI: bcache: Fix use of embedded flexible array

2018-10-09 Thread Jan Engelhardt
On Tuesday 2018-10-09 17:41, David Howells wrote: >Jan Engelhardt wrote: > >> """it [the array size expression] shall be a converted constant expression of >> type std::size_t and its value shall be greater than zero.""" >> —http://eel.is/c++draft/dcl.array > >Interesting. You're not actually

Re: [PATCH 04/11] UAPI: bcache: Fix use of embedded flexible array

2018-10-09 Thread David Howells
Jan Engelhardt wrote: > """it [the array size expression] shall be a converted constant expression of > type std::size_t and its value shall be greater than zero.""" > —http://eel.is/c++draft/dcl.array Interesting. You're not actually quoting the full sentence: If the

Re: [PATCH 04/11] UAPI: bcache: Fix use of embedded flexible array

2018-10-09 Thread David Howells
Jan Engelhardt wrote: > """it [the array size expression] shall be a converted constant expression of > type std::size_t and its value shall be greater than zero.""" > —http://eel.is/c++draft/dcl.array Interesting. You're not actually quoting the full sentence: If the

Re: [PATCH 04/11] UAPI: bcache: Fix use of embedded flexible array

2018-10-02 Thread Jan Engelhardt
On Wed, 05 Sep 2018 16:55:03 +0100, David Howells wrote: > >The bkey struct defined by bcache is embedded in the jset struct. However, >this is illegal in C++ as there's a "flexible array" at the end of the struct. >Change this to be a 0-length struct instead. > >- __u64 ptr[]; >+

Re: [PATCH 04/11] UAPI: bcache: Fix use of embedded flexible array

2018-10-02 Thread Jan Engelhardt
On Wed, 05 Sep 2018 16:55:03 +0100, David Howells wrote: > >The bkey struct defined by bcache is embedded in the jset struct. However, >this is illegal in C++ as there's a "flexible array" at the end of the struct. >Change this to be a 0-length struct instead. > >- __u64 ptr[]; >+

[PATCH 04/11] UAPI: bcache: Fix use of embedded flexible array [ver #2]

2018-09-06 Thread David Howells
The bkey struct defined by bcache is embedded in the jset struct. However, this is illegal in C++ as there's a "flexible array" at the end of the struct. Change this to be a 0-length struct instead. Signed-off-by: David Howells cc: Coly Li cc: Kent Overstreet cc: linux-bca...@vger.kernel.org

[PATCH 04/11] UAPI: bcache: Fix use of embedded flexible array [ver #2]

2018-09-06 Thread David Howells
The bkey struct defined by bcache is embedded in the jset struct. However, this is illegal in C++ as there's a "flexible array" at the end of the struct. Change this to be a 0-length struct instead. Signed-off-by: David Howells cc: Coly Li cc: Kent Overstreet cc: linux-bca...@vger.kernel.org

[PATCH 04/11] UAPI: bcache: Fix use of embedded flexible array

2018-09-05 Thread David Howells
The bkey struct defined by bcache is embedded in the jset struct. However, this is illegal in C++ as there's a "flexible array" at the end of the struct. Change this to be a 0-length struct instead. Signed-off-by: David Howells cc: Coly Li cc: Kent Overstreet cc: linux-bca...@vger.kernel.org

[PATCH 04/11] UAPI: bcache: Fix use of embedded flexible array

2018-09-05 Thread David Howells
The bkey struct defined by bcache is embedded in the jset struct. However, this is illegal in C++ as there's a "flexible array" at the end of the struct. Change this to be a 0-length struct instead. Signed-off-by: David Howells cc: Coly Li cc: Kent Overstreet cc: linux-bca...@vger.kernel.org