Re: [PATCH 04/11] vfs: add renameat2 syscall

2014-01-18 Thread Tetsuo Handa
Miklos Szeredi wrote: > Since there were a few changes to the series since posting, I pushed the > updated > patchset to > > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git cross-rename > > Thanks for the reviews. > > Thanks, > Miklos > > > Miklos Szeredi (11): >

Re: [PATCH 04/11] vfs: add renameat2 syscall

2014-01-18 Thread Tetsuo Handa
Miklos Szeredi wrote: Since there were a few changes to the series since posting, I pushed the updated patchset to git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git cross-rename Thanks for the reviews. Thanks, Miklos Miklos Szeredi (11): vfs: add

Re: [PATCH 04/11] vfs: add renameat2 syscall

2014-01-15 Thread Miklos Szeredi
On Wed, Jan 15, 2014 at 11:30:32AM +0100, Miklos Szeredi wrote: > On Wed, Jan 15, 2014 at 07:11:16AM +0900, Tetsuo Handa wrote: > > > > if (!(old_dir->i_op->supported_features & flags)) > > return -EOPNOTSUPP; > > Or rather old_dir->i_sb->s_type->fs_flags. We access it due to >

Re: [PATCH 04/11] vfs: add renameat2 syscall

2014-01-15 Thread Miklos Szeredi
On Wed, Jan 15, 2014 at 07:11:16AM +0900, Tetsuo Handa wrote: > Miklos Szeredi wrote: > > + > > + if (flags) > > + return -EOPNOTSUPP; > > + > > If (at least for now) only ext4 interprets renameat2() flags, > I think adding a new member to "struct inode_operations" and > check it like

Re: [PATCH 04/11] vfs: add renameat2 syscall

2014-01-15 Thread Miklos Szeredi
On Wed, Jan 15, 2014 at 07:11:16AM +0900, Tetsuo Handa wrote: Miklos Szeredi wrote: + + if (flags) + return -EOPNOTSUPP; + If (at least for now) only ext4 interprets renameat2() flags, I think adding a new member to struct inode_operations and check it like if

Re: [PATCH 04/11] vfs: add renameat2 syscall

2014-01-15 Thread Miklos Szeredi
On Wed, Jan 15, 2014 at 11:30:32AM +0100, Miklos Szeredi wrote: On Wed, Jan 15, 2014 at 07:11:16AM +0900, Tetsuo Handa wrote: if (!(old_dir-i_op-supported_features flags)) return -EOPNOTSUPP; Or rather old_dir-i_sb-s_type-fs_flags. We access it due to

Re: [PATCH 04/11] vfs: add renameat2 syscall

2014-01-14 Thread Tetsuo Handa
Miklos Szeredi wrote: > + > + if (flags) > + return -EOPNOTSUPP; > + If (at least for now) only ext4 interprets renameat2() flags, I think adding a new member to "struct inode_operations" and check it like if (!old_dir->i_op->swapname) return -EOPNOTSUPP;

Re: [PATCH 04/11] vfs: add renameat2 syscall

2014-01-14 Thread Tetsuo Handa
Miklos Szeredi wrote: + + if (flags) + return -EOPNOTSUPP; + If (at least for now) only ext4 interprets renameat2() flags, I think adding a new member to struct inode_operations and check it like if (!old_dir-i_op-swapname) return -EOPNOTSUPP; or

[PATCH 04/11] vfs: add renameat2 syscall

2014-01-08 Thread Miklos Szeredi
From: Miklos Szeredi Add new renameat2 syscall, which is the same as renameat with an added flags argument. Pass flags to vfs_rename() and to i_op->rename() as well. All filesystems check flags and return -EOPNOTSUPP for unsupported flags. Signed-off-by: Miklos Szeredi ---

[PATCH 04/11] vfs: add renameat2 syscall

2014-01-08 Thread Miklos Szeredi
From: Miklos Szeredi mszer...@suse.cz Add new renameat2 syscall, which is the same as renameat with an added flags argument. Pass flags to vfs_rename() and to i_op-rename() as well. All filesystems check flags and return -EOPNOTSUPP for unsupported flags. Signed-off-by: Miklos Szeredi

[PATCH 04/11] vfs: add renameat2 syscall

2013-11-20 Thread Miklos Szeredi
From: Miklos Szeredi Add new renameat2 syscall, which is the same as renameat with an added flags argument. Pass flags to vfs_rename() and to i_op->rename() as well. All filesystems check flags and return -EOPNOTSUPP for unsupported flags. Signed-off-by: Miklos Szeredi ---

[PATCH 04/11] vfs: add renameat2 syscall

2013-11-20 Thread Miklos Szeredi
From: Miklos Szeredi mszer...@suse.cz Add new renameat2 syscall, which is the same as renameat with an added flags argument. Pass flags to vfs_rename() and to i_op-rename() as well. All filesystems check flags and return -EOPNOTSUPP for unsupported flags. Signed-off-by: Miklos Szeredi