Re: [PATCH 04/13] rbtree: move some implementation details from rbtree.h to rbtree.c

2012-07-11 Thread Michal Nazarewicz
On Wed, 11 Jul 2012 01:12:54 +0200, Michel Lespinasse wrote: On Tue, Jul 10, 2012 at 5:19 AM, Michal Nazarewicz wrote: On Tue, 10 Jul 2012 01:35:14 +0200, Michel Lespinasse wrote: +#defineRB_RED 0 +#defineRB_BLACK1 Interestingly, those are almost never

Re: [PATCH 04/13] rbtree: move some implementation details from rbtree.h to rbtree.c

2012-07-11 Thread Michal Nazarewicz
On Wed, 11 Jul 2012 01:12:54 +0200, Michel Lespinasse wal...@google.com wrote: On Tue, Jul 10, 2012 at 5:19 AM, Michal Nazarewicz min...@mina86.com wrote: On Tue, 10 Jul 2012 01:35:14 +0200, Michel Lespinasse wal...@google.com wrote: +#defineRB_RED 0 +#defineRB_BLACK

Re: [PATCH 04/13] rbtree: move some implementation details from rbtree.h to rbtree.c

2012-07-10 Thread Michel Lespinasse
On Tue, Jul 10, 2012 at 5:19 AM, Michal Nazarewicz wrote: > On Tue, 10 Jul 2012 01:35:14 +0200, Michel Lespinasse > wrote: >> +#defineRB_RED 0 >> +#defineRB_BLACK1 > > Interestingly, those are almost never used. RB_BLACK is used only once. > Should we get rid of

Re: [PATCH 04/13] rbtree: move some implementation details from rbtree.h to rbtree.c

2012-07-10 Thread Michal Nazarewicz
On Tue, 10 Jul 2012 01:35:14 +0200, Michel Lespinasse wrote: rbtree users must use the documented APIs to manipulate the tree structure. Low-level helpers to manipulate node colors and parenthood are not part of that API, so move them to lib/rbtree.c Signed-off-by: Michel Lespinasse ---

Re: [PATCH 04/13] rbtree: move some implementation details from rbtree.h to rbtree.c

2012-07-10 Thread Michal Nazarewicz
On Tue, 10 Jul 2012 01:35:14 +0200, Michel Lespinasse wal...@google.com wrote: rbtree users must use the documented APIs to manipulate the tree structure. Low-level helpers to manipulate node colors and parenthood are not part of that API, so move them to lib/rbtree.c Signed-off-by: Michel

Re: [PATCH 04/13] rbtree: move some implementation details from rbtree.h to rbtree.c

2012-07-10 Thread Michel Lespinasse
On Tue, Jul 10, 2012 at 5:19 AM, Michal Nazarewicz min...@mina86.com wrote: On Tue, 10 Jul 2012 01:35:14 +0200, Michel Lespinasse wal...@google.com wrote: +#defineRB_RED 0 +#defineRB_BLACK1 Interestingly, those are almost never used. RB_BLACK is used only

[PATCH 04/13] rbtree: move some implementation details from rbtree.h to rbtree.c

2012-07-09 Thread Michel Lespinasse
rbtree users must use the documented APIs to manipulate the tree structure. Low-level helpers to manipulate node colors and parenthood are not part of that API, so move them to lib/rbtree.c Signed-off-by: Michel Lespinasse --- include/linux/rbtree.h | 16 lib/rbtree.c

[PATCH 04/13] rbtree: move some implementation details from rbtree.h to rbtree.c

2012-07-09 Thread Michel Lespinasse
rbtree users must use the documented APIs to manipulate the tree structure. Low-level helpers to manipulate node colors and parenthood are not part of that API, so move them to lib/rbtree.c Signed-off-by: Michel Lespinasse wal...@google.com --- include/linux/rbtree.h | 16