Re: [PATCH 05/14] HID: i2c-hid: fix i2c_hid_dbg macro

2012-12-05 Thread Jiri Kosina
On Tue, 4 Dec 2012, Jean Delvare wrote: > > This avoids the problematic case: > > > > if (condition) > > i2c_hid_dbg(ihid, "Blah blah %d\n", i); > > else > > do_something_very_important(); > > > > Which looks correct, however with the previous macro definition, > > this expands to the

Re: [PATCH 05/14] HID: i2c-hid: fix i2c_hid_dbg macro

2012-12-05 Thread Jiri Kosina
On Tue, 4 Dec 2012, Jean Delvare wrote: This avoids the problematic case: if (condition) i2c_hid_dbg(ihid, Blah blah %d\n, i); else do_something_very_important(); Which looks correct, however with the previous macro definition, this expands to the unexpected: if

Re: [PATCH 05/14] HID: i2c-hid: fix i2c_hid_dbg macro

2012-12-04 Thread Jean Delvare
On Tue, 4 Dec 2012 16:27:46 +0100, Benjamin Tissoires wrote: > This avoids the problematic case: > > if (condition) > i2c_hid_dbg(ihid, "Blah blah %d\n", i); > else > do_something_very_important(); > > Which looks correct, however with the previous macro definition, > this expands

Re: [PATCH 05/14] HID: i2c-hid: fix i2c_hid_dbg macro

2012-12-04 Thread Jean Delvare
On Tue, 4 Dec 2012 16:27:46 +0100, Benjamin Tissoires wrote: This avoids the problematic case: if (condition) i2c_hid_dbg(ihid, Blah blah %d\n, i); else do_something_very_important(); Which looks correct, however with the previous macro definition, this expands to the