Re: [PATCH 05/16] rcu: De-offloading CB kthread

2020-11-04 Thread Frederic Weisbecker
On Wed, Nov 04, 2020 at 10:42:09PM +0800, Boqun Feng wrote: > On Wed, Nov 04, 2020 at 03:31:35PM +0100, Frederic Weisbecker wrote: > [...] > > > > > > > + rcu_segcblist_offload(cblist, false); > > > > + raw_spin_unlock_rcu_node(rnp); > > > > + > > > > + if (rdp->nocb_cb_sleep) {

Re: [PATCH 05/16] rcu: De-offloading CB kthread

2020-11-04 Thread Boqun Feng
On Wed, Nov 04, 2020 at 03:31:35PM +0100, Frederic Weisbecker wrote: [...] > > > > > + rcu_segcblist_offload(cblist, false); > > > + raw_spin_unlock_rcu_node(rnp); > > > + > > > + if (rdp->nocb_cb_sleep) { > > > + rdp->nocb_cb_sleep = false; > > > + wake_cb = true; > > > + } > > >

Re: [PATCH 05/16] rcu: De-offloading CB kthread

2020-11-04 Thread Frederic Weisbecker
On Mon, Nov 02, 2020 at 09:38:24PM +0800, Boqun Feng wrote: > Hi Frederic, > > Could you copy the r...@vger.kernel.org if you have another version, it > will help RCU hobbyists like me to catch up news in RCU, thanks! ;-) Sure! Will do! > > +static int __rcu_nocb_rdp_deoffload(struct rcu_data

Re: [PATCH 05/16] rcu: De-offloading CB kthread

2020-11-02 Thread Boqun Feng
Hi Frederic, Could you copy the r...@vger.kernel.org if you have another version, it will help RCU hobbyists like me to catch up news in RCU, thanks! ;-) Please see below for some comments, I'm still reading the whole patchset, so probably I miss something.. On Fri, Oct 23, 2020 at 04:46:38PM

[PATCH 05/16] rcu: De-offloading CB kthread

2020-10-23 Thread Frederic Weisbecker
In order to de-offload the callbacks processing of an rdp, we must clear SEGCBLIST_OFFLOAD and notify the CB kthread so that it clears its own bit flag and goes to sleep to stop handling callbacks. The GP kthread will also be notified the same way. Whoever acknowledges and clears its own bit last