Re: [PATCH 05/23] x86, mm: document X86_CR4_PGE toggling behavior

2017-10-31 Thread Kees Cook
On Tue, Oct 31, 2017 at 3:31 PM, Dave Hansen wrote: > > The comment says it all here. The problem here is that the > X86_CR4_PGE bit affects all PCIDs in a way that is totally > obscure. > > This makes it easier for someone to find if grepping for PCID- > related

Re: [PATCH 05/23] x86, mm: document X86_CR4_PGE toggling behavior

2017-10-31 Thread Kees Cook
On Tue, Oct 31, 2017 at 3:31 PM, Dave Hansen wrote: > > The comment says it all here. The problem here is that the > X86_CR4_PGE bit affects all PCIDs in a way that is totally > obscure. > > This makes it easier for someone to find if grepping for PCID- > related stuff and documents the hardware

[PATCH 05/23] x86, mm: document X86_CR4_PGE toggling behavior

2017-10-31 Thread Dave Hansen
The comment says it all here. The problem here is that the X86_CR4_PGE bit affects all PCIDs in a way that is totally obscure. This makes it easier for someone to find if grepping for PCID- related stuff and documents the hardware behavior that we are depending on. Signed-off-by: Dave Hansen

[PATCH 05/23] x86, mm: document X86_CR4_PGE toggling behavior

2017-10-31 Thread Dave Hansen
The comment says it all here. The problem here is that the X86_CR4_PGE bit affects all PCIDs in a way that is totally obscure. This makes it easier for someone to find if grepping for PCID- related stuff and documents the hardware behavior that we are depending on. Signed-off-by: Dave Hansen