Re: [PATCH 06/12] xfs: remove XFS_TRANS_NOFS

2019-06-25 Thread Christoph Hellwig
On Tue, Jun 25, 2019 at 08:59:04AM +1000, Dave Chinner wrote: > On Mon, Jun 24, 2019 at 07:52:47AM +0200, Christoph Hellwig wrote: > > Instead of a magic flag for xfs_trans_alloc, just ensure all callers > > that can't relclaim through the file system use memalloc_nofs_save to > > set the per-task

Re: [PATCH 06/12] xfs: remove XFS_TRANS_NOFS

2019-06-24 Thread Dave Chinner
On Mon, Jun 24, 2019 at 07:52:47AM +0200, Christoph Hellwig wrote: > Instead of a magic flag for xfs_trans_alloc, just ensure all callers > that can't relclaim through the file system use memalloc_nofs_save to > set the per-task nofs flag. I'm thinking that it would be a good idea to add comments

Re: [PATCH 06/12] xfs: remove XFS_TRANS_NOFS

2019-06-24 Thread Darrick J. Wong
On Mon, Jun 24, 2019 at 07:52:47AM +0200, Christoph Hellwig wrote: > Instead of a magic flag for xfs_trans_alloc, just ensure all callers > that can't relclaim through the file system use memalloc_nofs_save to > set the per-task nofs flag. > > Signed-off-by: Christoph Hellwig Hmm this finally

[PATCH 06/12] xfs: remove XFS_TRANS_NOFS

2019-06-23 Thread Christoph Hellwig
Instead of a magic flag for xfs_trans_alloc, just ensure all callers that can't relclaim through the file system use memalloc_nofs_save to set the per-task nofs flag. Signed-off-by: Christoph Hellwig --- fs/xfs/libxfs/xfs_shared.h | 1 - fs/xfs/xfs_aops.c | 12 +---