Re: [PATCH 06/15] habanalabs: add basic Goya h/w initialization

2019-01-28 Thread Oded Gabbay
On Fri, Jan 25, 2019 at 9:46 AM Mike Rapoport wrote: > > Hi, > > This starts the 6-9 review :) > > These were more difficult to review because small pieces of code are > interleaved with > large sequences of register writes. Probably making these register data > rather than code can help. > > On

Re: [PATCH 06/15] habanalabs: add basic Goya h/w initialization

2019-01-24 Thread Mike Rapoport
Hi, This starts the 6-9 review :) These were more difficult to review because small pieces of code are interleaved with large sequences of register writes. Probably making these register data rather than code can help. On Wed, Jan 23, 2019 at 02:00:48AM +0200, Oded Gabbay wrote: > This patch ad