Re: [PATCH 06/16] fs: fix kernel_write prototype

2017-09-01 Thread Christoph Hellwig
On Wed, Aug 30, 2017 at 04:39:00PM +0100, Al Viro wrote: > On Wed, Aug 30, 2017 at 04:59:57PM +0200, Christoph Hellwig wrote: > > > for (prot = 0; prot < prot_length;) { > > sector_t len = min_t(sector_t, bufsize, prot_length - prot); > > - ssize_t ret =

Re: [PATCH 06/16] fs: fix kernel_write prototype

2017-09-01 Thread Christoph Hellwig
On Wed, Aug 30, 2017 at 04:39:00PM +0100, Al Viro wrote: > On Wed, Aug 30, 2017 at 04:59:57PM +0200, Christoph Hellwig wrote: > > > for (prot = 0; prot < prot_length;) { > > sector_t len = min_t(sector_t, bufsize, prot_length - prot); > > - ssize_t ret =

Re: [PATCH 06/16] fs: fix kernel_write prototype

2017-08-30 Thread Al Viro
On Wed, Aug 30, 2017 at 04:59:57PM +0200, Christoph Hellwig wrote: > for (prot = 0; prot < prot_length;) { > sector_t len = min_t(sector_t, bufsize, prot_length - prot); > - ssize_t ret = kernel_write(prot_fd, buf, len, pos + prot); > + ssize_t ret =

Re: [PATCH 06/16] fs: fix kernel_write prototype

2017-08-30 Thread Al Viro
On Wed, Aug 30, 2017 at 04:59:57PM +0200, Christoph Hellwig wrote: > for (prot = 0; prot < prot_length;) { > sector_t len = min_t(sector_t, bufsize, prot_length - prot); > - ssize_t ret = kernel_write(prot_fd, buf, len, pos + prot); > + ssize_t ret =

[PATCH 06/16] fs: fix kernel_write prototype

2017-08-30 Thread Christoph Hellwig
Make the position an in/out argument like all the other read/write helpers. Signed-off-by: Christoph Hellwig --- drivers/mtd/nand/nandsim.c| 2 +- drivers/target/target_core_alua.c | 3 ++- drivers/target/target_core_file.c | 3 +-- drivers/target/target_core_pr.c | 3 ++-

[PATCH 06/16] fs: fix kernel_write prototype

2017-08-30 Thread Christoph Hellwig
Make the position an in/out argument like all the other read/write helpers. Signed-off-by: Christoph Hellwig --- drivers/mtd/nand/nandsim.c| 2 +- drivers/target/target_core_alua.c | 3 ++- drivers/target/target_core_file.c | 3 +-- drivers/target/target_core_pr.c | 3 ++-