Re: [PATCH 06/21] ARCNET: com20020: remove unneeded macros

2015-04-27 Thread Michael Grzeschik
On Fri, Apr 24, 2015 at 04:04:45PM -0700, Joe Perches wrote: > On Fri, 2015-04-24 at 19:20 +0200, Michael Grzeschik wrote: > > The macros SET_SUBADR, ARCRESET, ARCRESET0, ACOMMAND, ASTATUS, AINTMASK > > and ADIAGSTATUS are unnecessary indirections to the use of registers. > > This patch removes

Re: [PATCH 06/21] ARCNET: com20020: remove unneeded macros

2015-04-27 Thread Michael Grzeschik
On Fri, Apr 24, 2015 at 04:04:45PM -0700, Joe Perches wrote: On Fri, 2015-04-24 at 19:20 +0200, Michael Grzeschik wrote: The macros SET_SUBADR, ARCRESET, ARCRESET0, ACOMMAND, ASTATUS, AINTMASK and ADIAGSTATUS are unnecessary indirections to the use of registers. This patch removes them and

Re: [PATCH 06/21] ARCNET: com20020: remove unneeded macros

2015-04-24 Thread David Miller
From: Joe Perches Date: Fri, 24 Apr 2015 16:04:45 -0700 > On Fri, 2015-04-24 at 19:20 +0200, Michael Grzeschik wrote: >> The macros SET_SUBADR, ARCRESET, ARCRESET0, ACOMMAND, ASTATUS, AINTMASK >> and ADIAGSTATUS are unnecessary indirections to the use of registers. >> This patch removes them and

Re: [PATCH 06/21] ARCNET: com20020: remove unneeded macros

2015-04-24 Thread Joe Perches
On Fri, 2015-04-24 at 19:20 +0200, Michael Grzeschik wrote: > The macros SET_SUBADR, ARCRESET, ARCRESET0, ACOMMAND, ASTATUS, AINTMASK > and ADIAGSTATUS are unnecessary indirections to the use of registers. > This patch removes them and improves the readability of the code. This breaks

[PATCH 06/21] ARCNET: com20020: remove unneeded macros

2015-04-24 Thread Michael Grzeschik
The macros SET_SUBADR, ARCRESET, ARCRESET0, ACOMMAND, ASTATUS, AINTMASK and ADIAGSTATUS are unnecessary indirections to the use of registers. This patch removes them and improves the readability of the code. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com20020-isa.c | 2 +-

Re: [PATCH 06/21] ARCNET: com20020: remove unneeded macros

2015-04-24 Thread Joe Perches
On Fri, 2015-04-24 at 19:20 +0200, Michael Grzeschik wrote: The macros SET_SUBADR, ARCRESET, ARCRESET0, ACOMMAND, ASTATUS, AINTMASK and ADIAGSTATUS are unnecessary indirections to the use of registers. This patch removes them and improves the readability of the code. This breaks compilation.

Re: [PATCH 06/21] ARCNET: com20020: remove unneeded macros

2015-04-24 Thread David Miller
From: Joe Perches j...@perches.com Date: Fri, 24 Apr 2015 16:04:45 -0700 On Fri, 2015-04-24 at 19:20 +0200, Michael Grzeschik wrote: The macros SET_SUBADR, ARCRESET, ARCRESET0, ACOMMAND, ASTATUS, AINTMASK and ADIAGSTATUS are unnecessary indirections to the use of registers. This patch removes

[PATCH 06/21] ARCNET: com20020: remove unneeded macros

2015-04-24 Thread Michael Grzeschik
The macros SET_SUBADR, ARCRESET, ARCRESET0, ACOMMAND, ASTATUS, AINTMASK and ADIAGSTATUS are unnecessary indirections to the use of registers. This patch removes them and improves the readability of the code. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de ---