On Fri, Jun 19, 2015 at 11:18:48AM +0200, Michal Hocko wrote:
> On Thu 18-06-15 13:49:30, Tejun Heo wrote:
> [...]
> > > I have tried to compile with !CONFIG_MEMCG and !CONFIG_CGROUP_WRITEBACK
> > > without mem_cgroup_root_css defined for this configuration and
> > > mm/backing-dev.c compiles just
On Thu 18-06-15 13:49:30, Tejun Heo wrote:
[...]
> > I have tried to compile with !CONFIG_MEMCG and !CONFIG_CGROUP_WRITEBACK
> > without mem_cgroup_root_css defined for this configuration and
> > mm/backing-dev.c compiles just fine. So maybe we should get rid of it
> > rather than have a
On Thu 18-06-15 13:49:30, Tejun Heo wrote:
[...]
I have tried to compile with !CONFIG_MEMCG and !CONFIG_CGROUP_WRITEBACK
without mem_cgroup_root_css defined for this configuration and
mm/backing-dev.c compiles just fine. So maybe we should get rid of it
rather than have a potentially
On Fri, Jun 19, 2015 at 11:18:48AM +0200, Michal Hocko wrote:
On Thu 18-06-15 13:49:30, Tejun Heo wrote:
[...]
I have tried to compile with !CONFIG_MEMCG and !CONFIG_CGROUP_WRITEBACK
without mem_cgroup_root_css defined for this configuration and
mm/backing-dev.c compiles just fine. So
Hello, Michal.
On Thu, Jun 18, 2015 at 01:12:27PM +0200, Michal Hocko wrote:
...
> I see and yes, it makes some sense. I just think we can get rid of the
> accessor functions when the struct mem_cgroup is visible and the code
> can simply do &{page->}mem_cgroup->css.
As long as the accessors are
On Wed 17-06-15 14:25:00, Tejun Heo wrote:
> Hey, Michal.
>
> On Wed, Jun 17, 2015 at 04:56:42PM +0200, Michal Hocko wrote:
> > On Fri 22-05-15 17:13:20, Tejun Heo wrote:
> > > Add global mem_cgroup_root_css which points to the root memcg css.
> >
> > Is there any reason to using css rather than
On Wed 17-06-15 14:25:00, Tejun Heo wrote:
Hey, Michal.
On Wed, Jun 17, 2015 at 04:56:42PM +0200, Michal Hocko wrote:
On Fri 22-05-15 17:13:20, Tejun Heo wrote:
Add global mem_cgroup_root_css which points to the root memcg css.
Is there any reason to using css rather than mem_cgroup
Hello, Michal.
On Thu, Jun 18, 2015 at 01:12:27PM +0200, Michal Hocko wrote:
...
I see and yes, it makes some sense. I just think we can get rid of the
accessor functions when the struct mem_cgroup is visible and the code
can simply do {page-}mem_cgroup-css.
As long as the accessors are
Hey, Michal.
On Wed, Jun 17, 2015 at 04:56:42PM +0200, Michal Hocko wrote:
> On Fri 22-05-15 17:13:20, Tejun Heo wrote:
> > Add global mem_cgroup_root_css which points to the root memcg css.
>
> Is there any reason to using css rather than mem_cgroup other than the
> structure is not visible
On Fri 22-05-15 17:13:20, Tejun Heo wrote:
> Add global mem_cgroup_root_css which points to the root memcg css.
Is there any reason to using css rather than mem_cgroup other than the
structure is not visible outside of memcontrol.c? Because I have a
patchset which exports it. It is not merged yet
Hey, Michal.
On Wed, Jun 17, 2015 at 04:56:42PM +0200, Michal Hocko wrote:
On Fri 22-05-15 17:13:20, Tejun Heo wrote:
Add global mem_cgroup_root_css which points to the root memcg css.
Is there any reason to using css rather than mem_cgroup other than the
structure is not visible outside
On Fri 22-05-15 17:13:20, Tejun Heo wrote:
Add global mem_cgroup_root_css which points to the root memcg css.
Is there any reason to using css rather than mem_cgroup other than the
structure is not visible outside of memcontrol.c? Because I have a
patchset which exports it. It is not merged yet
Add global mem_cgroup_root_css which points to the root memcg css.
This will be used by cgroup writeback support. If memcg is disabled,
it's defined as ERR_PTR(-EINVAL).
Signed-off-by: Tejun Heo
Cc: Johannes Weiner
aCc: Michal Hocko
---
include/linux/memcontrol.h | 4
mm/memcontrol.c
Add global mem_cgroup_root_css which points to the root memcg css.
This will be used by cgroup writeback support. If memcg is disabled,
it's defined as ERR_PTR(-EINVAL).
Signed-off-by: Tejun Heo t...@kernel.org
Cc: Johannes Weiner han...@cmpxchg.org
aCc: Michal Hocko mho...@suse.cz
---
14 matches
Mail list logo
