Re: [PATCH 07/10] sched, fair: Optimize find_busiest_queue()

2013-08-27 Thread Paul Turner
On Mon, Aug 26, 2013 at 5:07 AM, Peter Zijlstra wrote: > On Sat, Aug 24, 2013 at 03:33:59AM -0700, Paul Turner wrote: >> On Mon, Aug 19, 2013 at 9:01 AM, Peter Zijlstra wrote: >> > +++ b/kernel/sched/fair.c >> > @@ -4977,7 +4977,7 @@ static struct rq *find_busiest_queue(str >> > unsigned

Re: [PATCH 07/10] sched, fair: Optimize find_busiest_queue()

2013-08-27 Thread Paul Turner
On Mon, Aug 26, 2013 at 5:07 AM, Peter Zijlstra pet...@infradead.org wrote: On Sat, Aug 24, 2013 at 03:33:59AM -0700, Paul Turner wrote: On Mon, Aug 19, 2013 at 9:01 AM, Peter Zijlstra pet...@infradead.org wrote: +++ b/kernel/sched/fair.c @@ -4977,7 +4977,7 @@ static struct rq

Re: [PATCH 07/10] sched, fair: Optimize find_busiest_queue()

2013-08-26 Thread Peter Zijlstra
On Sat, Aug 24, 2013 at 03:33:59AM -0700, Paul Turner wrote: > On Mon, Aug 19, 2013 at 9:01 AM, Peter Zijlstra wrote: > > +++ b/kernel/sched/fair.c > > @@ -4977,7 +4977,7 @@ static struct rq *find_busiest_queue(str > > unsigned long busiest_load = 0, busiest_power = SCHED_POWER_SCALE; > >

Re: [PATCH 07/10] sched, fair: Optimize find_busiest_queue()

2013-08-26 Thread Peter Zijlstra
On Sat, Aug 24, 2013 at 03:33:59AM -0700, Paul Turner wrote: On Mon, Aug 19, 2013 at 9:01 AM, Peter Zijlstra pet...@infradead.org wrote: +++ b/kernel/sched/fair.c @@ -4977,7 +4977,7 @@ static struct rq *find_busiest_queue(str unsigned long busiest_load = 0, busiest_power =

Re: [PATCH 07/10] sched, fair: Optimize find_busiest_queue()

2013-08-24 Thread Paul Turner
On Mon, Aug 19, 2013 at 9:01 AM, Peter Zijlstra wrote: > Use for_each_cpu_and() and thereby avoid computing the capacity for > CPUs we know we're not interested in. > > Signed-off-by: Peter Zijlstra > --- > kernel/sched/fair.c |5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > >

Re: [PATCH 07/10] sched, fair: Optimize find_busiest_queue()

2013-08-24 Thread Paul Turner
On Mon, Aug 19, 2013 at 9:01 AM, Peter Zijlstra pet...@infradead.org wrote: Use for_each_cpu_and() and thereby avoid computing the capacity for CPUs we know we're not interested in. Signed-off-by: Peter Zijlstra pet...@infradead.org --- kernel/sched/fair.c |5 + 1 file changed, 1

Re: [PATCH 07/10] sched, fair: Optimize find_busiest_queue()

2013-08-23 Thread Preeti U Murthy
On 08/23/2013 03:33 PM, Peter Zijlstra wrote: > On Fri, Aug 23, 2013 at 01:41:55PM +0530, Preeti U Murthy wrote: >> Hi Peter, >> >> On 08/19/2013 09:31 PM, Peter Zijlstra wrote: >> >> In the load balancing code, looks to me that >> cpumask_copy(cpus, cpu_active_mask) is not updating the env.cpus

Re: [PATCH 07/10] sched, fair: Optimize find_busiest_queue()

2013-08-23 Thread Peter Zijlstra
On Fri, Aug 23, 2013 at 01:41:55PM +0530, Preeti U Murthy wrote: > Hi Peter, > > On 08/19/2013 09:31 PM, Peter Zijlstra wrote: > > In the load balancing code, looks to me that > cpumask_copy(cpus, cpu_active_mask) is not updating the env.cpus at all, > before calling find_busiest_group(). Am I

Re: [PATCH 07/10] sched, fair: Optimize find_busiest_queue()

2013-08-23 Thread Preeti U Murthy
Hi Peter, On 08/19/2013 09:31 PM, Peter Zijlstra wrote: In the load balancing code, looks to me that cpumask_copy(cpus, cpu_active_mask) is not updating the env.cpus at all, before calling find_busiest_group(). Am I missing something? Should not cpumask_copy() below be before we update the

Re: [PATCH 07/10] sched, fair: Optimize find_busiest_queue()

2013-08-23 Thread Preeti U Murthy
Hi Peter, On 08/19/2013 09:31 PM, Peter Zijlstra wrote: In the load balancing code, looks to me that cpumask_copy(cpus, cpu_active_mask) is not updating the env.cpus at all, before calling find_busiest_group(). Am I missing something? Should not cpumask_copy() below be before we update the

Re: [PATCH 07/10] sched, fair: Optimize find_busiest_queue()

2013-08-23 Thread Peter Zijlstra
On Fri, Aug 23, 2013 at 01:41:55PM +0530, Preeti U Murthy wrote: Hi Peter, On 08/19/2013 09:31 PM, Peter Zijlstra wrote: In the load balancing code, looks to me that cpumask_copy(cpus, cpu_active_mask) is not updating the env.cpus at all, before calling find_busiest_group(). Am I missing

Re: [PATCH 07/10] sched, fair: Optimize find_busiest_queue()

2013-08-23 Thread Preeti U Murthy
On 08/23/2013 03:33 PM, Peter Zijlstra wrote: On Fri, Aug 23, 2013 at 01:41:55PM +0530, Preeti U Murthy wrote: Hi Peter, On 08/19/2013 09:31 PM, Peter Zijlstra wrote: In the load balancing code, looks to me that cpumask_copy(cpus, cpu_active_mask) is not updating the env.cpus at all,

[PATCH 07/10] sched, fair: Optimize find_busiest_queue()

2013-08-19 Thread Peter Zijlstra
Use for_each_cpu_and() and thereby avoid computing the capacity for CPUs we know we're not interested in. Signed-off-by: Peter Zijlstra --- kernel/sched/fair.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -4977,7 +4977,7 @@

[PATCH 07/10] sched, fair: Optimize find_busiest_queue()

2013-08-19 Thread Peter Zijlstra
Use for_each_cpu_and() and thereby avoid computing the capacity for CPUs we know we're not interested in. Signed-off-by: Peter Zijlstra pet...@infradead.org --- kernel/sched/fair.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c