Re: [PATCH 07/12] dm: use bvec iterator helpers to implement .get_page and .next_page

2016-11-21 Thread Christoph Hellwig
Jens, can you apply the non-dm patches?

Re: [PATCH 07/12] dm: use bvec iterator helpers to implement .get_page and .next_page

2016-11-21 Thread Ming Lei
On Mon, Nov 21, 2016 at 10:49 PM, Mike Snitzer wrote: > On Fri, Nov 11 2016 at 7:05am -0500, > Ming Lei wrote: > >> Firstly we have mature bvec/bio iterator helper for iterate each >> page in one bio, not necessary to reinvent a wheel to do that. >> >> Secondly the coming multipage bvecs require

Re: [PATCH 07/12] dm: use bvec iterator helpers to implement .get_page and .next_page

2016-11-21 Thread Mike Snitzer
On Fri, Nov 11 2016 at 7:05am -0500, Ming Lei wrote: > Firstly we have mature bvec/bio iterator helper for iterate each > page in one bio, not necessary to reinvent a wheel to do that. > > Secondly the coming multipage bvecs requires this patch. > > Also add comments about the direct access to

Re: [PATCH 07/12] dm: use bvec iterator helpers to implement .get_page and .next_page

2016-11-15 Thread Mike Snitzer
On Tue, Nov 15 2016 at 1:55pm -0500, Christoph Hellwig wrote: > > Hi Alasdair, Mike, Christoph and anyone, > > > > Could you give this one a review? > > It looks nice, but I don't understand the code anywhere near well > enough to review it. We'll need someone from the DM to look over it. I'

Re: [PATCH 07/12] dm: use bvec iterator helpers to implement .get_page and .next_page

2016-11-15 Thread Christoph Hellwig
> Hi Alasdair, Mike, Christoph and anyone, > > Could you give this one a review? It looks nice, but I don't understand the code anywhere near well enough to review it. We'll need someone from the DM to look over it.

Re: [PATCH 07/12] dm: use bvec iterator helpers to implement .get_page and .next_page

2016-11-14 Thread Ming Lei
On Fri, Nov 11, 2016 at 8:05 PM, Ming Lei wrote: > Firstly we have mature bvec/bio iterator helper for iterate each > page in one bio, not necessary to reinvent a wheel to do that. > > Secondly the coming multipage bvecs requires this patch. > > Also add comments about the direct access to bvec ta

[PATCH 07/12] dm: use bvec iterator helpers to implement .get_page and .next_page

2016-11-11 Thread Ming Lei
Firstly we have mature bvec/bio iterator helper for iterate each page in one bio, not necessary to reinvent a wheel to do that. Secondly the coming multipage bvecs requires this patch. Also add comments about the direct access to bvec table. Signed-off-by: Ming Lei --- drivers/md/dm-io.c | 34